mirror of
https://github.com/eclipse-threadx/threadx.git
synced 2026-10-06 06:59:08 +08:00
Frédéric Desbiens
f3df5f9dde
* Fixed the resource leaks on the xQueueCreate error paths xQueueCreate() allocated the queue descriptor and its backing memory, then created two ThreadX semaphores, and returned NULL on either semaphore failure without releasing anything. Since no handle reached the caller, vQueueDelete() could not be used to recover, so both allocations were lost. A failure on the second semaphore additionally abandoned the read semaphore it had already created, leaving a live ThreadX control block inside freed memory. Release the backing memory and the descriptor on both paths, and delete the read semaphore before returning when the write semaphore cannot be created. This is the teardown order vQueueDelete() already uses, and it matches the cleanup xTaskCreate() performs on its own error paths. Verified with a fault injection harness that intercepts the ThreadX byte pool and semaphore entry points to force tx_semaphore_create() to fail on a chosen call. On a read semaphore failure the layer previously performed 2 allocations and 0 releases, and on a write semaphore failure 2 allocations, 0 releases and 0 semaphore deletions. It now performs 2 releases in both cases and deletes the read semaphore in the second, with the byte pool restored to its prior state. Fixes https://github.com/eclipse-threadx/threadx/issues/570 Assisted-by: Claude Code (Opus 5) <noreply@anthropic.com> * Added a regression suite for the FreeRTOS compatibility layer The compatibility layer had no tests in this repository, which is awkward for its creation functions in particular. Each of them takes one or two byte pool allocations for its bookkeeping and then creates ThreadX kernel objects, and each returns NULL when a kernel object cannot be created. The caller is left without a handle, so it cannot call the matching delete function, and anything the layer failed to release is gone until the system restarts. A leaking version and a correct version are indistinguishable from the outside, which is how the leak in issue 570 went unnoticed. Add a suite that counts what the layer takes and gives back. A test asks the harness to fail a chosen kernel creation call, then checks the number of byte pool allocations, releases, object creations and object deletions performed. The ThreadX entry points are intercepted with the linker's --wrap so that tx_freertos.c is compiled exactly as it ships, with no test hooks in it. Note that tx_api.h maps the public API onto the error checking entry points, so the _txe_ symbols are the ones wrapped. Coverage is the creation and teardown paths of queues, tasks, semaphores, mutexes, event groups and timers, including a regression test for the two paths fixed for issue 570. The suite follows the layout of the existing ThreadX and SMP suites, is registered with ctest, and runs in CI through the shared regression template. It is built 32 bit because the Linux port defines ULONG as unsigned int on x86_64 while the layer passes pointers through ULONG arguments, so a 64 bit build truncates them. It is Linux only because --wrap has no MSVC equivalent, and the CMake configuration says so rather than failing at link time. Validated by building the suite against the layer as it stands before the issue 570 fix, where the two expected checks fail with the leaked counts, and against the fixed layer, where all three tests pass. Assisted-by: Claude Code (Opus 5) <noreply@anthropic.com>
92 lines
2.5 KiB
YAML
92 lines
2.5 KiB
YAML
name: regression_test
|
|
|
|
# Controls when the action will run. Triggers the workflow on push or pull request
|
|
# events but only for the master branch
|
|
on:
|
|
workflow_dispatch:
|
|
push:
|
|
branches: [ master ]
|
|
pull_request:
|
|
branches: [ master ]
|
|
|
|
# A workflow run is made up of one or more jobs that can run sequentially or in parallel
|
|
jobs:
|
|
tx:
|
|
permissions:
|
|
contents: read
|
|
issues: read
|
|
checks: write
|
|
pull-requests: write
|
|
pages: write
|
|
id-token: write
|
|
uses: ./.github/workflows/regression_template.yml
|
|
with:
|
|
build_script: ./scripts/build_tx.sh
|
|
test_script: ./scripts/test_tx.sh
|
|
cmake_path: ./test/tx/cmake
|
|
result_affix: ThreadX
|
|
skip_deploy: true
|
|
smp:
|
|
permissions:
|
|
contents: read
|
|
issues: read
|
|
checks: write
|
|
pull-requests: write
|
|
pages: write
|
|
id-token: write
|
|
uses: ./.github/workflows/regression_template.yml
|
|
with:
|
|
build_script: ./scripts/build_smp.sh
|
|
test_script: ./scripts/test_smp.sh
|
|
cmake_path: ./test/smp/cmake
|
|
result_affix: SMP
|
|
skip_deploy: true
|
|
freertos:
|
|
permissions:
|
|
contents: read
|
|
issues: read
|
|
checks: write
|
|
pull-requests: write
|
|
pages: write
|
|
id-token: write
|
|
uses: ./.github/workflows/regression_template.yml
|
|
with:
|
|
build_script: ./scripts/build_freertos.sh
|
|
test_script: ./scripts/test_freertos.sh
|
|
cmake_path: ./test/freertos/cmake
|
|
result_affix: FreeRTOS
|
|
skip_deploy: true
|
|
# No coverage build configuration yet; the suite covers the creation
|
|
# paths of the layer rather than all of it.
|
|
skip_coverage: true
|
|
# riscv: disabled — re-enable when RISC-V CI is ready
|
|
# riscv:
|
|
# permissions:
|
|
# contents: read
|
|
# issues: read
|
|
# checks: write
|
|
# pull-requests: write
|
|
# pages: write
|
|
# id-token: write
|
|
# uses: ./.github/workflows/regression_template.yml
|
|
# with:
|
|
# install_script: ./scripts/install_riscv.sh
|
|
# build_script: ./scripts/build_tx_riscv.sh
|
|
# test_script: ./scripts/test_tx_riscv.sh
|
|
# cmake_path: ./test/tx/cmake/riscv
|
|
# result_affix: RISC-V
|
|
# skip_deploy: true
|
|
# skip_coverage: true
|
|
deploy:
|
|
permissions:
|
|
contents: read
|
|
issues: read
|
|
checks: write
|
|
pull-requests: write
|
|
pages: write
|
|
id-token: write
|
|
needs: [tx, smp]
|
|
uses: ./.github/workflows/regression_template.yml
|
|
with:
|
|
skip_test: true
|
|
deploy_list: "ThreadX SMP" |