The zero size allocations had no consistent behaviour in RTEMS. For
example, malloc( 0 ) returned NULL and posix_memalign( &p, align, 0 )
returned in p a unique pointer (or NULL if no memory is available). In
POSIX, zero size memory allocations are implementation-defined
behaviour. The implementation has two options:
https://pubs.opengroup.org/onlinepubs/9699919799/functions/malloc.htmlhttps://pubs.opengroup.org/onlinepubs/9699919799/functions/posix_memalign.html
Linux and FreeBSD return a unique pointer for zero size memory
allocations. Use this approach for RTEMS as well throughout the memory
allocation directives
Close#4390.
Replace malloc_is_system_state_OK() with _Malloc_System_state() to allow
early allocations, e.g. in bsp_start(). Here the _Thread_Executing is
NULL, thus an _API_Mutex_Lock() would lead to a NULL pointer access.
Move malloc() support code to general case
rtems_heap_allocate_aligned_with_boundary(). Use
rtems_heap_allocate_aligned_with_boundary() to avoid duplicated code.
The work areas (RTEMS work space and C program heap) will be initialized
now in a separate step and are no longer part of
rtems_initialize_data_structures(). Initialization is performed with
tables of Heap_Area entries. This allows usage of scattered memory
areas present on various small scale micro-controllers.
The sbrk() support API changes also. The bsp_sbrk_init() must now deal
with a minimum size for the first memory chunk to take the configured
work space size into account.
Script does what is expected and tries to do it as
smartly as possible.
+ remove occurrences of two blank comment lines
next to each other after Id string line removed.
+ remove entire comment blocks which only exited to
contain CVS Ids
+ If the processing left a blank line at the top of
a file, it was removed.
PR 1472/cpukit
* libcsupport/Makefile.am, libcsupport/include/rtems/malloc.h,
libcsupport/src/free.c, libcsupport/src/malloc.c,
libcsupport/src/malloc_initialize.c, libcsupport/src/realloc.c,
libcsupport/src/rtems_memalign.c: Remove malloc boundary code. It has
not been used since before 4.6 and is bitrotted.
* libcsupport/src/malloc_boundary.c: Removed.
* libcsupport/src/free.c, libcsupport/src/malloc.c,
libcsupport/src/malloc_initialize.c, libcsupport/src/malloc_p.h,
libcsupport/src/malloc_sbrk_helpers.c,
libcsupport/src/malloc_statistics_helpers.c,
libcsupport/src/malloc_walk.c, libcsupport/src/mallocfreespace.c,
libcsupport/src/mallocinfo.c, libcsupport/src/realloc.c,
libcsupport/src/rtems_memalign.c, sapi/include/confdefs.h,
score/inline/rtems/score/thread.inl: Add support for optionally
having a unified work area. In other words, the RTEMS Workspace and C
Program Heap are the same pool of memory.
* libcsupport/Makefile.am, libcsupport/include/rtems/malloc.h,
libcsupport/src/free.c, libcsupport/src/malloc.c,
libcsupport/src/malloc_deferred.c,
libcsupport/src/malloc_initialize.c, libcsupport/src/malloc_p.h,
libcsupport/src/malloc_sbrk_helpers.c,
libcsupport/src/posix_memalign.c: Place all deferred free code and
place it in subroutines. Add plugin for dirtying allocated memory to
assist in debugging. Clean up comments and spacing as needed.
* libcsupport/src/malloc_dirtier.c: New file.
* libcsupport/Makefile.am: Add malloc_sbrk_helpers.c.
* libcsupport/include/rtems/malloc.h,
libcsupport/src/malloc.c, libcsupport/src/malloc_initialize.c,
libcsupport/src/malloc_p.h,
libcsupport/src/malloc_statistics_helpers.c: Make sbrk()
support pluggable and optional. This eliminates the need for
heap extend and sbrk in the minimum footprint which is ~2.5K on
the SPARC.
* sapi/include/confdefs.h: Add the following configuration points:
+ CONFIGURE_MALLOC_STATISTICS
+ CONFIGURE_MALLOC_BSP_SUPPORTS_SBRK
* libcsupport/src/malloc_sbrk_helpers.c: New file.
* libcsupport/Makefile.am, libcsupport/preinstall.am,
libcsupport/src/malloc.c, libcsupport/src/mallocinfo.c,
libmisc/Makefile.am, libmisc/shell/main_mallocinfo.c,
libmisc/shell/shellconfig.h: Split malloc.c into multiple files with
one function per file. Also split out statistics into a separate file
which can be plugged in dynamically. Right now, it is always in. I
suspect that splitting the file removed more code than leaving
statistics in. I tinkered with malloc information command in the
shell. I resurrected the malloc arena code as malloc boundary. This
code is now compiled all the time even though it does not appear to
work.
* libcsupport/include/rtems/malloc.h, libcsupport/src/_calloc_r.c,
libcsupport/src/_free_r.c, libcsupport/src/_malloc_r.c,
libcsupport/src/_realloc_r.c, libcsupport/src/calloc.c,
libcsupport/src/free.c, libcsupport/src/malloc_boundary.c,
libcsupport/src/malloc_get_statistics.c,
libcsupport/src/malloc_initialize.c, libcsupport/src/malloc_p.h,
libcsupport/src/malloc_report_statistics.c,
libcsupport/src/malloc_report_statistics_plugin.c,
libcsupport/src/malloc_statistics_helpers.c,
libcsupport/src/malloc_walk.c, libcsupport/src/realloc.c,
libmisc/shell/main_perioduse.c: New files.
* libcsupport/src/malloc.c, libmisc/monitor/mon-command.c,
posix/preinstall.am, posix/include/rtems/posix/cond.h,
posix/include/rtems/posix/mqueue.h,
posix/include/rtems/posix/mutex.h,
posix/include/rtems/posix/pthread.h,
posix/include/rtems/posix/semaphore.h, posix/src/conddestroy.c,
posix/src/mutexdestroy.c, posix/src/mutexinit.c,
posix/src/mutexsetprioceiling.c, posix/src/mutexunlock.c,
sapi/include/confdefs.h, sapi/include/rtems/config.h,
sapi/include/rtems/init.h, sapi/include/rtems/sptables.h,
sapi/src/exinit.c, score/include/rtems/system.h,
score/include/rtems/score/mpci.h, score/src/mpci.c,
score/src/thread.c, score/src/threadcreateidle.c,
score/src/threadstackallocate.c, score/src/threadstackfree.c,
score/src/wkspace.c: Moved most of the remaining CPU Table fields to
the Configuration Table. This included pretasking_hook,
predriver_hook, postdriver_hook, idle_task, do_zero_of_workspace,
extra_mpci_receive_server_stack, stack_allocate_hook, and
stack_free_hook. As a side-effect of this effort some multiprocessing
code was made conditional and some style clean up occurred.
* libcsupport/src/malloc.c: If RTEMS_HEAP_DEBUG is defined, add heap
walk on init, malloc, and free. The ability to walk the heap appears
to disappeared during the rework of the C Program heap to skip the
Region.
* libcsupport/src/malloc.c: Clean up Malloc debug code.
* score/include/rtems/score/heap.h: Spacing.
* score/inline/rtems/score/thread.inl:
* score/src/heapfree.c. Clean up and add explicit check of the address
being freed actually being in the heap.
* score/src/heapwalk.c: Switch to printk and do not call abort.
* ChangeLog, libcsupport/src/malloc.c,
libcsupport/src/mallocfreespace.c, sapi/include/confdefs.h,
score/Makefile.am, score/preinstall.am: malloc never blocks so the
Region Manager is quite heavy for implementing this. This patch
implements the C Program Heap directly in terms of the new Protected
Heap handler. This handler is a direct use of a SuperCore Heap in
conjunction with the Allocator Mutex used internally by RTEMS. This
saves 3184 bytes on most SPARC test executables.
* score/include/rtems/score/protectedheap.h, score/src/pheapallocate.c,
score/src/pheapallocatealigned.c, score/src/pheapextend.c,
score/src/pheapfree.c, score/src/pheapgetblocksize.c,
score/src/pheapgetfreeinfo.c, score/src/pheapgetinfo.c,
score/src/pheapinit.c, score/src/pheapresizeblock.c,
score/src/pheapwalk.c: New files.
PR 746/rtems
Optimize realloc(). The problem is that realloc() can neither grow
nor shrink efficiently the current memory region without support
from underlying heap/region modules. The patch introduces one new
routine for each of heap and region modules, _Heap_Resize_block(),
and rtems_region_resize_segment(), respectively, and uses the
latter to optimize realloc().
The implementation of _Heap_Resize_block() lead to changing of the
heap allocation strategy: now the heap manager, when splits larger
free block into used and new free parts, makes the first part of
the block used, not the last one as it was before. Due to this new
strategy, _Heap_Resize_block() never needs to change the user
pointer.
Caveat: unlike previous heap implementation, first few bytes of
the contents of the memory allocated from the heap are now almost
never all zero. This can trigger bugs in client code that have not
been visible before this patch.
* libcsupport/src/malloc.c (realloc): try to resize segment in
place using new rtems_region_resize_segment() routine before
falling back to the malloc()/free() method.
* score/src/heap.c:
(_Heap_Initialize): change initial heap layout to reflect new
allocation strategy of using of the lower part of a previously
free block when splitting it for the purpose of allocation.
(_Heap_Block_allocate): when split, make the lower part used, and
leave the upper part free. Return type changed from Heap_Block* to
uint32_t.
* score/include/rtems/score/heap.h:
(Heap_Statistics): added 'resizes' field.
(Heap_Resize_status): new enum.
(_Heap_Resize_block): new routine.
(_Heap_Block_allocate): return type changed from Heap_Block* to
uint32_t.
* score/src/heapwalk.c: reflect new heap layout in checks.
* score/src/heapsizeofuserarea.c: more assertions added.
* score/src/heapresizeblock.c: new file.
(_Heap_Resize_block): new routine.
* score/src/heapfree.c: reverse the checks _Heap_Is_block_in() and
_Heap_Is_prev_used() on entry to be in this order.
* score/src/heapallocate.c, score/src/heapallocatealigned.c:
ignore return value of _Heap_Block_allocate().
* score/Makefile.am (HEAP_C_FILES): added src/heapresizeblock.c.
* rtems/include/rtems/rtems/region.h:
(rtems_region_resize_segment): new interface routine.
(_Region_Process_queue): new internal routine called from
rtems_region_resize_segment() and rtems_region_return_segment().
* rtems/src/regionreturnsegment.c: move queue management code into
the new internal routine _Region_Process_queue() and call it.
* rtems/src/regionresizesegment.c: new file.
(rtems_region_resize_segment): new interface routine.
* rtems/src/regionprocessqueue.c: new file.
(_Region_Process_queue): new internal routine containing queue
management code factored out from 'regionreturnsegment.c'.
* rtems/Makefile.am (REGION_C_FILES): Added
src/regionresizesegment.c, and src/regionprocessqueue.c.
* ada/rtems.adb, ada/rtems.ads: Added Region_Resize_Segment.
* libblock/include/rtems/bdbuf.h: Include <rtems/chain.h> instead of <chain.h>.
* libblock/include/rtems/ide_part_table.h: Include <rtems/chain.h> instead of <chain.h>.
* libcsupport/src/malloc.c: Include <rtems/chain.h> instead of <chain.h>.
* libcsupport/src/mount.c: Include <rtems/chain.h> instead of <chain.h>.
* libcsupport/src/unmount.c: Include <rtems/chain.h> instead of <chain.h>.
* libfs/src/imfs/imfs.h: Include <rtems/chain.h> instead of <chain.h>.
* libfs/src/imfs/imfs_directory.c: Include <rtems/chain.h> instead of <chain.h>.
* libfs/src/imfs/imfs_load_tar.c: Include <rtems/chain.h> instead of <chain.h>.
* sapi/include/confdefs.h: Include <rtems/clockdrv.h> instead of <clockdrv.h>.
* sapi/include/confdefs.h: Include <rtems/console.h> instead of <console.h>.
* libfs/src/imfs/imfs_load_tar.c: Include <rtems/imfs.h> instead of <imfs.h>.
* libmisc/shell/cmds.c: Include <rtems/imfs.h> instead of <imfs.h>.
* libmisc/fsmount/fsmount.c: Include <rtems/imfs.h> instead of <imfs.h>.
* sapi/include/confdefs.h: Include <rtems/imfs.h> instead of <imfs.h>.
* itron/src/can_wup.c: Include <rtems/itron.h> instead of <itron.h>.
* itron/src/chg_pri.c: Include <rtems/itron.h> instead of <itron.h>.
* itron/src/cre_mbf.c: Include <rtems/itron.h> instead of <itron.h>.
* itron/src/cre_mbx.c: Include <rtems/itron.h> instead of <itron.h>.
* itron/src/cre_sem.c: Include <rtems/itron.h> instead of <itron.h>.
* itron/src/cre_tsk.c: Include <rtems/itron.h> instead of <itron.h>.
* itron/src/del_mbf.c: Include <rtems/itron.h> instead of <itron.h>.
* itron/src/del_mbx.c: Include <rtems/itron.h> instead of <itron.h>.
* itron/src/del_sem.c: Include <rtems/itron.h> instead of <itron.h>.
* itron/src/del_tsk.c: Include <rtems/itron.h> instead of <itron.h>.
* itron/src/dis_dsp.c: Include <rtems/itron.h> instead of <itron.h>.
* itron/src/ena_dsp.c: Include <rtems/itron.h> instead of <itron.h>.
* itron/src/eventflags.c: Include <rtems/itron.h> instead of <itron.h>.
* itron/src/exd_tsk.c: Include <rtems/itron.h> instead of <itron.h>.
* itron/src/ext_tsk.c: Include <rtems/itron.h> instead of <itron.h>.
* itron/src/fmempool.c: Include <rtems/itron.h> instead of <itron.h>.
* itron/src/frsm_tsk.c: Include <rtems/itron.h> instead of <itron.h>.
* itron/src/get_tid.c: Include <rtems/itron.h> instead of <itron.h>.
* itron/src/itronintr.c: Include <rtems/itron.h> instead of <itron.h>.
* itron/src/itronsem.c: Include <rtems/itron.h> instead of <itron.h>.
* itron/src/itrontime.c: Include <rtems/itron.h> instead of <itron.h>.
* itron/src/mbox.c: Include <rtems/itron.h> instead of <itron.h>.
* itron/src/mboxtranslatereturncode.c: Include <rtems/itron.h> instead of <itron.h>.
* itron/src/msgbuffer.c: Include <rtems/itron.h> instead of <itron.h>.
* itron/src/msgbuffertranslatereturncode.c: Include <rtems/itron.h> instead of <itron.h>.
* itron/src/network.c: Include <rtems/itron.h> instead of <itron.h>.
* itron/src/port.c: Include <rtems/itron.h> instead of <itron.h>.
* itron/src/prcv_mbf.c: Include <rtems/itron.h> instead of <itron.h>.
* itron/src/prcv_mbx.c: Include <rtems/itron.h> instead of <itron.h>.
* itron/src/preq_sem.c: Include <rtems/itron.h> instead of <itron.h>.
* itron/src/psnd_mbf.c: Include <rtems/itron.h> instead of <itron.h>.
* itron/src/rcv_mbf.c: Include <rtems/itron.h> instead of <itron.h>.
* itron/src/rcv_mbx.c: Include <rtems/itron.h> instead of <itron.h>.
* itron/src/ref_mbf.c: Include <rtems/itron.h> instead of <itron.h>.
* itron/src/ref_mbx.c: Include <rtems/itron.h> instead of <itron.h>.
* itron/src/ref_sem.c: Include <rtems/itron.h> instead of <itron.h>.
* itron/src/ref_tsk.c: Include <rtems/itron.h> instead of <itron.h>.
* itron/src/rel_wai.c: Include <rtems/itron.h> instead of <itron.h>.
* itron/src/rot_rdq.c: Include <rtems/itron.h> instead of <itron.h>.
* itron/src/rsm_tsk.c: Include <rtems/itron.h> instead of <itron.h>.
* itron/src/sig_sem.c: Include <rtems/itron.h> instead of <itron.h>.
* itron/src/slp_tsk.c: Include <rtems/itron.h> instead of <itron.h>.
* itron/src/snd_mbf.c: Include <rtems/itron.h> instead of <itron.h>.
* itron/src/snd_mbx.c: Include <rtems/itron.h> instead of <itron.h>.
* itron/src/sta_tsk.c: Include <rtems/itron.h> instead of <itron.h>.
* itron/src/sus_tsk.c: Include <rtems/itron.h> instead of <itron.h>.
* itron/src/sysmgmt.c: Include <rtems/itron.h> instead of <itron.h>.
* itron/src/task.c: Include <rtems/itron.h> instead of <itron.h>.
* itron/src/ter_tsk.c: Include <rtems/itron.h> instead of <itron.h>.
* itron/src/trcv_mbf.c: Include <rtems/itron.h> instead of <itron.h>.
* itron/src/trcv_mbx.c: Include <rtems/itron.h> instead of <itron.h>.
* itron/src/tslp_tsk.c: Include <rtems/itron.h> instead of <itron.h>.
* itron/src/tsnd_mbf.c: Include <rtems/itron.h> instead of <itron.h>.
* itron/src/twai_sem.c: Include <rtems/itron.h> instead of <itron.h>.
* itron/src/vmempool.c: Include <rtems/itron.h> instead of <itron.h>.
* itron/src/wai_sem.c: Include <rtems/itron.h> instead of <itron.h>.
* itron/src/wup_tsk.c: Include <rtems/itron.h> instead of <itron.h>.
* sapi/include/rtems/config.h: Include <rtems/itron.h> instead of <itron.h>.
* sapi/include/confdefs.h: Include <rtems/itron.h> instead of <itron.h>.
* sapi/src/itronapi.c: Include <rtems/itron.h> instead of <itron.h>.
* sapi/include/confdefs.h: Include <rtems/rtc.h> instead of <rtc.h>.
* sapi/include/confdefs.h: Include <rtems/timerdrv.h> instead of <timerdrv.h>.
PR 523/filesystem
* src/malloc.c: Make malloc family safer for use from ISRs and
dispatching critical sections. If in a critical section while doing
a free(), then the free is deferred until the next malloc() attempt.
PR 479/rtems_misc
* src/malloc.c: Per multiple standards realloc does not free the
original memory if the allocation of the requested larger block
fails.
a BSP (c4xsim) supporting the simulator included with gdb. This port
was done by Joel Sherrill and Jennifer Averett of OAR Corporation.
Also included with this port is a space/time optimization to eliminate
FP context switch management on CPUs without hardware or software FP.
An issue with this port was that sizeof(unsigned32) = sizeof(unsigned8)
on this CPU. This required addressing alignment checks and assumptions
as well as fixing code that assumed sizeof(unsigned32) == 4.
now is an implementation of the prototypes in rtems/rtems/cache.h.
The libcpu/i386/wrapup directory is no longer needed.
The PowerPC needs this done to it.
<charles.gauthier@iit.nrc.ca>, and Darlene A. Stewart
<Darlene.Stewart@nrc.ca> to add support for a number of very
significant things:
+ BSPs for many variations on the Motorola MBX8xx board series
+ Cache Manager including initial support for m68040
and PowerPC
+ Rework of mpc8xx libcpu code so all mpc8xx CPUs now use
same code base.
+ Rework of eth_comm BSP to utiltize above.
John reports this works on the 821 and 860
Joel Sherrill
Sebastian Huber
Chris Johns
Alex Ivanov
Joel Sherrill
Ralf Corsepius
Eric Norum