Mirrors_Framework/rt-thread
1
0
Fork 0
mirror of https://github.com/RT-Thread/rt-thread.git synced 2026-03-23 13:13:21 +08:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

[libc][libdl] Improve documentation and comments for dlmodule_extract_name

Browse Source 
Clarify the behavior of edge cases in documentation:
- Added more examples to the function documentation
- Fixed misleading comment about dot handling
- Clarified the defensive check purpose

Co-authored-by: BernardXiong <1241087+BernardXiong@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2026-03-19 02:37:31 +00:00
parent 79d62050aa
commit 7683f3d748
1 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
components/libc/posix/libdl/dlmodule.c
View File

@@ -41,8 +41,11 @@ static struct rt_module_symtab *_rt_module_symtab_end = RT_NULL;
* @param name_size size of the name buffer * @param name_size size of the name buffer
* *
* @note This function extracts the base name without path and extension. * @note This function extracts the base name without path and extension.
* For example: "/mnt/sdcard/apps/clock.so" -> "clock" * Examples:
* For hidden files like ".hidden", the entire filename is used. * - "/mnt/sdcard/apps/clock.so" -> "clock"
* - "/mnt/v1.2/app.so" -> "app" (dots in path are ignored)
* - ".hidden" -> ".hidden" (hidden files without extension)
* - ".hidden.so" -> ".hidden" (hidden files with extension)
*/ */
void dlmodule_extract_name(const char *path, char *name, int name_size) void dlmodule_extract_name(const char *path, char *name, int name_size)
{ {
@@ -77,15 +80,16 @@ void dlmodule_extract_name(const char *path, char *name, int name_size)
/* determine end position for module name */ /* determine end position for module name */
if (last_dot != RT_NULL && last_dot != first) if (last_dot != RT_NULL && last_dot != first)
{ {
/* extension found and filename doesn't start with dot */ /* extension found (dot not at start of filename), strip it */
end = last_dot; end = last_dot;
} }
/* else: no extension or filename starts with dot, use entire filename */ /* else: no extension, or filename starts with dot only (e.g., ".hidden"),
* use entire filename */
size = end - first; size = end - first;
if (size <= 0) if (size <= 0)
{ {
/* edge case: empty filename or only dot(s) */ /* defensive: empty path or path ending with "/" */
size = rt_strlen(first); size = rt_strlen(first);
} }
if (size >= name_size) if (size >= name_size)