mirror of
https://github.com/apache/nuttx.git
synced 2026-05-10 15:30:25 +08:00
Michal Lenc
977f9ed4b8
The original condition incorrectly used &h->chunk instead of h->chunk in the calculation whether the object is in the chunk. This could lead to the wrong behavior as the first branch gave incorrect result and thus sometimes the entire obstack was freed even though object was not NULL. The commit also simplifies the logic, we can use pointer arithmetic here and just do h->chunk + 1 as it gives the same result as (FAR char *)h->chunk + sizeof(struct _obstack_chunk). This saves unnecessary cast and sizeof. The second branch should be less than or equal, not just less than. This ensures the object is correctly located in the chunk even after previous obstack_finish was called. Signed-off-by: Michal Lenc <michallenc@seznam.cz> Co-authored-by: Karel Kočí <kkoci@elektroline.cz>