mirror of
https://github.com/apache/nuttx.git
synced 2026-02-06 21:03:15 +08:00
92bbe4f6ac
The TCB initializes the pid early, but the argvstack is not initialized at that time. This may cause invalid addresses to be obtained when nxsched_get_stackargs is called during task enumeration. Initialize the argv pointer to NULL to enable safe validity checks. Signed-off-by: hujun5 <hujun5@xiaomi.com>
112 lines
3.1 KiB
C
112 lines
3.1 KiB
C
/****************************************************************************
|
|
* sched/task/task_argvstr.c
|
|
*
|
|
* SPDX-License-Identifier: Apache-2.0
|
|
*
|
|
* Licensed to the Apache Software Foundation (ASF) under one or more
|
|
* contributor license agreements. See the NOTICE file distributed with
|
|
* this work for additional information regarding copyright ownership. The
|
|
* ASF licenses this file to you under the Apache License, Version 2.0 (the
|
|
* "License"); you may not use this file except in compliance with the
|
|
* License. You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
* License for the specific language governing permissions and limitations
|
|
* under the License.
|
|
*
|
|
****************************************************************************/
|
|
|
|
/****************************************************************************
|
|
* Included Files
|
|
****************************************************************************/
|
|
|
|
#include <nuttx/config.h>
|
|
|
|
#include <sched.h>
|
|
#include <stddef.h>
|
|
#include <stdio.h>
|
|
|
|
#include <nuttx/addrenv.h>
|
|
#include <nuttx/tls.h>
|
|
|
|
#include "sched/sched.h"
|
|
|
|
/****************************************************************************
|
|
* Public Functions
|
|
****************************************************************************/
|
|
|
|
/****************************************************************************
|
|
* Name: nxtask_argvstr
|
|
*
|
|
* Description:
|
|
* Safely read the contents of a task's argument vector, into a a safe
|
|
* buffer. Function skips the process's name.
|
|
*
|
|
* Input Parameters:
|
|
* tcb - tcb of the task.
|
|
* args - Output buffer for the argument vector.
|
|
* size - Size of the buffer.
|
|
*
|
|
* Returned Value:
|
|
* The actual string length that was written.
|
|
*
|
|
****************************************************************************/
|
|
|
|
size_t nxtask_argvstr(FAR struct tcb_s *tcb, FAR char *args, size_t size)
|
|
{
|
|
size_t n = 0;
|
|
#ifdef CONFIG_ARCH_ADDRENV
|
|
FAR struct addrenv_s *oldenv;
|
|
#endif
|
|
|
|
/* Sanity checks and idle tasks */
|
|
|
|
if (!tcb || size < 1 || is_idle_task(tcb))
|
|
{
|
|
*args = '\0';
|
|
return 0;
|
|
}
|
|
|
|
#ifdef CONFIG_ARCH_ADDRENV
|
|
if (tcb->addrenv_own != NULL)
|
|
{
|
|
addrenv_select(tcb->addrenv_own, &oldenv);
|
|
}
|
|
#endif
|
|
|
|
#ifndef CONFIG_DISABLE_PTHREAD
|
|
if ((tcb->flags & TCB_FLAG_TTYPE_MASK) == TCB_FLAG_TTYPE_PTHREAD)
|
|
{
|
|
FAR struct pthread_entry_s *entry =
|
|
(FAR struct pthread_entry_s *)(tcb + 1);
|
|
|
|
n += snprintf(args, size, " %p %p", tcb->entry.main, entry->arg);
|
|
}
|
|
else
|
|
#endif
|
|
{
|
|
FAR char **argv = nxsched_get_stackargs(tcb);
|
|
|
|
if (argv++)
|
|
{
|
|
while (*argv != NULL && n < size)
|
|
{
|
|
n += snprintf(args + n, size - n, " %s", *argv++);
|
|
}
|
|
}
|
|
}
|
|
|
|
#ifdef CONFIG_ARCH_ADDRENV
|
|
if (tcb->addrenv_own != NULL)
|
|
{
|
|
addrenv_restore(oldenv);
|
|
}
|
|
#endif
|
|
|
|
return n < size - 1 ? n : size - 1;
|
|
}
|