Basic 8052 context switching is working

git-svn-id: svn://svn.code.sf.net/p/nuttx/code/trunk@39 42af7a65-404d-4744-a932-0658087f49c3

arch/pjrc-8051/sdcc-2.6.0.patch

@@ -0,0 +1,11 @@
+--- sdcc/device/lib/Makefile.orig	2007-03-06 09:55:01.000000000 -0600
++++ sdcc/device/lib/Makefile	2007-03-06 09:58:32.000000000 -0600
+@@ -242,7 +242,7 @@
+ model-mcs51-stack-auto:
+ 	if [ "`grep mcs51 $(top_builddir)ports.build`" = mcs51 ]; then \
+ 	  for model in $(MODELS); do \
+-	    $(MAKE) MODELFLAGS="--model-$$model --stack-auto" PORT=$$model PORTDIR=$(BUILDDIR)/$$model-stack-auto PORTINCDIR=$(INCDIR)/mcs51 objects; \
++	    $(MAKE) MODELFLAGS="--model-$$model --stack-auto --int-long-reent --float-reent" PORT=$$model PORTDIR=$(BUILDDIR)/$$model-stack-auto PORTINCDIR=$(INCDIR)/mcs51 objects; \
+ 	  done \
+ 	fi
+ 

arch/pjrc-8051/src/Makefile

@@ -48,12 +48,12 @@ CSRCS		= up_initialize.c up_idle.c up_interruptcontext.c \
 		  up_releasepending.c up_reprioritizertr.c \
 		  up_exit.c up_assert.c up_allocateheap.c \
 		  up_irq.c up_savecontext.c up_restorecontext.c \
-		  up_timerisr.c up_putc.c
+		  up_timerisr.c up_putc.c up_debug.c
 COBJS		= $(CSRCS:.c=$(OBJEXT))
 SRCS		= $(SSRCS) $(CSRCS)
 OBJS		= $(AOBJS) $(COBJS)
 
-SDCCLIBDIR	= /usr/local/share/sdcc/lib/large
+SDCCLIBDIR	= /usr/local/share/sdcc/lib/large-stack-auto
 SDCCPATH	= -L$(SDCCLIBDIR)
 SDCCLIBS	= -llibfloat.lib -llibint.lib -lliblong.lib -llibmysdcc.lib -lmcs51.lib
 
@@ -66,7 +66,7 @@ LDLIBS		= $(addprefix -l,$(notdir $(LINKLIBS)))
 
 LDFLAGS		= --model-large --nostdlib \
 		  --data-loc 0x30 --iram-size 0x100 \
-		  --code-loc 0x20c0 --code-size 0x5f40 \
+		  --code-loc 0x2100 --code-size 0x5f40 \
 		  --xram-loc 0x0100 --xram-size 0x1f00
 
 DEPSRCS		= $(SRCS) $(LINKSSRCS)

arch/pjrc-8051/src/up_assert.c

@@ -42,6 +42,9 @@
 #include <stdlib.h>
 #include <assert.h>
 #include <debug.h>
+#include <8052.h>
+#include "up_internal.h"
+#include "up_mem.h"
 
 /************************************************************
  * Definitions
@@ -56,7 +59,7 @@
  ************************************************************/
 
 /************************************************************
- * Public Funtions
+ * Public Functions
  ************************************************************/
 
 /************************************************************
@@ -66,6 +69,7 @@
 void up_assert(void)
 {
   dbg("Assertion failed\n");
+  up_dumpstack();
   exit(EXIT_FAILURE);
 }
 
@@ -76,5 +80,6 @@ void up_assert(void)
 void up_assert_code(int errorcode)
 {
   dbg("Assertion failed with error code: %d\n", errorcode);
+  up_dumpstack();
   exit(errorcode);
 }

arch/pjrc-8051/src/up_blocktask.c

@@ -131,7 +131,7 @@ void up_block_task(FAR _TCB *tcb, tstate_t task_state)
                * Just copy the current registers into the OLD rtcb.
                */
 
-               up_savestack(&tcb->xcp);
+               up_savestack(&tcb->xcp, g_irqtos);
 
               /* Restore the exception context of the rtcb at the (new) head 
                * of the g_readytorun task list.
@@ -140,9 +140,11 @@ void up_block_task(FAR _TCB *tcb, tstate_t task_state)
               rtcb = (FAR _TCB*)g_readytorun.head;
               dbg("New Active Task TCB=%p\n", rtcb);
 
-              /* Then switch contexts */
+              /* Then setup so that the context will be performed on exit
+               * from the interrupt.
+               */
 
-              up_restorestack(&tcb->xcp);
+              g_irqcontext = &rtcb->xcp;
             }
 
           /* Copy the user C context into the TCB at the (old) head of the

arch/pjrc-8051/src/up_debug.c

@@ -0,0 +1,162 @@
+/************************************************************
+ * up_assert.c
+ *
+ *   Copyright (C) 2007 Gregory Nutt. All rights reserved.
+ *   Author: Gregory Nutt <spudmonkey@racsa.co.cr>
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright
+ *    notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *    notice, this list of conditions and the following disclaimer in
+ *    the documentation and/or other materials provided with the
+ *    distribution.
+ * 3. Neither the name Gregory Nutt nor the names of its contributors may be
+ *    used to endorse or promote products derived from this software
+ *    without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
+ * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
+ * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
+ * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
+ * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS
+ * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
+ * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
+ * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
+ * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+ * POSSIBILITY OF SUCH DAMAGE.
+ *
+ ************************************************************/
+
+/************************************************************
+ * Included Files
+ ************************************************************/
+
+#include <nuttx/config.h>
+#include <sys/types.h>
+#include <debug.h>
+#include <8052.h>
+#include <nuttx/arch.h>
+#include <arch/irq.h>
+#include "up_internal.h"
+#include "up_mem.h"
+
+/************************************************************
+ * Definitions
+ ************************************************************/
+
+/************************************************************
+ * Private Data
+ ************************************************************/
+
+/************************************************************
+ * Private Functions
+ ************************************************************/
+
+#ifdef CONFIG_FRAME_DUMP
+static void _up_puthex(ubyte hex) __naked
+{
+  hex; /* To avoid unreferenced argument warning */
+  _asm
+        mov     a, dpl
+        ljmp    PM2_ENTRY_PHEX
+  _endasm;
+}
+
+static void _up_putspace(void) __naked
+{
+  _asm
+        mov     a, #0x20
+        ljmp    PM2_ENTRY_COUT
+  _endasm;
+}
+
+static void _up_putcolon(void) __naked
+{
+  _asm
+        mov     a, #0x3a
+        lcall	PM2_ENTRY_COUT
+  _endasm;
+}
+
+static void _up_putnl(void) __naked
+{
+  _asm
+	ljmp	PM2_ENTRY_NEWLINE
+  _endasm;
+}
+
+static void _up_puts(__code char *ptr)
+{
+  for (; *ptr; ptr++)
+    {
+       up_putc(*ptr);
+    }
+}
+
+static void _up_dump16(__code char *ptr, ubyte msb, ubyte lsb)
+{
+  _up_puts(ptr);
+  _up_puthex(msb);
+  _up_puthex(lsb);
+  _up_putnl();
+}
+
+static void _up_dump8(__code char *ptr, ubyte b)
+{
+  _up_puts(ptr);
+  _up_puthex(b);
+  _up_putnl();
+}
+#endif
+
+/************************************************************
+ * Public Functions
+ ************************************************************/
+
+/************************************************************
+ * Name: up_dumpstack
+ ************************************************************/
+
+#ifdef CONFIG_FRAME_DUMP
+void up_dumpstack(void)
+{
+  NEAR ubyte *start = (NEAR ubyte *)(UP_STACK_BASE & 0xf0);
+  NEAR ubyte *end   = (NEAR ubyte *)SP;
+  ubyte i;
+
+  while (start < end)
+    {
+      _up_puthex((ubyte)start);
+      _up_putcolon();
+
+      for (i = 0; i < 8; i++)
+        {
+          _up_putspace();
+          _up_puthex(*start);
+          start++;
+        }
+      _up_putnl();
+    }
+}
+#endif
+
+/************************************************************
+ * Name: up_dumpframe
+ ************************************************************/
+
+#ifdef CONFIG_FRAME_DUMP
+void up_dumpframe(FAR struct xcptcontext *context)
+{
+  FAR ubyte *start = &context->stack[context->nbytes - FRAME_SIZE];
+  _up_dump16(" RET  ", start[FRAME_RETMS], start[FRAME_RETLS]);
+  _up_dump8(" IE   ", start[FRAME_IE]);
+  _up_dump16(" DPTR ", start[FRAME_DPH], start[FRAME_DPL]);
+  _up_dump8(" PSW  ", start[FRAME_PSW]);
+}
+#endif

arch/pjrc-8051/src/up_head.S

@@ -55,6 +55,7 @@
  ************************************************************/
 
 	.globl	_g_irqtos
+	.globl	_g_irqcontext
 
 /************************************************************
  * Public Functions
@@ -167,18 +168,36 @@ _up_interrupt:
 	clr	psw
 	push	_bp
 
-	/* Mark that we are in an interrupt */
+	/* Save the IRQ number in r3 */
+
+	mov	r2, a
+
+	/* Mark that we are in an interrupt and provide the top
+	 * of stack pointer to the context switching logic.
+	 */
 
 	mov	dptr, #_g_irqtos
+	mov	a, sp
         movx    @dptr, a
 
+	/* Nullify the context pointer.  If a context switch is
+	 * needed, this will be set to the address of the context
+	 * structure.
+	 */
+
+	mov	dptr,#_g_irqcontext
+	clr	a
+	movx	@dptr,a
+	inc	dptr
+	movx	@dptr,a
+
 	/* Now call void irq_dispatch(int irq, FAR void *context)
          *
 	 * First, create the first argument as (int)irqno
 	 */
 
-        mov     dpl, a
+        mov     dpl, r2
-	clr	dph
+	mov	dph, #0
 
         /* Create the second argument (void *context) on the stack */
 
@@ -186,30 +205,120 @@ _up_interrupt:
 	clr	a
 	push	acc
 
-	/* Then dispatch the IRQ.  On return, the stack is off by
+	/* Then dispatch the IRQ. */
-	 * by two because the above two pushes, but we fix that by
-	 * reloading sp from g_irqtos below.
-	 */
 
 	lcall	_irq_dispatch
-
+	pop	acc
-	/* Get the stackpointer.  This might be the stack pointer that
+	pop	acc
-	 * we increment above or it might be the stack pointer of a
-	 * new task if the a context switch happened during the
-	 * interrupt handling.
-	 */
-
-	mov	dptr, #_g_irqtos
-	movx	a, @dptr
-	mov	sp, a
 
 	/* Indicate that we are no longer in an interrupt */
 
+	mov	dptr, #_g_irqtos
+	clr	a
+        movx    @dptr, a
+
+	/* Check if a context switch is pending */
+
+	mov	dptr,#_g_irqcontext
+	movx	a, @dptr
+	mov     r2, a
+	inc	dptr
+	movx	a, @dptr
+	mov	r3, a
+
+        orl     a, r2
+        jz      00003$
+
+	/* A conext switch is pending Clear g_irqcontext */
+
+	mov	dpl, r2
+	mov	dph, r3
 	clr	a
 	movx	@dptr, a
+	inc	dptr
+	movx	@dptr, a
 
-	/* Then return from the interrupt */
+#ifdef CONFIG_INTERRUPT_FRAME_DUMP
+	mov	dpl, r2
+	mov	dph, r3
+	push	ar2
+	push	ar3
+	lcall	_up_dumpframe
+	pop	ar3
+	pop	ar2
+#endif
 
+	/* Register usage in the following:
+	 *
+	 * R0   - Holds working the 8-bit IRAM pointer
+	 * R1   - Not used
+	 * R2-3 - Holds the working 16-bit XRAM pointer
+	 * R4   - Holds the working byte count
+	 * R5   - Holds the new stack pointer
+	 * R6-7 - Not used
+	 */
+
+	/* Fetch r4 = context->nbytes */
+
+	mov	dpl, r2
+	mov	dph, r3
+	movx	a, @dptr
+	mov	r4, a
+
+	/* Save the new stack pointer in r5 */
+
+	add	a, #(STACK_BASE-1)
+	mov	r5, a
+
+	/* Save r2-3 = &context->stack */
+
+	inc	dptr
+	mov	r2, dpl
+	mov	r3, dph
+
+	/* Set r0 = stack base address */
+
+	mov	r0, #STACK_BASE
+
+	/* Top of the copy loop */
+00001$:
+	dec	r4
+	jz	00002$
+
+	/* Fetch the next byte from context->stack */
+
+	mov	dpl, r2
+	mov	dph, r3
+	movx	a,@dptr
+
+	/* Increment the XRAM pointer */
+
+	inc	dptr
+	mov	r2, dpl
+	mov	r3, dph
+
+	/* Save the next byte into IRAM */
+
+	mov	@r0, a
+
+	/* Increment the IRAM pointer */
+
+	inc	r0
+	sjmp	00001$
+
+	/* Set the new stack pointer */
+
+00002$:
+	mov	sp, r5
+
+#ifdef CONFIG_INTERRUPT_FRAME_DUMP
+	lcall	_up_dumpstack
+#endif
+	/* Then restore the context from the stack and return
+	 * from the interrupt
+	 */
+
+00003$:
 	pop	_bp 
 	pop	psw
 	pop	ar1 
@@ -223,18 +332,6 @@ _up_interrupt:
 	pop	b
 	pop	dph
 	pop	dpl
-
+	pop	ie
-	/* Restore the interrupt state per the stored IE value */
-
 	pop	acc
-	jb	acc.7, 00001$
-	clr	ie.7
-	sjmp	00002$
-  00001$:
-	setb	ie.7
-  00002$:
-
-	/* Finally pop off the ACC, which was the first register saved. */
-
-	pop acc
 	reti

arch/pjrc-8051/src/up_initialize.c

@@ -51,14 +51,24 @@
  * Private Data
  ************************************************************/
 
-/* This is the top of the stack containing the interrupt stack frame.  It
+/* This is the top of the stack containing the interrupt
- * is set when processing an interrupt.  It is also cleared when the
+ * stack frame.  It is set when processing an interrupt.  It
- * interrupt returns so this can also be used like a boolean indication that
+ * is also cleared when the interrupt returns so this can
- * we are in an interrupt.
+ * also be used like a boolean indication that we are in an
+ * interrupt.
  */
 
 ubyte g_irqtos;
 
+/* If during execution of an interrup handler, a context
+ * switch must be performed, the follwing will be set to
+ * to that address of the relevant context structure.  The
+ * actual switch will be deferred until the time that the
+ * the interrupt exits.
+ */
+
+FAR struct xcptcontext *g_irqcontext;
+
 /************************************************************
  * Private Functions
  ************************************************************/
@@ -105,7 +115,9 @@ void up_initialize(void)
 
   /* Initialize the system timer interrupt */
 
+#ifndef CONFIG_SUPPRESS_INTERRUPTS
   up_timerinit();
+#endif
 
   /* Initialize the serial console support */
 }

arch/pjrc-8051/src/up_internal.h

@@ -44,6 +44,13 @@
  * Public Definitions
  **************************************************************************/
 
+/* Bring-up debug configurations */
+
+#define CONFIG_FRAME_DUMP 1             /* Enabled stack/frame dumping logic */
+#define CONFIG_SUPPRESS_INTERRUPTS 1    /* Do not enable interrupts */
+#define CONFIG_SWITCH_FRAME_DUMP 1      /* Dump frames from normal switches */
+#undef  CONFIG_INTERRUPT_FRAME_DUMP     /* Dump frames from interrupt switches */
+
 /* Memory Map
  *
  * BEGIN  END     DESCRIPTION
@@ -161,14 +168,24 @@ sfr at 0xc9 T2MOD ;
 
 #ifndef __ASSEMBLY__
 
-/* This is the top of the stack containing the interrupt stack frame.  It
+/* This is the top of the stack containing the interrupt
- * is set when processing an interrupt.  It is also cleared when the
+ * stack frame.  It is set when processing an interrupt.  It
- * interrupt returns so this can also be used like a boolean indication that
+ * is also cleared when the interrupt returns so this can
- * we are in an interrupt.
+ * also be used like a boolean indication that we are in an
+ * interrupt.
  */
 
 extern ubyte g_irqtos;
 
+/* If during execution of an interrup handler, a context
+ * switch must be performed, the follwing will be set to
+ * to that address of the relevant context structure.  The
+ * actual switch will be deferred until the time that the
+ * the interrupt exits.
+ */
+
+extern FAR struct xcptcontext *g_irqcontext;
+
 #endif /* __ASSEMBLY */
 
 /**************************************************************************
@@ -181,11 +198,18 @@ extern ubyte g_irqtos;
 extern void  up_addregion(void);
 #endif
 extern void  up_irqinitialize(void);
-extern void  up_restorecontext(FAR struct xcptcontext *context);
+extern void  up_restorecontext(FAR struct xcptcontext *context) _naked;
-extern void  up_restorestack(FAR struct xcptcontext *context);
+extern ubyte up_savecontext(FAR struct xcptcontext *context) __naked;
-extern ubyte up_savecontext(FAR struct xcptcontext *context);
+extern void  up_savestack(FAR struct xcptcontext *context, ubyte tos);
-extern void  up_savestack(FAR struct xcptcontext *context);
 extern void  up_timerinit(void);
 
+#ifdef CONFIG_FRAME_DUMP
+extern void up_dumpstack(void);
+extern void up_dumpframe(FAR struct xcptcontext *context);
+#else
+# define up_dumpstack()
+# define up_dumpframe(x)
+#endif
+
 #endif /* __ASSEMBLY */
 #endif /* __ARCH_UP_INTERNAL_H */

arch/pjrc-8051/src/up_irq.c

@@ -69,7 +69,9 @@
 
 void up_irqinitialize(void)
 {
-#if 1 /* remove me */
+#ifndef CONFIG_SUPPRESS_INTERRUPTS
+  /* Disable all interrupts */
+
   IE = 0;
 #else
   /* Enable interrupts globally, but disable all interrupt

arch/pjrc-8051/src/up_releasepending.c

@@ -94,7 +94,7 @@ void up_release_pending(void)
            * Just copy the current registers into the OLD rtcb.
            */
 
-           up_savestack(&rtcb->xcp);
+           up_savestack(&rtcb->xcp, g_irqtos);
 
           /* Restore the exception context of the rtcb at the (new) head 
            * of the g_readytorun task list.
@@ -103,9 +103,11 @@ void up_release_pending(void)
           rtcb = (FAR _TCB*)g_readytorun.head;
           dbg("New Active Task TCB=%p\n", rtcb);
 
-          /* Then switch contexts */
+          /* Then setup so that the context will be performed on exit
+           * from the interrupt.
+           */
 
-          up_restorestack(&rtcb->xcp);
+          g_irqcontext = &rtcb->xcp;
         }
 
       /* Copy the exception context into the TCB of the task that

arch/pjrc-8051/src/up_reprioritizertr.c

@@ -142,7 +142,7 @@ void up_reprioritize_rtr(FAR _TCB *tcb, ubyte priority)
                * Just copy the current registers into the OLD rtcb.
                */
 
-               up_savestack(&tcb->xcp);
+               up_savestack(&tcb->xcp, g_irqtos);
 
               /* Restore the exception context of the rtcb at the (new) head 
                * of the g_readytorun task list.
@@ -151,9 +151,11 @@ void up_reprioritize_rtr(FAR _TCB *tcb, ubyte priority)
               rtcb = (FAR _TCB*)g_readytorun.head;
               dbg("New Active Task TCB=%p\n", rtcb);
 
-              /* Then switch contexts */
+              /* Then setup so that the context will be performed on exit
+               * from the interrupt.
+               */
 
-              up_restorestack(&tcb->xcp);
+              g_irqcontext = &tcb->xcp;
             }
 
           /* Copy the exception context into the TCB at the (old) head of the

arch/pjrc-8051/src/up_restorecontext.c

@@ -64,55 +64,6 @@
  * Private Functions
  **************************************************************************/
 
-/**************************************************************************
- * Name: up_popcontext
- *
- * Description:
- *   Pop the current execution context from the stack and return to the
- *   execution context.  Similar operations are executed from the interrupt
- *   state restore
- *
- * Inputs:
- *   None
- *
- * Return:
- *   This function does not return
- *
- **************************************************************************/
-
-static void up_popcontext(ubyte newsp) __naked
-
-{
-  _asm 
-	pop	_bp 
-	pop	psw
-	pop	ar1 
-	pop	ar0 
-	pop	ar7 
-	pop	ar6 
-	pop	ar5 
-	pop	ar4 
-	pop	ar3 
-	pop	ar2 
-	pop	b 
-	pop	dph
-	pop	dpl 
-
-	/* Restore the interrupt state per the stored IE value */
-
-	pop	acc
-	jb	acc.7,00001$
-	clr	ie.7
-	sjmp	00002$
-  00001$:
-	setb	ie.7
-  00002$:
-
-	pop acc
-	ret
-  _endasm;
-}
-
 /**************************************************************************
  * Public Functions
  **************************************************************************/
@@ -132,67 +83,125 @@ static void up_popcontext(ubyte newsp) __naked
  *
  **************************************************************************/
 
-void up_restorecontext(FAR struct xcptcontext *context)
+void up_restorecontext(FAR struct xcptcontext *context) __naked
 {
-  int nbytes       = context->nbytes;
+  _asm
-  FAR  ubyte *src  = context->stack;
+	ar2 = 0x02
-  NEAR ubyte *dest = (NEAR ubyte*)STACK_BASE;
+	ar3 = 0x03
+	ar4 = 0x04
+	ar5 = 0x05
+	ar6 = 0x06
+	ar7 = 0x07
+	ar0 = 0x00
+	ar1 = 0x01
 
-  /* Interrupts should be disabled for the following.  up_popcontext() will
+#ifdef CONFIG_SWITCH_FRAME_DUMP
-   * set the new interrupt state correctly.
+	push	dpl
-   */
+	push	dph
+	lcall	_up_dumpframe
+	pop	dph
+	pop	dpl
+#endif
 
-  (void)irqsave();
+	/* Interrupts should be disabled for the following.  up_popcontext() will
+	 * set the new interrupt state correctly.
+	 */
 
-  while (nbytes--)
+	clr	ea
-    {
-      *src++ = *dest++;
-    }
 
-  /* Then return to the restored context (probably restoring interrupts) */
+	/* Register usage in the following:
+	 *
+	 * R0   - Holds working the 8-bit IRAM pointer
+	 * R1   - Not used
+	 * R2-3 - Holds the working 16-bit XRAM pointer
+	 * R4   - Holds the working byte count
+	 * R5   - Holds the new stack pointer
+	 * R6-7 - Not used
+	 */
 
-  up_popcontext(context->nbytes + (STACK_BASE-1));
+	/* Fetch r4 = context->nbytes */
-}
 
-/**************************************************************************
+	movx	a, @dptr
- * Name: up_restorestack
+	mov	r4, a
- *
- * Description:
- *   Restore the entire interrupt stack contents in the provided context
- *   structure.
- *
- * Inputs:
- *   context - the context structure from  which to restore the stack info
- *
- * Return:
- *   None
- *
- * Assumptions:
- *   - We are in an interrupt handler with g_irqtos set
- *   - Interrupts are disabled
- *
- **************************************************************************/
 
-void up_restorestack(FAR struct xcptcontext *context)
+	/* Save the new stack pointer in r5 */
-{
-  /* Now copy the current stack frame (including the saved execution
-   * context) from internal RAM to XRAM.
-   */
 
-  ubyte nbytes      = context->nbytes;
+	add	a, #(STACK_BASE-1)
-  FAR  ubyte *src   = context->stack;
+	mov	r5, a
-  NEAR ubyte *dest  = (NEAR ubyte*)STACK_BASE;
 
-  while (nbytes--)
+	/* Save r2-3 = &context->stack */
-    {
-      *dest++ = *src++;
-    }
 
-  /* We are still in the interrupt context, but the size of the interrupt
+	inc	dptr
-   * stack has changed.
+	mov	r2, dpl
-   */
+	mov	r3, dph
 
-  g_irqtos = context->nbytes + (STACK_BASE-1);
+	/* Set r0 = stack base address */
+
+	mov	r0, #STACK_BASE
+
+	/* Top of the copy loop */
+00001$:
+	dec	r4
+	jz	00002$
+
+	/* Fetch the next byte from context->stack */
+
+	mov	dpl, r2
+	mov	dph, r3
+	movx	a,@dptr
+
+	/* Increment the XRAM pointer */
+
+	inc	dptr
+	mov	r2, dpl
+	mov	r3, dph
+
+	/* Save the next byte into IRAM */
+
+	mov	@r0, a
+
+	/* Increment the IRAM pointer */
+
+	inc	r0
+	sjmp	00001$
+00002$:
+
+	/* Set the new stack pointer */
+
+	mov	sp, r5
+
+#ifdef CONFIG_SWITCH_FRAME_DUMP
+	lcall	_up_dumpstack
+#endif
+	/* Then restore the context from the stack */
+
+	pop	_bp 
+	pop	psw
+	pop	ar1 
+	pop	ar0 
+	pop	ar7 
+	pop	ar6 
+	pop	ar5 
+	pop	ar4 
+	pop	ar3 
+	pop	ar2 
+	pop	b 
+	pop	dph
+	pop	dpl 
+
+	/* Restore the interrupt state per the stored IE value */
+
+	pop	acc
+	jb	acc.7,00003$
+	clr	ie.7
+	sjmp	00004$
+  00003$:
+	setb	ie.7
+  00004$:
+
+	pop acc
+	ret
+  _endasm;
 }
 
 

arch/pjrc-8051/src/up_savecontext.c

@@ -65,53 +65,6 @@
  * Private Functions
  **************************************************************************/
 
-/**************************************************************************
- * Name: up_pushcontext
- *
- * Description:
- *   Push the current execution context onto the before the stack.  Similar
- *   operations are executed from the interrupt state save.
- *
- * Inputs:
- *   None
- *
- * Return:
- *   Returns the stack pointer (always non-zero).  However, when
- *   up_popcontext() executes, it will appear as a return from this
- *   function with return value == 0
- *
- **************************************************************************/
-
-static ubyte up_pushcontext(void) __naked
-{
-  /* Push the current execution context onto the stack. */
-
-  _asm
-	push	acc
-	push	ie
-	mov	dptr, #0 /* Save return value (dpl) = 0 */
-	push	dpl
-	push	dph
-	push	b
-	push	ar2
-	push	ar3
-	push	ar4
-	push	ar5
-	push	ar6
-	push	ar7
-	push	ar0
-	push	ar1
-	push	psw
-	clr	psw
-	push	_bp
-
-	/* And return the current stack pointer value in dpl */
-
-	mov	dpl, sp
-	ret
-  _endasm;
-}
-
 /**************************************************************************
  * Public Functions
  **************************************************************************/
@@ -132,38 +85,61 @@ static ubyte up_pushcontext(void) __naked
  *
  **************************************************************************/
 
-ubyte up_savecontext(FAR struct xcptcontext *context)
+ubyte up_savecontext(FAR struct xcptcontext *context) _naked
 {
-  irqstate_t flags = irqsave();
+ _asm
-  ubyte sp = up_pushcontext();
+	/* Create the stack frame that we want when it is time to restore
-  if (sp)
+	 * this* context.  The return address will be the return address
-    {
+	 * of this function, the return value will be zero.
-      /* Now copy the current stack frame (including the saved execution
+	 */
-       * context) from internal RAM to XRAM.
-       */
 
-      ubyte nbytes     = sp - (STACK_BASE-1);
+	clr	a
-      NEAR ubyte *src  = (NEAR ubyte*)STACK_BASE;
+	push	acc	/* ACC = 0 */
-      FAR  ubyte *dest = context->stack;
+	push	ie
+	mov	a, #1
+	push	acc	/* DPL = 1 */
+	clr	a
+	push	acc	/* DPH = 0 */
+	push	b
+	push	ar2
+	push	ar3
+	push	ar4
+	push	ar5
+	push	ar6
+	push	ar7
+	push	ar0
+	push	ar1
+	push	psw
+	clr	psw
+	push	_bp
 
-      /* Then copy the stack info into the context structure */
+	/* Disable interrupts while we create a snapshot of the stack */
 
-      context->nbytes = nbytes;
+	push	ie
-      while (nbytes--)
+	mov	ea, 0
-        {
-          *dest++ = *src++;
-        }
 
-      /* Return zero so that the return behavior is similar to setjmp */
+	/* Now copy the current stack frame (including the saved execution
+	 * context) from internal RAM to XRAM.
+	 */
 
-      irqrestore(flags);
+	push	sp
-      return 0;
+	lcall	_up_savestack
-    }
+	pop	acc
 
-  /* Return one so that the return behavior is similar to setjmp */
+	/* Restore the interrupt state */
 
-  irqrestore(flags);
+	pop	ie
-  return 1;
+
+	/* Now that we have a snapshot of the desired stack frame saved,
+	 * restore the correct stackpointer.
+	 */
+
+	mov	a, sp
+	subb	a, #15
+	mov	sp, a
+	mov	dpl,#0
+	ret
+  _endasm;
 }
 
 /**************************************************************************
@@ -180,18 +156,17 @@ ubyte up_savecontext(FAR struct xcptcontext *context)
  *   None
  *
  * Assumptions:
- *   - We are in an interrupt handler with g_irqtos set
  *   - Interrupts are disabled
  *
  **************************************************************************/
 
-void up_savestack(FAR struct xcptcontext *context)
+void up_savestack(FAR struct xcptcontext *context, ubyte tos)
 {
   /* Now copy the current stack frame (including the saved execution
    * context) from internal RAM to XRAM.
    */
 
-  ubyte nbytes     = g_irqtos - (STACK_BASE-1);
+  ubyte nbytes     = tos - (STACK_BASE-1);
   NEAR ubyte *src  = (NEAR ubyte*)STACK_BASE;
   FAR  ubyte *dest = context->stack;
 

arch/pjrc-8051/src/up_unblocktask.c

@@ -122,7 +122,7 @@ void up_unblock_task(FAR _TCB *tcb)
                * Just copy the current stack into the OLD rtcb.
                */
 
-               up_savestack(&rtcb->xcp);
+               up_savestack(&rtcb->xcp, g_irqtos);
 
               /* Restore the exception context of the rtcb at the (new) head 
                * of the g_readytorun task list.
@@ -131,9 +131,11 @@ void up_unblock_task(FAR _TCB *tcb)
               rtcb = (FAR _TCB*)g_readytorun.head;
               dbg("New Active Task TCB=%p\n", rtcb);
 
-              /* Then switch contexts */
+              /* Then setup so that the context will be performed on exit
+               * from the interrupt.
+               */
 
-              up_restorestack(&rtcb->xcp);
+              g_irqcontext = &rtcb->xcp;
             }
 
          /* We are not in an interrupt andler.  Copy the user C context