Mirrors_Framework/nuttx
1
0
Fork 0
mirror of https://github.com/apache/nuttx.git synced 2026-06-05 07:12:54 +08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Fix a few errors concerning use of section block comments in .c files: (#95)

Browse Source 
1. No .c file should include a "Public Types" section.  Only a header file can define a public type.  A .c file can only define a private type.  Several files contained private type definitions.  The section that they were defined in, however, was incorrectly named "Public Types."  Those were easilty changed to "Private Types" which is what they are.

2. No .c file should include a "Public Function Prototypes" section.  All global function prototypes should be provided via a header file and never declared with a .c file.

For No. 2, I corrected as many cases as was reasonable for the time that I had available.  But there are still a dozen or so .c files that declare "Public Function Prototypes" within a .c file.  This is bad programming style.  These declarations should all be moved to the proper header files.
This commit is contained in:
patacongo
2020-01-13 17:37:54 -06:00
committed by Abdelatif Guettouche
parent f8bcd58be2
commit f00569816f
33 changed files with 71 additions and 234 deletions
Download Patch File Download Diff File Expand all files Collapse all files
fs/nxffs/nxffs_cache.c
-16
View File
@@ -49,22 +49,6 @@
#include "nxffs.h"
/****************************************************************************
* Pre-processor Definitions
****************************************************************************/
/****************************************************************************
* Public Types
****************************************************************************/
/****************************************************************************
* Public Data
****************************************************************************/
/****************************************************************************
* Private Functions
****************************************************************************/
/****************************************************************************
* Public Functions
****************************************************************************/
fs/nxffs/nxffs_pack.c
+1 -5
View File
@@ -52,11 +52,7 @@
#include "nxffs.h"
/****************************************************************************
* Pre-processor Definitions
****************************************************************************/
/****************************************************************************
* Public Types
* Private Types
****************************************************************************/
/* This structure supports access to one inode data stream */