Mirrors_Framework/nuttx
1
0
Fork 0
mirror of https://github.com/apache/nuttx.git synced 2026-05-30 05:16:47 +08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

stm32f7:SDMMC add dcache alignment check in dma{recv|send}setup

Browse Source 
In the where CONFIG_SDIO_PREFLIGHT is not used and
   dcache write-buffed mode is used (not write-through)
   buffer alignment is required for DMA transfers because
   a) arch_invalidate_dcache could lose buffered writes data
   and b) arch_flush_dcache could corrupt adjacent memory if
   the buffer and the bufflen, are not on ARMV7M_DCACHE_LINESIZE
   boundaries.
This commit is contained in:
David Sidrane
2017-08-17 09:51:37 -10:00
parent 1e7ddfea8e
commit ef42c25140
1 changed files with 17 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
arch/arm/src/stm32f7/stm32_sdmmc.c
+17 -8
View File
@@ -2843,16 +2843,21 @@ static int stm32_dmarecvsetup(FAR struct sdio_dev_s *dev, FAR uint8_t *buffer,
DEBUGASSERT(priv != NULL && buffer != NULL && buflen > 0); DEBUGASSERT(priv != NULL && buffer != NULL && buflen > 0);
#ifdef CONFIG_SDIO_PREFLIGHT #ifdef CONFIG_SDIO_PREFLIGHT
DEBUGASSERT(stm32_dmapreflight(dev, buffer, buflen) == 0); DEBUGASSERT(stm32_dmapreflight(dev, buffer, buflen) == 0);
#endif #else
# if defined(CONFIG_ARMV7M_DCACHE) && !defined(CONFIG_ARMV7M_DCACHE_WRITETHROUGH)
#ifdef CONFIG_ARMV7M_DCACHE /* buffer alignment is required for DMA transfers with dcache in buffered
/* buffer alignment is required for DMA transfers with dcache */ * mode (not write-through) because the arch_invalidate_dcache could lose
* buffered buffered writes if the buffer alignment and sizes are not on
* ARMV7M_DCACHE_LINESIZE boundaries.
*/
if (((uintptr_t)buffer & (ARMV7M_DCACHE_LINESIZE-1)) != 0 || if (((uintptr_t)buffer & (ARMV7M_DCACHE_LINESIZE-1)) != 0 ||
(buflen & (ARMV7M_DCACHE_LINESIZE-1)) != 0) (buflen & (ARMV7M_DCACHE_LINESIZE-1)) != 0)
{ {
return -EFAULT; return -EFAULT;
} }
# endif
#endif #endif
/* Reset the DPSM configuration */ /* Reset the DPSM configuration */
@@ -2928,16 +2933,20 @@ static int stm32_dmasendsetup(FAR struct sdio_dev_s *dev,
DEBUGASSERT(priv != NULL && buffer != NULL && buflen > 0); DEBUGASSERT(priv != NULL && buffer != NULL && buflen > 0);
#ifdef CONFIG_SDIO_PREFLIGHT #ifdef CONFIG_SDIO_PREFLIGHT
DEBUGASSERT(stm32_dmapreflight(dev, buffer, buflen) == 0); DEBUGASSERT(stm32_dmapreflight(dev, buffer, buflen) == 0);
#endif #else
# if defined(CONFIG_ARMV7M_DCACHE) && !defined(CONFIG_ARMV7M_DCACHE_WRITETHROUGH)
#ifdef CONFIG_ARMV7M_DCACHE /* buffer alignment is required for DMA transfers with dcache in buffered
/* buffer alignment is required for DMA transfers with dcache */ * mode (not write-through) because the arch_flush_dcache would corrupt adjacent
* memory if the buffer alignment and sizes are not on ARMV7M_DCACHE_LINESIZE
* boundaries.
*/
if (((uintptr_t)buffer & (ARMV7M_DCACHE_LINESIZE-1)) != 0 || if (((uintptr_t)buffer & (ARMV7M_DCACHE_LINESIZE-1)) != 0 ||
(buflen & (ARMV7M_DCACHE_LINESIZE-1)) != 0) (buflen & (ARMV7M_DCACHE_LINESIZE-1)) != 0)
{ {
return -EFAULT; return -EFAULT;
} }
# endif
#endif #endif
/* Reset the DPSM configuration */ /* Reset the DPSM configuration */