arch assertions: Correct duplicated logic from commit dbf01d12b7. Checking for PID == zero is not a valid way to test for the IDLE task in all configurations! This is only true in the single CPU configuration. In multiple CPU configurations, there will be a separate IDLE task for each CPU with a different PID.

arch/arm/src/arm/up_assert.c

@@ -310,7 +310,7 @@ static void _up_assert(int errorcode)
 
   /* Are we in an interrupt handler or the idle task? */
 
-  if (CURRENT_REGS || running_task()->pid == 0)
+  if (CURRENT_REGS || running_task()->flink == NULL)
     {
       (void)up_irq_save();
       for (; ; )

arch/arm/src/armv6-m/up_assert.c

@@ -367,7 +367,7 @@ static void _up_assert(int errorcode)
 
   /* Are we in an interrupt handler or the idle task? */
 
-  if (CURRENT_REGS || running_task()->pid == 0)
+  if (CURRENT_REGS || running_task()->flink == NULL)
     {
       (void)up_irq_save();
       for (; ; )

arch/arm/src/armv7-a/arm_assert.c

@@ -395,7 +395,7 @@ static void _up_assert(int errorcode)
 
   /* Are we in an interrupt handler or the idle task? */
 
-  if (CURRENT_REGS || running_task()->pid == 0)
+  if (CURRENT_REGS || running_task()->flink == NULL)
     {
       /* Disable interrupts on this CPU */
 

arch/arm/src/armv7-m/up_assert.c

@@ -389,7 +389,7 @@ static void _up_assert(int errorcode)
 
   /* Are we in an interrupt handler or the idle task? */
 
-  if (CURRENT_REGS || (running_task())->pid == 0)
+  if (CURRENT_REGS || (running_task())->flink == NULL)
     {
       (void)up_irq_save();
       for (; ; )

arch/arm/src/armv7-r/arm_assert.c

@@ -374,7 +374,7 @@ static void _up_assert(int errorcode)
 
   /* Are we in an interrupt handler or the idle task? */
 
-  if (CURRENT_REGS || (running_task())->pid == 0)
+  if (CURRENT_REGS || (running_task())->flink == NULL)
     {
       (void)up_irq_save();
       for (; ; )

arch/avr/src/common/up_assert.c

@@ -87,7 +87,7 @@ static void _up_assert(int errorcode)
 
   /* Are we in an interrupt handler or the idle task? */
 
-  if (g_current_regs || running_task()->pid == 0)
+  if (g_current_regs || running_task()->flink == NULL)
     {
       (void)up_irq_save();
       for (; ; )

arch/hc/src/m9s12/m9s12_assert.c

@@ -294,7 +294,7 @@ static void _up_assert(int errorcode)
 
   /* Are we in an interrupt handler or the idle task? */
 
-  if (g_current_regs || (running_task())->pid == 0)
+  if (g_current_regs || (running_task())->flink == NULL)
     {
        (void)up_irq_save();
         for (;;)

arch/mips/src/mips32/up_assert.c

@@ -86,7 +86,7 @@ static void _up_assert(int errorcode)
 
   /* Are we in an interrupt handler or the idle task? */
 
-  if (g_current_regs || running_task()->pid == 0)
+  if (g_current_regs || running_task()->flink == NULL)
     {
        (void)up_irq_save();
         for (; ; )

arch/misoc/src/lm32/lm32_assert.c

@@ -87,7 +87,7 @@ static void _up_assert(int errorcode)
 
   /* Are we in an interrupt handler or the idle task? */
 
-  if (g_current_regs || running_task()->pid == 0)
+  if (g_current_regs || running_task()->flink == NULL)
     {
        (void)up_irq_save();
         for (; ; )

arch/or1k/src/common/up_assert.c

@@ -372,7 +372,7 @@ static void _up_assert(int errorcode)
 
   /* Are we in an interrupt handler or the idle task? */
 
-  if (CURRENT_REGS || running_task()->pid == 0)
+  if (CURRENT_REGS || running_task()->flink == NULL)
     {
       (void)up_irq_save();
       for (; ; )

arch/renesas/src/common/up_assert.c

@@ -88,7 +88,7 @@ static void _up_assert(int errorcode)
 
   /* Are we in an interrupt handler or the idle task? */
 
-  if (g_current_regs || running_task()->pid == 0)
+  if (g_current_regs || running_task()->flink == NULL)
     {
        (void)up_irq_save();
         for (;;)

arch/risc-v/src/rv32im/up_assert.c

@@ -87,7 +87,7 @@ static void _up_assert(int errorcode)
 
   /* Are we in an interrupt handler or the idle task? */
 
-  if (g_current_regs || running_task()->pid == 0)
+  if (g_current_regs || running_task()->flink == NULL)
     {
        (void)up_irq_save();
         for (; ; )

arch/x86/src/common/up_assert.c

@@ -255,7 +255,7 @@ static void _up_assert(int errorcode)
 
   /* Are we in an interrupt handler or the idle task? */
 
-  if (g_current_regs || (running_task())->pid == 0)
+  if (g_current_regs || (running_task())->flink == NULL)
     {
        (void)up_irq_save();
         for (;;)

arch/xtensa/src/common/xtensa_assert.c

@@ -126,7 +126,7 @@ static void xtensa_assert(int errorcode)
 
   /* Are we in an interrupt handler or the idle task? */
 
-  if (CURRENT_REGS || running_task()->pid == 0)
+  if (CURRENT_REGS || running_task()->flink == NULL)
     {
        /* Blink the LEDs forever */
 

arch/z16/src/common/up_assert.c

@@ -87,7 +87,7 @@ static void _up_assert(int errorcode) /* noreturn_function */
 
   /* Are we in an interrupt handler or the idle task? */
 
-  if (up_interrupt_context() || running_task()->pid == 0)
+  if (up_interrupt_context() || running_task()->flink == NULL)
     {
        (void)up_irq_save();
         for (;;)

arch/z80/src/common/up_assert.c

@@ -86,7 +86,7 @@ static void _up_assert(int errorcode) /* noreturn_function */
 
   /* Are we in an interrupt handler or the idle task? */
 
-  if (up_interrupt_context() || running_task()->pid == 0)
+  if (up_interrupt_context() || running_task()->flink == NULL)
     {
        (void)up_irq_save();
         for (;;)