Mirrors_Framework/nuttx
1
0
Fork 0
mirror of https://github.com/apache/nuttx.git synced 2026-06-01 16:59:28 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

virtio-mmio: use byte to byte in read/write config when length != 1,2,4,8

Browse Source 
The length of some config elements are not equal to 1,2,4,8, so we can't
assert in virtio_mmio_config_read/write() direclty when length != 1,2,4,8

For example, in virtio_net_config from virtio spec v1.2
struct virtio_net_config {
	u8 mac[6];
	le16 status;
	le16 max_virtqueue_pairs;
	le16 mtu;
	le32 speed;
	u8 duplex;
	u8 rss_max_key_size;
	le16 rss_max_indirection_table_length;
	le32 supported_hash_types;
};

The mac length is 6 and not equal to 1,2,4,8

Signed-off-by: Bowen Wang <wangbowen6@xiaomi.com>
This commit is contained in:
Bowen Wang
2023-12-14 14:17:06 +08:00
committed by Xiang Xiao
parent d0335f089f
commit e9a146bbfc
1 changed files with 22 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
drivers/virtio/virtio-mmio.c
+22 -20
View File
@@ -553,16 +553,9 @@ static void virtio_mmio_write_config(FAR struct virtio_device *vdev,
uint16_t u16data; uint16_t u16data;
uint8_t u8data; uint8_t u8data;
if (vdev->id.version == VIRTIO_MMIO_VERSION_1 || length > 8) if (vdev->id.version == VIRTIO_MMIO_VERSION_1)
{ {
FAR char *s = src; goto byte_write;
int i;
for (i = 0; i < length; i++)
{
metal_io_write8(&vmdev->cfg_io, write_offset + i, s[i]);
}
return;
} }
switch (length) switch (length)
@@ -587,7 +580,15 @@ static void virtio_mmio_write_config(FAR struct virtio_device *vdev,
u32data); u32data);
break; break;
default: default:
DEBUGASSERT(0); byte_write:
{
FAR char *s = src;
int i;
for (i = 0; i < length; i++)
{
metal_io_write8(&vmdev->cfg_io, write_offset + i, s[i]);
}
}
} }
} }
@@ -606,16 +607,9 @@ static void virtio_mmio_read_config(FAR struct virtio_device *vdev,
uint16_t u16data; uint16_t u16data;
uint8_t u8data; uint8_t u8data;
if (vdev->id.version == VIRTIO_MMIO_VERSION_1 || length > 8) if (vdev->id.version == VIRTIO_MMIO_VERSION_1)
{ {
FAR char *d = dst; goto byte_read;
int i;
for (i = 0; i < length; i++)
{
d[i] = metal_io_read8(&vmdev->cfg_io, read_offset + i);
}
return;
} }
switch (length) switch (length)
@@ -640,7 +634,15 @@ static void virtio_mmio_read_config(FAR struct virtio_device *vdev,
memcpy(dst + sizeof(u32data), &u32data, sizeof(u32data)); memcpy(dst + sizeof(u32data), &u32data, sizeof(u32data));
break; break;
default: default:
DEBUGASSERT(0); byte_read:
{
FAR char *d = dst;
int i;
for (i = 0; i < length; i++)
{
d[i] = metal_io_read8(&vmdev->cfg_io, read_offset + i);
}
}
} }
} }