From e3d0fc20354df3c60618c4e45e86eb72601d96e2 Mon Sep 17 00:00:00 2001 From: patacongo Date: Tue, 29 Sep 2009 02:08:26 +0000 Subject: [PATCH] Clean-up redundant conditional compilation git-svn-id: svn://svn.code.sf.net/p/nuttx/code/trunk@2103 42af7a65-404d-4744-a932-0658087f49c3 --- arch/arm/src/stm32/stm32_lowputc.c | 26 +++++++++--------- arch/arm/src/stm32/stm32_serial.c | 44 +++++++++++++++--------------- 2 files changed, 35 insertions(+), 35 deletions(-) diff --git a/arch/arm/src/stm32/stm32_lowputc.c b/arch/arm/src/stm32/stm32_lowputc.c index 0c364022ed4..adbb29a2723 100644 --- a/arch/arm/src/stm32/stm32_lowputc.c +++ b/arch/arm/src/stm32/stm32_lowputc.c @@ -59,15 +59,15 @@ /* Is there a serial console? */ -#if defined(CONFIG_USART1_SERIAL_CONSOLE) && !defined(CONFIG_USART1_DISABLE) +#if defined(CONFIG_USART1_SERIAL_CONSOLE) && defined(CONFIG_STM32_USART1) # undef CONFIG_USART2_SERIAL_CONSOLE # undef CONFIG_USART3_SERIAL_CONSOLE # define HAVE_CONSOLE 1 -#elif defined(CONFIG_USART2_SERIAL_CONSOLE) && !defined(CONFIG_USART2_DISABLE) +#elif defined(CONFIG_USART2_SERIAL_CONSOLE) && defined(CONFIG_STM32_USART2) # undef CONFIG_USART1_SERIAL_CONSOLE # undef CONFIG_USART3_SERIAL_CONSOLE # define HAVE_CONSOLE 1 -#elif defined(CONFIG_USART3_SERIAL_CONSOLE) && !defined(CONFIG_USART3_DISABLE) +#elif defined(CONFIG_USART3_SERIAL_CONSOLE) && defined(CONFIG_STM32_USART3) # undef CONFIG_USART1_SERIAL_CONSOLE # undef CONFIG_USART2_SERIAL_CONSOLE # define HAVE_CONSOLE 1 @@ -219,7 +219,7 @@ void up_lowputc(char ch) void stm32_lowsetup(void) { -#if !defined(CONFIG_USART1_DISABLE) || !defined(CONFIG_USART2_DISABLE) || !defined(CONFIG_USART3_DISABLE) +#if defined(CONFIG_STM32_USART1) || defined(CONFIG_STM32_USART2) || defined(CONFIG_STM32_USART3) uint32 enr; uint32 mapr; #if defined(HAVE_CONSOLE) && !defined(CONFIG_SUPPRESS_USART_CONFIG) @@ -233,7 +233,7 @@ void stm32_lowsetup(void) mapr = getreg32(STM32_AFIO_MAPR); -#ifndef CONFIG_USART1_DISABLE +#ifdef CONFIG_STM32_USART1 /* Enable USART1 clocking */ enr = getreg32(STM32_RCC_APB2ENR_OFFSET); @@ -251,12 +251,12 @@ void stm32_lowsetup(void) mapr &= ~AFIO_MAPR_USART1_REMAP; -#endif /* !CONFIG_USART1_DISABLE */ +#endif /* CONFIG_STM32_USART1 */ -#if !defined(CONFIG_USART2_DISABLE) && !defined(CONFIG_USART3_DISABLE) +#if defined(CONFIG_STM32_USART2) || defined(CONFIG_STM32_USART3) enr = getreg32(STM32_RCC_APB1ENR_OFFSET); -#ifndef CONFIG_USART2_DISABLE +#ifdef CONFIG_STM32_USART2 /* Enable USART2 clocking */ enr |= RCC_APB1ENR_USART2EN; @@ -272,9 +272,9 @@ void stm32_lowsetup(void) mapr &= ~AFIO_MAPR_USART2_REMAP; -#endif /* !CONFIG_USART2_DISABLE */ +#endif /* CONFIG_STM32_USART2 */ -#ifndef CONFIG_USART3_DISABLE +#ifdef CONFIG_STM32_USART3 /* Enable USART3 clocking */ enr |= RCC_APB1ENR_USART3EN; @@ -291,11 +291,11 @@ void stm32_lowsetup(void) mapr &= ~AFIO_MAPR_USART3_REMAP_MASK; -#endif /* !CONFIG_USART3_DISABLE */ +#endif /* CONFIG_STM32_USART3 */ /* Save the UART enable settings */ putreg32(enr, STM32_RCC_APB1ENR_OFFSET); -#endif /* !CONFIG_USART2_DISABLE && !CONFIG_USART3_DISABLE */ +#endif /* CONFIG_STM32_USART2 || CONFIG_STM32_USART3 */ /* Save the USART pin mappings */ putreg32(mapr, STM32_AFIO_MAPR); @@ -334,7 +334,7 @@ void stm32_lowsetup(void) cr |= (USART_CR1_UE|USART_CR1_TE|USART_CR1_RE); putreg16(cr, STM32_CONSOLE_BASE + STM32_USART_CR2_OFFSET); #endif -#endif /* !CONFIG_USART1_DISABLE && !CONFIG_USART2_DISABLE && !CONFIG_USART3_DISABLE */ +#endif /* CONFIG_STM32_USART1 || CONFIG_STM32_USART2 || CONFIG_STM32_USART3 */ } diff --git a/arch/arm/src/stm32/stm32_serial.c b/arch/arm/src/stm32/stm32_serial.c index 30df7411497..e56a8e7d0bd 100644 --- a/arch/arm/src/stm32/stm32_serial.c +++ b/arch/arm/src/stm32/stm32_serial.c @@ -65,21 +65,21 @@ /* Is there a USART enabled? */ -#if defined(CONFIG_USART1_DISABLE) && defined(CONFIG_USART2_DISABLE) && defined(CONFIG_USART3_DISABLE) +#if !defined(CONFIG_STM32_USART1) && !defined(CONFIG_STM32_USART2) && !defined(CONFIG_STM32_USART3) # error "No USARTs enabled" #endif /* Is there a serial console? */ -#if defined(CONFIG_USART1_SERIAL_CONSOLE) && !defined(CONFIG_USART1_DISABLE) +#if defined(CONFIG_USART1_SERIAL_CONSOLE) && defined(CONFIG_STM32_USART1) # undef CONFIG_USART2_SERIAL_CONSOLE # undef CONFIG_USART3_SERIAL_CONSOLE # define HAVE_CONSOLE 1 -#elif defined(CONFIG_USART2_SERIAL_CONSOLE) && !defined(CONFIG_USART2_DISABLE) +#elif defined(CONFIG_USART2_SERIAL_CONSOLE) && defined(CONFIG_STM32_USART2) # undef CONFIG_USART1_SERIAL_CONSOLE # undef CONFIG_USART3_SERIAL_CONSOLE # define HAVE_CONSOLE 1 -#elif defined(CONFIG_USART3_SERIAL_CONSOLE) && !defined(CONFIG_USART3_DISABLE) +#elif defined(CONFIG_USART3_SERIAL_CONSOLE) && defined(CONFIG_STM32_USART3) # undef CONFIG_USART1_SERIAL_CONSOLE # undef CONFIG_USART3_SERIAL_CONSOLE # define HAVE_CONSOLE 1 @@ -102,15 +102,15 @@ #if defined(CONFIG_USART1_SERIAL_CONSOLE) # define CONSOLE_DEV g_usart1port /* USART1 is console */ # define TTYS0_DEV g_usart1port /* USART1 is ttyS0 */ -# ifndef CONFIG_USART2_DISABLE +# ifdef CONFIG_STM32_USART2 # define TTYS1_DEV g_usart2port /* USART2 is ttyS1 */ -# ifndef CONFIG_USART3_DISABLE +# ifdef CONFIG_STM32_USART3 # define TTYS2_DEV g_usart3port /* USART3 is ttyS2 */ # else # undef TTYS1_DEV /* No ttyS2 */ # endif # else -# ifndef CONFIG_USART3_DISABLE +# ifdef CONFIG_STM32_USART3 # define TTYS1_DEV g_usart3port /* USART3 is ttyS1 */ # else # undef TTYS1_DEV /* No ttyS1 */ @@ -120,15 +120,15 @@ #elif defined(CONFIG_USART2_SERIAL_CONSOLE) # define CONSOLE_DEV g_usart2port /* USART2 is console */ # define TTYS0_DEV g_usart2port /* USART2 is ttyS0 */ -# ifndef CONFIG_USART1_DISABLE +# ifdef CONFIG_STM32_USART1 # define TTYS1_DEV g_usart1port /* USART1 is ttyS1 */ -# ifndef CONFIG_USART3_DISABLE +# ifdef CONFIG_STM32_USART3 # define TTYS2_DEV g_usart3port /* USART3 is ttyS2 */ # else # undef TTYS1_DEV /* No ttyS2 */ # endif # else -# ifndef CONFIG_USART3_DISABLE +# ifdef CONFIG_STM32_USART3 # define TTYS1_DEV g_usart3port /* USART3 is ttyS1 */ # else # undef TTYS1_DEV /* No ttyS1 */ @@ -138,15 +138,15 @@ #elif defined(CONFIG_USART3_SERIAL_CONSOLE) # define CONSOLE_DEV g_usart3port /* USART3 is console */ # define TTYS0_DEV g_usart3port /* USART3 is ttyS0 */ -# ifndef CONFIG_USART1_DISABLE +# ifdef CONFIG_STM32_USART1 # define TTYS1_DEV g_usart1port /* USART1 is ttyS1 */ -# ifndef CONFIG_USART2_DISABLE +# ifdef CONFIG_STM32_USART2 # define TTYS2_DEV g_usart2port /* USART2 is ttyS2 */ # else # undef TTYS1_DEV /* No ttyS2 */ # endif # else -# ifndef CONFIG_USART2_DISABLE +# ifdef CONFIG_STM32_USART2 # define TTYS1_DEV g_usart2port /* USART2 is ttyS1 */ # else # undef TTYS1_DEV /* No ttyS1 */ @@ -211,22 +211,22 @@ struct uart_ops_s g_uart_ops = /* I/O buffers */ -#ifndef CONFIG_USART1_DISABLE +#ifdef CONFIG_STM32_USART1 static char g_usart1rxbuffer[CONFIG_USART1_RXBUFSIZE]; static char g_usart1txbuffer[CONFIG_USART1_TXBUFSIZE]; #endif -#ifndef CONFIG_USART2_DISABLE +#ifdef CONFIG_STM32_USART2 static char g_usart2rxbuffer[CONFIG_USART2_RXBUFSIZE]; static char g_usart2txbuffer[CONFIG_USART2_TXBUFSIZE]; #endif -#ifndef CONFIG_USART3_DISABLE +#ifdef CONFIG_STM32_USART3 static char g_usart3rxbuffer[CONFIG_USART3_RXBUFSIZE]; static char g_usart3txbuffer[CONFIG_USART3_TXBUFSIZE]; #endif /* This describes the state of the STM32 USART1 ports. */ -#ifndef CONFIG_USART1_DISABLE +#ifdef CONFIG_STM32_USART1 static struct up_dev_s g_usart1priv = { .usartbase = STM32_USART1_BASE, @@ -257,7 +257,7 @@ static uart_dev_t g_usart1port = /* This describes the state of the STM32 USART2 port. */ -#ifndef CONFIG_USART2_DISABLE +#ifdef CONFIG_STM32_USART2 static struct up_dev_s g_usart2priv = { .usartbase = STM32_USART2_BASE, @@ -288,7 +288,7 @@ static uart_dev_t g_usart2port = /* This describes the state of the STM32 USART3 port. */ -#ifndef CONFIG_USART3_DISABLE +#ifdef CONFIG_STM32_USART3 static struct up_dev_s g_usart3priv = { .usartbase = STM32_USART3_BASE, @@ -627,21 +627,21 @@ static int up_interrupt(int irq, void *context) int passes; boolean handled; -#ifndef CONFIG_USART1_DISABLE +#ifdef CONFIG_STM32_USART1 if (g_usart1priv.irq == irq) { dev = &g_usart1port; } else #endif -#ifndef CONFIG_USART2_DISABLE +#ifdef CONFIG_STM32_USART2 if (g_usart2priv.irq == irq) { dev = &g_usart2port; } else #endif -#ifndef CONFIG_USART3_DISABLE +#ifdef CONFIG_STM32_USART3 if (g_usart3priv.irq == irq) { dev = &g_usart3port;