Mirrors_Framework/nuttx
1
0
Fork 0
mirror of https://github.com/apache/nuttx.git synced 2026-05-27 11:26:12 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

configs/flipnclick-sam3x: Fix an error in the control of one LED. LEDs should not be pulled up since they are active high.

Browse Source
This commit is contained in:
Gregory Nutt
2018-01-27 12:42:51 -06:00
parent 12e3e47d3c
commit c0a79a8e45
4 changed files with 13 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
configs/flipnclick-sam3x/README.txt
+2 -2
View File
@@ -71,8 +71,8 @@ Buttons and LEDs
LED_PANIC The system has crashed 2Hz N/C N/C N/C N/C LED_PANIC The system has crashed 2Hz N/C N/C N/C N/C
LED_IDLE MCU is is sleep mode ---- Not used ----- LED_IDLE MCU is is sleep mode ---- Not used -----
Thus if LED L is glowing on and all other LEDs are off (except LED D which Thus if LED L is glowing faintly and all other LEDs are off (except LED D
was left on but is no longer controlled by NuttX and so may be in any which was left on but is no longer controlled by NuttX and so may be in any
state), NuttX has successfully booted and is, apparently, running normally state), NuttX has successfully booted and is, apparently, running normally
and taking interrupts. If any of LEDs A-D are statically set, then NuttX and taking interrupts. If any of LEDs A-D are statically set, then NuttX
failed to boot and the LED indicates the initialization phase where the failed to boot and the LED indicates the initialization phase where the
configs/flipnclick-sam3x/include/board.h
+1 -1
View File
@@ -211,7 +211,7 @@
#define LED_PANIC 4 /* The system has crashed 2Hz N/C N/C N/C N/C */ #define LED_PANIC 4 /* The system has crashed 2Hz N/C N/C N/C N/C */
#undef LED_IDLE /* MCU is is sleep mode ---- Not used ----- */ #undef LED_IDLE /* MCU is is sleep mode ---- Not used ----- */
/* Thus if LED L is glowing on and all other LEDs are off (except LED D which /* Thus if LED L is faintly glowing and all other LEDs are off (except LED D which
* was left on but is no longer controlled by NuttX and so may be in any state), * was left on but is no longer controlled by NuttX and so may be in any state),
* NuttX has successfully booted and is, apparently, running normally and taking * NuttX has successfully booted and is, apparently, running normally and taking
* interrupts. If any of LEDs A-D are statically set, then NuttX failed to boot * interrupts. If any of LEDs A-D are statically set, then NuttX failed to boot
configs/flipnclick-sam3x/src/flipnclick-sam3x.h
+5 -5
View File
@@ -68,15 +68,15 @@
* A high output value illuminates the LEDs. * A high output value illuminates the LEDs.
*/ */
#define GPIO_LED_L (GPIO_OUTPUT | GPIO_CFG_PULLUP | GPIO_OUTPUT_CLEAR | \ #define GPIO_LED_L (GPIO_OUTPUT | GPIO_CFG_DEFAULT | GPIO_OUTPUT_CLEAR | \
GPIO_PORT_PIOB | GPIO_PIN27) GPIO_PORT_PIOB | GPIO_PIN27)
#define GPIO_LED_A (GPIO_OUTPUT | GPIO_CFG_PULLUP | GPIO_OUTPUT_CLEAR | \ #define GPIO_LED_A (GPIO_OUTPUT | GPIO_CFG_DEFAULT | GPIO_OUTPUT_CLEAR | \
GPIO_PORT_PIOC | GPIO_PIN6) GPIO_PORT_PIOC | GPIO_PIN6)
#define GPIO_LED_B (GPIO_OUTPUT | GPIO_CFG_PULLUP | GPIO_OUTPUT_CLEAR | \ #define GPIO_LED_B (GPIO_OUTPUT | GPIO_CFG_DEFAULT | GPIO_OUTPUT_CLEAR | \
GPIO_PORT_PIOC | GPIO_PIN5) GPIO_PORT_PIOC | GPIO_PIN5)
#define GPIO_LED_C (GPIO_OUTPUT | GPIO_CFG_PULLUP | GPIO_OUTPUT_CLEAR | \ #define GPIO_LED_C (GPIO_OUTPUT | GPIO_CFG_DEFAULT | GPIO_OUTPUT_CLEAR | \
GPIO_PORT_PIOC | GPIO_PIN7) GPIO_PORT_PIOC | GPIO_PIN7)
#define GPIO_LED_D (GPIO_OUTPUT | GPIO_CFG_PULLUP | GPIO_OUTPUT_CLEAR | \ #define GPIO_LED_D (GPIO_OUTPUT | GPIO_CFG_DEFAULT | GPIO_OUTPUT_CLEAR | \
GPIO_PORT_PIOC | GPIO_PIN8) GPIO_PORT_PIOC | GPIO_PIN8)
/* SPI chip select pins. /* SPI chip select pins.
configs/flipnclick-sam3x/src/sam_autoleds.c
+5 -5
View File
@@ -64,8 +64,8 @@
* LED_PANIC The system has crashed 2Hz N/C N/C N/C N/C * LED_PANIC The system has crashed 2Hz N/C N/C N/C N/C
* LED_IDLE MCU is is sleep mode ---- Not used ----- * LED_IDLE MCU is is sleep mode ---- Not used -----
* *
* Thus if LED L is glowing on and all other LEDs are off (except LED D * Thus if LED L is faintly glowing and all other LEDs are off (except LED
* which was left on but is no longer controlled by NuttX and so may be in * D which was left on but is no longer controlled by NuttX and so may be in
* any state), NuttX has successfully booted and is, apparently, running * any state), NuttX has successfully booted and is, apparently, running
* normally and taking interrupts. If any of LEDs A-D are statically set, * normally and taking interrupts. If any of LEDs A-D are statically set,
* then NuttX failed to boot and the LED indicates the initialization phase * then NuttX failed to boot and the LED indicates the initialization phase
@@ -99,7 +99,7 @@
#ifdef CONFIG_ARCH_LEDS #ifdef CONFIG_ARCH_LEDS
/**************************************************************************** /****************************************************************************
* Processor Definitinos * Processor Definitions
****************************************************************************/ ****************************************************************************/
/* LED indices */ /* LED indices */
@@ -123,7 +123,7 @@ static void board_autoled_setone(int ledndx)
sam_gpiowrite(GPIO_LED_L, ledon[INDEX_LED_L]); sam_gpiowrite(GPIO_LED_L, ledon[INDEX_LED_L]);
sam_gpiowrite(GPIO_LED_A, ledon[INDEX_LED_A]); sam_gpiowrite(GPIO_LED_A, ledon[INDEX_LED_A]);
sam_gpiowrite(GPIO_LED_B, ledon[INDEX_LED_B]); sam_gpiowrite(GPIO_LED_B, ledon[INDEX_LED_B]);
sam_gpiowrite(GPIO_LED_C, ledon[INDEX_LED_D]); sam_gpiowrite(GPIO_LED_C, ledon[INDEX_LED_C]);
sam_gpiowrite(GPIO_LED_D, ledon[INDEX_LED_D]); sam_gpiowrite(GPIO_LED_D, ledon[INDEX_LED_D]);
} }
@@ -176,7 +176,7 @@ void board_autoled_on(int led)
board_autoled_setone(INDEX_LED_B); board_autoled_setone(INDEX_LED_B);
break; break;
case 2: case 2:
board_autoled_setone(INDEX_LED_C); board_autoled_setone(INDEX_LED_C);
break; break;