Clean up and review of header files for conformance to standards

arch/arm/src/imx/imx_gpio.h

@@ -2,7 +2,7 @@
  * arch/arm/src/imx/imx_gpio.h
  * arch/arm/src/chip/imx_gpio.h
  *
- *   Copyright (C) 2009 Gregory Nutt. All rights reserved.
+ *   Copyright (C) 2009, 2015 Gregory Nutt. All rights reserved.
  *   Author: Gregory Nutt <gnutt@nuttx.org>
  *
  * Redistribution and use in source and binary forms, with or without
@@ -551,11 +551,11 @@ static inline void imxgpio_clroutput(int port, int bit)
 
 /* Useful functions for normal configurations */
 
-extern void imxgpio_configoutput(int port, int bit, int value);
+void imxgpio_configoutput(int port, int bit, int value);
-extern void imxgpio_configinput(int port, int bit);
+void imxgpio_configinput(int port, int bit);
 
-extern void imxgpio_configpfoutput(int port, int bit);
+void imxgpio_configpfoutput(int port, int bit);
-extern void imxgpio_configpfinput(int port, int bit);
+void imxgpio_configpfinput(int port, int bit);
 
 #endif
 

arch/arm/src/lpc2378/internal.h

@@ -1,7 +1,7 @@
 /****************************************************************************************************
  * arch/arm/src/lpc2378/chip.h
  *
- *   Copyright (C) 2010 Rommel Marcelo. All rights reserved.
+ *   Copyright (C) 2010, 2015 Rommel Marcelo. All rights reserved.
  *   Author: Rommel Marcelo
  *
  * This file is part of the NuttX RTOS and based on the lpc2148 port:
@@ -61,8 +61,8 @@
 #ifndef __ASSEMBLY__
 
 #ifdef CONFIG_ARCH_LEDS
-extern void lpc2378_statledoff(void);
+void lpc2378_statledoff(void);
-extern void lpc2378_statledon(void);
+void lpc2378_statledon(void);
 #endif
 
 #endif

arch/arm/src/str71x/str71x_internal.h

@@ -1,7 +1,7 @@
 /************************************************************************************
  * arch/arm/src/str71x/str71x_internal.h
  *
- *   Copyright (C) 2008-2009 Gregory Nutt. All rights reserved.
+ *   Copyright (C) 2008-2009, 2015 Gregory Nutt. All rights reserved.
  *   Author: Gregory Nutt <gnutt@nuttx.org>
  *
  * Redistribution and use in source and binary forms, with or without
@@ -105,7 +105,7 @@
  ********************************************************************************/
 
 #ifdef CONFIG_STR71X_XTI
-extern int str71x_xtiinitialize(void);
+int str71x_xtiinitialize(void);
 #else
 #  define str71x_xtiinitialize()
 #endif /* CONFIG_STR71X_XTI */
@@ -120,7 +120,7 @@ extern int str71x_xtiinitialize(void);
  ********************************************************************************/
 
 #ifdef CONFIG_STR71X_XTI
-extern int str71x_xticonfig(int irq, bool rising);
+int str71x_xticonfig(int irq, bool rising);
 #else
 #  define str71x_xticonfig(irq,rising)
 #endif /* CONFIG_STR71X_XTI */
@@ -134,7 +134,7 @@ extern int str71x_xticonfig(int irq, bool rising);
  ****************************************************************************/
 
 #ifdef CONFIG_STR71X_XTI
-extern void str71x_enable_xtiirq(int irq);
+void str71x_enable_xtiirq(int irq);
 #else
 #  define str71x_enable_xtiirq(irq)
 #endif /* CONFIG_STR71X_XTI */
@@ -148,7 +148,7 @@ extern void str71x_enable_xtiirq(int irq);
  ****************************************************************************/
 
 #ifdef CONFIG_STR71X_XTI
-extern void str71x_disable_xtiirq(int irq);
+void str71x_disable_xtiirq(int irq);
 #else
 #  define str71x_disable_xtiirq(irq)
 #endif /* CONFIG_STR71X_XTI */

arch/avr/src/common/up_internal.h

@@ -1,7 +1,7 @@
 /****************************************************************************
  * arch/avr/src/common/up_internal.h
  *
- *   Copyright (C) 2010-2011 Gregory Nutt. All rights reserved.
+ *   Copyright (C) 2010-2011, 2015 Gregory Nutt. All rights reserved.
  *   Author: Gregory Nutt <gnutt@nuttx.org>
  *
  * Redistribution and use in source and binary forms, with or without
@@ -182,7 +182,7 @@ void lowconsole_init(void);
 
 /* Defined in chip/xxx_timerisr.c */
 
-extern void up_timer_initialize(void);
+void up_timer_initialize(void);
 
 /* Defined in chip/xxx_ethernet.c */
 

arch/hc/src/common/up_internal.h

@@ -1,7 +1,7 @@
 /****************************************************************************
  * arch/hc/src/common/up_internal.h
  *
- *   Copyright (C) 2009, 2011-2013 Gregory Nutt. All rights reserved.
+ *   Copyright (C) 2009, 2011-2013, 2015 Gregory Nutt. All rights reserved.
  *   Author: Gregory Nutt <gnutt@nuttx.org>
  *
  * Redistribution and use in source and binary forms, with or without
@@ -159,49 +159,49 @@ extern uint32_t g_intstackbase;
 
 /* Start-up functions */
 
-extern void up_boot(void);
+void up_boot(void);
 
 /* Context switching functions */
 
-extern void up_copystate(uint8_t *dest, uint8_t *src);
+void up_copystate(uint8_t *dest, uint8_t *src);
-extern void up_decodeirq(uint8_t *regs);
+void up_decodeirq(uint8_t *regs);
-extern void up_irqinitialize(void);
+void up_irqinitialize(void);
-extern int  up_saveusercontext(uint8_t *saveregs);
+int  up_saveusercontext(uint8_t *saveregs);
-extern void up_fullcontextrestore(uint8_t *restoreregs) noreturn_function;
+void up_fullcontextrestore(uint8_t *restoreregs) noreturn_function;
-extern void up_switchcontext(uint8_t *saveregs, uint8_t *restoreregs);
+void up_switchcontext(uint8_t *saveregs, uint8_t *restoreregs);
 
 /* Interrupt handling */
 
-extern uint8_t *up_doirq(int irq, uint8_t *regs);
+uint8_t *up_doirq(int irq, uint8_t *regs);
 
 /* Signal handling */
 
-extern void up_sigdeliver(void);
+void up_sigdeliver(void);
 
 /* System timer initialization */
 
-extern void up_timer_initialize(void);
+void up_timer_initialize(void);
-extern int  up_timerisr(int irq, uint32_t *regs);
+int  up_timerisr(int irq, uint32_t *regs);
 
 /* Debug output */
 
 #if CONFIG_NFILE_DESCRIPTORS > 0
-extern void up_earlyserialinit(void);
+void up_earlyserialinit(void);
-extern void up_serialinit(void);
+void up_serialinit(void);
 #else
 # define up_earlyserialinit()
 # define up_serialinit()
 #endif
 
 #ifdef CONFIG_DEV_LOWCONSOLE
-extern void lowconsole_init(void);
+void lowconsole_init(void);
 #else
 # define lowconsole_init()
 #endif
 
-extern void up_lowputc(char ch);
+void up_lowputc(char ch);
-extern void up_puts(const char *str);
+void up_puts(const char *str);
-extern void up_lowputs(const char *str);
+void up_lowputs(const char *str);
 
 /* Memory configuration */
 
@@ -214,20 +214,20 @@ void up_addregion(void);
 /* Sub-system/driver initialization */
 
 #ifdef CONFIG_ARCH_DMA
-extern void weak_function up_dmainitialize(void);
+void weak_function up_dmainitialize(void);
 #endif
 
-extern void up_wdtinit(void);
+void up_wdtinit(void);
 
 #ifdef CONFIG_NET
-extern void up_netinitialize(void);
+void up_netinitialize(void);
 #else
 # define up_netinitialize()
 #endif
 
 #ifdef CONFIG_USBDEV
-extern void up_usbinitialize(void);
+void up_usbinitialize(void);
-extern void up_usbuninitialize(void);
+void up_usbuninitialize(void);
 #else
 # define up_usbinitialize()
 # define up_usbuninitialize()

arch/mips/src/common/up_internal.h

@@ -1,7 +1,7 @@
 /****************************************************************************
  * arch/mips/common/up_internal.h
  *
- *   Copyright (C) 2011, 2012 Gregory Nutt. All rights reserved.
+ *   Copyright (C) 2011, 2012, 2015 Gregory Nutt. All rights reserved.
  *   Author: Gregory Nutt <gnutt@nuttx.org>
  *
  * Redistribution and use in source and binary forms, with or without
@@ -193,17 +193,17 @@ extern uint32_t _bmxdupba_address;  /* BMX register setting */
 
 /* Context switching */
 
-extern void up_copystate(uint32_t *dest, uint32_t *src);
+void up_copystate(uint32_t *dest, uint32_t *src);
 
 /* Serial output */
 
-extern void up_puts(const char *str);
+void up_puts(const char *str);
-extern void up_lowputs(const char *str);
+void up_lowputs(const char *str);
 
 /* Defined in drivers/lowconsole.c */
 
 #ifdef CONFIG_DEV_LOWCONSOLE
-extern void lowconsole_init(void);
+void lowconsole_init(void);
 #else
 # define lowconsole_init()
 #endif
@@ -211,7 +211,7 @@ extern void lowconsole_init(void);
 /* Debug */
 
 #ifdef CONFIG_ARCH_STACKDUMP
-extern void up_dumpstate(void);
+void up_dumpstate(void);
 #else
 #  define up_dumpstate()
 #endif
@@ -219,28 +219,28 @@ extern void up_dumpstate(void);
 /* Common MIPS32 functions defined in arch/mips/src/MIPS32 */
 /* IRQs */
 
-extern uint32_t *up_doirq(int irq, uint32_t *regs);
+uint32_t *up_doirq(int irq, uint32_t *regs);
 
 /* Software interrupt 0 handler */
 
-extern int up_swint0(int irq, FAR void *context);
+int up_swint0(int irq, FAR void *context);
 
 /* Signals */
 
-extern void up_sigdeliver(void);
+void up_sigdeliver(void);
 
 /* Chip-specific functions **************************************************/
 /* Chip specific functions defined in arch/mips/src/<chip> */
 /* IRQs */
 
-extern void up_irqinitialize(void);
+void up_irqinitialize(void);
-extern bool up_pending_irq(int irq);
+bool up_pending_irq(int irq);
-extern void up_clrpend_irq(int irq);
+void up_clrpend_irq(int irq);
 
 /* DMA */
 
 #ifdef CONFIG_ARCH_DMA
-extern void weak_function up_dmainitialize(void);
+void weak_function up_dmainitialize(void);
 #endif
 
 /* Memory management */
@@ -253,10 +253,10 @@ void up_addregion(void);
 
 /* Serial output */
 
-extern void up_lowputc(char ch);
+void up_lowputc(char ch);
 #if CONFIG_NFILE_DESCRIPTORS > 0
-extern void up_earlyserialinit(void);
+void up_earlyserialinit(void);
-extern void up_serialinit(void);
+void up_serialinit(void);
 #else
 # define up_earlyserialinit()
 # define up_serialinit()
@@ -264,12 +264,12 @@ extern void up_serialinit(void);
 
 /* System timer */
 
-extern void up_timer_initialize(void);
+void up_timer_initialize(void);
 
 /* Network */
 
 #ifdef CONFIG_NET
-extern void up_netinitialize(void);
+void up_netinitialize(void);
 #else
 # define up_netinitialize()
 #endif
@@ -277,8 +277,8 @@ extern void up_netinitialize(void);
 /* USB */
 
 #ifdef CONFIG_USBDEV
-extern void up_usbinitialize(void);
+void up_usbinitialize(void);
-extern void up_usbuninitialize(void);
+void up_usbuninitialize(void);
 #else
 # define up_usbinitialize()
 # define up_usbuninitialize()

arch/x86/src/common/up_internal.h

@@ -1,7 +1,7 @@
 /****************************************************************************
  * arch/x86/src/common/up_internal.h
  *
- *   Copyright (C) 2011-2013 Gregory Nutt. All rights reserved.
+ *   Copyright (C) 2011-2013, 2015 Gregory Nutt. All rights reserved.
  *   Author: Gregory Nutt <gnutt@nuttx.org>
  *
  * Redistribution and use in source and binary forms, with or without
@@ -192,24 +192,24 @@ void x86_boardinitialize(void);
 
 /* Defined in files with the same name as the function */
 
-extern void up_boot(void);
+void up_boot(void);
-extern void up_copystate(uint32_t *dest, uint32_t *src);
+void up_copystate(uint32_t *dest, uint32_t *src);
-extern void up_savestate(uint32_t *regs);
+void up_savestate(uint32_t *regs);
-extern void up_decodeirq(uint32_t *regs);
+void up_decodeirq(uint32_t *regs);
-extern void up_irqinitialize(void);
+void up_irqinitialize(void);
 #ifdef CONFIG_ARCH_DMA
-extern void weak_function up_dmainitialize(void);
+void weak_function up_dmainitialize(void);
 #endif
-extern int  up_saveusercontext(uint32_t *saveregs);
+int  up_saveusercontext(uint32_t *saveregs);
-extern void up_fullcontextrestore(uint32_t *restoreregs) noreturn_function;
+void up_fullcontextrestore(uint32_t *restoreregs) noreturn_function;
-extern void up_switchcontext(uint32_t *saveregs, uint32_t *restoreregs);
+void up_switchcontext(uint32_t *saveregs, uint32_t *restoreregs);
-extern void up_sigdeliver(void);
+void up_sigdeliver(void);
-extern void up_lowputc(char ch);
+void up_lowputc(char ch);
-extern void up_puts(const char *str);
+void up_puts(const char *str);
-extern void up_lowputs(const char *str);
+void up_lowputs(const char *str);
 
-extern void up_syscall(uint32_t *regs);
+void up_syscall(uint32_t *regs);
-extern void up_registerdump(uint32_t *regs);
+void up_registerdump(uint32_t *regs);
 
 /* Defined in up_allocateheap.c */
 
@@ -222,8 +222,8 @@ void up_addregion(void);
 /* Defined in up_serial.c */
 
 #if CONFIG_NFILE_DESCRIPTORS > 0
-extern void up_earlyserialinit(void);
+void up_earlyserialinit(void);
-extern void up_serialinit(void);
+void up_serialinit(void);
 #else
 # define up_earlyserialinit()
 # define up_serialinit()
@@ -232,30 +232,30 @@ extern void up_serialinit(void);
 /* Defined in drivers/lowconsole.c */
 
 #ifdef CONFIG_DEV_LOWCONSOLE
-extern void lowconsole_init(void);
+void lowconsole_init(void);
 #else
 # define lowconsole_init()
 #endif
 
 /* Defined in up_watchdog.c */
 
-extern void up_wdtinit(void);
+void up_wdtinit(void);
 
 /* Defined in up_timerisr.c */
 
-extern void up_timer_initialize(void);
+void up_timer_initialize(void);
 
 /* Defined in board/up_network.c */
 
 #ifdef CONFIG_NET
-extern void up_netinitialize(void);
+void up_netinitialize(void);
 #else
 # define up_netinitialize()
 #endif
 
 #ifdef CONFIG_USBDEV
-extern void up_usbinitialize(void);
+void up_usbinitialize(void);
-extern void up_usbuninitialize(void);
+void up_usbuninitialize(void);
 #else
 # define up_usbinitialize()
 # define up_usbuninitialize()

arch/z16/src/common/up_internal.h

@@ -1,7 +1,7 @@
 /****************************************************************************
  * common/up_internal.h
  *
- *   Copyright (C) 2008-2009, 2011-2013 Gregory Nutt. All rights reserved.
+ *   Copyright (C) 2008-2009, 2011-2013, 2015 Gregory Nutt. All rights reserved.
  *   Author: Gregory Nutt <gnutt@nuttx.org>
  *
  * Redistribution and use in source and binary forms, with or without
@@ -143,16 +143,16 @@ extern volatile FAR chipreg_t *current_regs;
 
 /* Defined in files with the same name as the function */
 
-extern void up_copystate(FAR chipreg_t *dest, FAR chipreg_t *src);
+void up_copystate(FAR chipreg_t *dest, FAR chipreg_t *src);
-extern FAR chipreg_t *up_doirq(int irq, FAR chipreg_t *regs);
+FAR chipreg_t *up_doirq(int irq, FAR chipreg_t *regs);
-extern void up_restoreusercontext(FAR chipreg_t *regs);
+void up_restoreusercontext(FAR chipreg_t *regs);
-extern void up_irqinitialize(void);
+void up_irqinitialize(void);
-extern int  up_saveusercontext(FAR chipreg_t *regs);
+int  up_saveusercontext(FAR chipreg_t *regs);
-extern void up_sigdeliver(void);
+void up_sigdeliver(void);
-extern int  up_timerisr(int irq, FAR chipreg_t *regs);
+int  up_timerisr(int irq, FAR chipreg_t *regs);
 
 #if defined(CONFIG_Z16_LOWPUTC) || defined(CONFIG_Z16_LOWGETC)
-extern void up_lowputc(char ch);
+void up_lowputc(char ch);
 #else
 # define up_lowputc(ch)
 #endif
@@ -166,39 +166,39 @@ void up_addregion(void);
 /* Defined in up_serial.c */
 
 #ifdef USE_SERIALDRIVER
-extern void up_earlyserialinit(void);
+void up_earlyserialinit(void);
-extern void up_serialinit(void);
+void up_serialinit(void);
 #endif
 
 #ifdef USE_LOWCONSOLE
-extern void lowconsole_init(void);
+void lowconsole_init(void);
 #endif
 
 /* Defined in up_timerisr.c */
 
-extern void up_timer_initialize(void);
+void up_timer_initialize(void);
 
 /* Defined in up_irq.c */
 
-extern void up_ack_irq(int irq);
+void up_ack_irq(int irq);
 
 /* Defined in board/up_network.c */
 
 #ifdef CONFIG_NET
-extern void up_netinitialize(void);
+void up_netinitialize(void);
 #else
 # define up_netinitialize()
 #endif
 
 /* Return the current value of the stack pointer (used in stack dump logic) */
 
-extern chipreg_t up_getsp(void);
+chipreg_t up_getsp(void);
 
 /* Dump stack and registers */
 
 #ifdef CONFIG_ARCH_STACKDUMP
-extern void up_stackdump(void);
+void up_stackdump(void);
-extern void up_registerdump(void);
+void up_registerdump(void);
 #else
 # define up_stackdump()
 # define up_registerdump()

arch/z80/src/common/up_internal.h

@@ -1,7 +1,7 @@
 /****************************************************************************
  * arch/z80/src/common/up_internal.h
  *
- *   Copyright (C) 2007-2009 Gregory Nutt. All rights reserved.
+ *   Copyright (C) 2007-2009, 2015 Gregory Nutt. All rights reserved.
  *   Author: Gregory Nutt <gnutt@nuttx.org>
  *
  * Redistribution and use in source and binary forms, with or without
@@ -174,7 +174,7 @@ void lowconsole_init(void);
 /* Defined in drivers/syslog_console.c */
 
 #ifdef defined(CONFIG_SYSLOG_CONSOLE)
-  syslog_console_init();
+void syslog_console_init();
 #else
 # define syslog_console_init()
 #endif
@@ -182,14 +182,14 @@ void lowconsole_init(void);
 /* Defined in drivers/ramlog.c */
 
 #ifdef CONFIG_RAMLOG_CONSOLE
-extern void ramlog_consoleinit(void);
+void ramlog_consoleinit(void);
 #else
 # define ramlog_consoleinit()
 #endif
 
 /* Low level string output */
 
-extern void up_puts(const char *str);
+void up_puts(const char *str);
 
 /* Defined in up_timerisr.c */