mirror of
https://github.com/apache/nuttx.git
synced 2026-06-06 00:14:22 +08:00
Update TODO and some comments.
This commit is contained in:
@@ -116,9 +116,16 @@ int pthread_cancel(pthread_t thread)
|
||||
}
|
||||
|
||||
#ifdef CONFIG_PTHREAD_CLEANUP
|
||||
/* Perform any stack pthread clean-up callbacks */
|
||||
/* Perform any stack pthread clean-up callbacks.
|
||||
*
|
||||
* REVISIT: In this case, the clean-up callback will execute on the
|
||||
* thread of the caller of pthread cancel, not on the thread of
|
||||
* the thread-to-be-canceled. Is that an issue? Presumably they
|
||||
* are both within the same group and within the same process address
|
||||
* space.
|
||||
*/
|
||||
|
||||
pthread_cleanup_popall(tcb);
|
||||
pthread_cleanup_popall(tcb);
|
||||
#endif
|
||||
|
||||
/* Complete pending join operations */
|
||||
|
||||
@@ -77,6 +77,10 @@ static inline void task_atexit(FAR struct tcb_s *tcb)
|
||||
* REVISIT: This is a security problem In the PROTECTED and KERNEL builds:
|
||||
* We must not call the registered function in supervisor mode! See also
|
||||
* on_exit() and pthread_cleanup_pop() callbacks.
|
||||
*
|
||||
* REVISIT: In the case of task_delete(), the callback would execute in
|
||||
* the context the caller of task_delete() cancel, not in the context of
|
||||
* the exiting task (or process).
|
||||
*/
|
||||
|
||||
if (group && group->tg_nmembers == 1)
|
||||
@@ -141,6 +145,10 @@ static inline void task_onexit(FAR struct tcb_s *tcb, int status)
|
||||
* REVISIT: This is a security problem In the PROTECTED and KERNEL builds:
|
||||
* We must not call the registered function in supervisor mode! See also
|
||||
* atexit() and pthread_cleanup_pop() callbacks.
|
||||
*
|
||||
* REVISIT: In the case of task_delete(), the callback would execute in
|
||||
* he context the caller of task_delete() cancel, not in the context of
|
||||
* the exiting task (or process).
|
||||
*/
|
||||
|
||||
if (group && group->tg_nmembers == 1)
|
||||
|
||||
Reference in New Issue
Block a user