From 9f24fb5b4b3b13bdbb31b34824dcab1b235eb23a Mon Sep 17 00:00:00 2001 From: Gregory Nutt Date: Mon, 29 Jul 2019 15:04:39 -0600 Subject: [PATCH] sched/: Add some missing FAR. Update some comments. --- libs/libc/stdio/lib_libvsprintf.c | 7 +++++-- sched/task/task_reparent.c | 8 ++++---- sched/task/task_vfork.c | 6 +++--- 3 files changed, 12 insertions(+), 9 deletions(-) diff --git a/libs/libc/stdio/lib_libvsprintf.c b/libs/libc/stdio/lib_libvsprintf.c index be54e2d4790..eb3829b7d68 100644 --- a/libs/libc/stdio/lib_libvsprintf.c +++ b/libs/libc/stdio/lib_libvsprintf.c @@ -380,8 +380,11 @@ static int vsprintf_internal(FAR struct lib_outstream_s *stream, { switch (sizeof(size_t)) { - /* The only known case that the default will be hit is the eZ80 - * which has sizeof(size_t) = 3 which is the same as the sizeof(int) + /* The only known cases that the default will be hit are + * (1) the eZ80 which has sizeof(size_t) = 3 which is the + * same as the sizeof(int). And (2) if CONFIG_LIBC_LONG_LONG + * is not enabled and sizeof(size_t) is equal to + * sizeof(unsigned long long). This latter case is an error. */ default: diff --git a/sched/task/task_reparent.c b/sched/task/task_reparent.c index e02d5cc45f7..45279a1a0b8 100644 --- a/sched/task/task_reparent.c +++ b/sched/task/task_reparent.c @@ -78,7 +78,7 @@ int task_reparent(pid_t ppid, pid_t chpid) FAR struct task_group_s *chgrp; FAR struct task_group_s *ogrp; FAR struct task_group_s *pgrp; - struct tcb_s *tcb; + FAR struct tcb_s *tcb; gid_t ogid; gid_t pgid; irqstate_t flags; @@ -210,9 +210,9 @@ int task_reparent(pid_t ppid, pid_t chpid) #ifdef CONFIG_SCHED_CHILD_STATUS FAR struct child_status_s *child; #endif - struct tcb_s *ptcb; - struct tcb_s *chtcb; - struct tcb_s *otcb; + FAR struct tcb_s *ptcb; + FAR struct tcb_s *chtcb; + FAR struct tcb_s *otcb; pid_t opid; irqstate_t flags; int ret; diff --git a/sched/task/task_vfork.c b/sched/task/task_vfork.c index 69999366a30..9424751a0fe 100644 --- a/sched/task/task_vfork.c +++ b/sched/task/task_vfork.c @@ -282,8 +282,8 @@ static inline size_t nxvfork_argsize(FAR struct tcb_s *parent) FAR struct task_tcb_s *nxtask_vforksetup(start_t retaddr, size_t *argsize) { - struct tcb_s *parent = this_task(); - struct task_tcb_s *child; + FAR struct tcb_s *parent = this_task(); + FAR struct task_tcb_s *child; uint8_t ttype; int priority; int ret; @@ -407,7 +407,7 @@ errout_with_tcb: pid_t nxtask_vforkstart(FAR struct task_tcb_s *child) { - struct tcb_s *parent = this_task(); + FAR struct tcb_s *parent = this_task(); pid_t pid; int rc; int ret;