Mirrors_Framework/nuttx
1
0
Fork 0
mirror of https://github.com/apache/nuttx.git synced 2026-06-05 15:58:59 +08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

nuttx/graphics/nxglib: Add some REVISIT comments to some logic that looks suspicious.

Browse Source
This commit is contained in:
Gregory Nutt
2017-11-27 15:34:35 -06:00
parent 4eda9e92de
commit 9c82ce2091
1 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
graphics/nxglib/fb/nxglib_copyrectangle.c
+9 -5
View File
@@ -91,8 +91,9 @@ void NXGL_FUNCNAME(nxgl_copyrectangle, NXGLIB_SUFFIX)
rows = dest->pt2.y - dest->pt1.y + 1; rows = dest->pt2.y - dest->pt1.y + 1;
#if NXGLIB_BITSPERPIXEL < 8 #if NXGLIB_BITSPERPIXEL < 8
# ifdef CONFIG_NX_PACKEDMSFIRST /* REVISIT: Doesn't the following assume 8 pixels in a byte */
# ifdef CONFIG_NX_PACKEDMSFIRST
/* Get the mask for pixels that are ordered so that they pack from the /* Get the mask for pixels that are ordered so that they pack from the
* MS byte down. * MS byte down.
*/ */
@@ -111,8 +112,11 @@ void NXGL_FUNCNAME(nxgl_copyrectangle, NXGLIB_SUFFIX)
/* Then copy the image */ /* Then copy the image */
sline = (FAR const uint8_t *)src + NXGL_SCALEX(dest->pt1.x - origin->x) + (dest->pt1.y - origin->y) * srcstride; sline = (FAR const uint8_t *)src +
dline = pinfo->fbmem + dest->pt1.y * deststride + NXGL_SCALEX(dest->pt1.x); NXGL_SCALEX(dest->pt1.x - origin->x) +
(dest->pt1.y - origin->y) * srcstride;
dline = pinfo->fbmem + dest->pt1.y * deststride +
NXGL_SCALEX(dest->pt1.x);
while (rows--) while (rows--)
{ {
@@ -130,7 +134,7 @@ void NXGL_FUNCNAME(nxgl_copyrectangle, NXGLIB_SUFFIX)
mask = 0xff; mask = 0xff;
dptr++; dptr++;
sptr++; sptr++;
lnlen--; lnlen--; /* REVISIT: Is this correct? */
} }
/* Handle masking of the fractional final byte */ /* Handle masking of the fractional final byte */
@@ -139,7 +143,7 @@ void NXGL_FUNCNAME(nxgl_copyrectangle, NXGLIB_SUFFIX)
if (lnlen > 0 && mask) if (lnlen > 0 && mask)
{ {
dptr[lnlen-1] = (dptr[lnlen-1] & ~mask) | (sptr[lnlen-1] & mask); dptr[lnlen-1] = (dptr[lnlen-1] & ~mask) | (sptr[lnlen-1] & mask);
lnlen--; lnlen--; /* REVISIT: Is this correct? */
} }
/* Handle all of the unmasked bytes in-between */ /* Handle all of the unmasked bytes in-between */