From 9142deeb105f3cfe7e9ea15fb13f1f5503b19639 Mon Sep 17 00:00:00 2001 From: patacongo Date: Wed, 30 Sep 2020 08:03:52 -0600 Subject: [PATCH] Update arch/arm/src/common/arm_interruptcontext.c Add a comment discussing the limitation of this solution for the case of the ARMv7-A with the GIC --- arch/arm/src/common/arm_interruptcontext.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/src/common/arm_interruptcontext.c b/arch/arm/src/common/arm_interruptcontext.c index 6ec9d122377..9c7f148d5bb 100644 --- a/arch/arm/src/common/arm_interruptcontext.c +++ b/arch/arm/src/common/arm_interruptcontext.c @@ -60,6 +60,12 @@ bool up_interrupt_context(void) { #ifdef CONFIG_SMP + /* REVISIT: Currently up_irq_save() will not disable the Software + * Generated Interrupts (SGIs) for the case of ARMv7-A architecture using + * the GIC. So this will not be sufficient in that case, at least not + * until we add support for the ICCMPR. + */ + irqstate_t flags = up_irq_save(); #endif