Mirrors_Framework/nuttx
1
0
Fork 0
mirror of https://github.com/apache/nuttx.git synced 2026-06-02 01:21:26 +08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

net/devif/devif_callback.c: devif_callback_free() call is not needed anymore in devif_callback_alloc()

Browse Source
This commit is contained in:
Alexander Lunev
2022-01-06 16:33:11 +03:00
committed by Xiang Xiao
parent afacc8d590
commit 8042de1145
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
net/devif/devif_callback.c
+8 -3
View File
@@ -274,11 +274,16 @@ FAR struct devif_callback_s *
* device in the UP state. * device in the UP state.
*/ */
/* Note: dev->d_flags may be asynchronously changed by netdev_ifdown()
* (in net/netdev/netdev_ioctl.c). Nevertheless, net_lock() / net_unlock()
* are not required in netdev_ifdown() to prevent dev->d_flags from
* asynchronous change here. There is not an issue because net_lock() and
* net_unlock() present inside of devif_dev_event(). That should be enough
* to de-allocate connection callbacks reliably on NETDEV_DOWN event.
*/
if (dev && !netdev_verify(dev) && (dev->d_flags & IFF_UP) != 0) if (dev && !netdev_verify(dev) && (dev->d_flags & IFF_UP) != 0)
{ {
/* No.. release the callback structure and fail */
devif_callback_free(NULL, NULL, list_head, list_tail);
net_unlock(); net_unlock();
return NULL; return NULL;
} }