Mirrors_Framework/nuttx
1
0
Fork 0
mirror of https://github.com/apache/nuttx.git synced 2026-05-28 20:08:15 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

fs/vfs: file_write() and file_pwrite() are internal OS interfaces and should not report errors via the errno

Browse Source
This commit is contained in:
Gregory Nutt
2017-09-28 14:49:05 -06:00
parent e761b80ea7
commit 7b7ca87941
3 changed files with 37 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files
fs/aio/aio_write.c
+18 -12
View File
@@ -155,6 +155,13 @@ static void aio_write_worker(FAR void *arg)
aiocbp->aio_nbytes,
aiocbp->aio_offset);
}
/* errno is not set */
if (nwritten < 0)
{
ferr("ERROR: file_write/file_pwrite failed: %d\n", nwritten);
}
}
#endif
#if defined(AIO_HAVE_FILEP) && defined(AIO_HAVE_PSOCK)
@@ -172,22 +179,21 @@ static void aio_write_worker(FAR void *arg)
nwritten = psock_send(aioc->u.aioc_psock,
(FAR const void *)aiocbp->aio_buf,
aiocbp->aio_nbytes, 0);
/* errno is set */
if (nwritten < 0)
{
int errcode = get_errno();
ferr("ERROR: psock_send failed: %d\n", errcode);
DEBUGASSERT(errcode > 0);
nwritten = -errcode;
}
}
#endif
/* Check the result of the write */
/* Save the result of the write */
if (nwritten < 0)
{
int errcode = get_errno();
ferr("ERROR: write/pwrite failed: %d\n", errcode);
DEBUGASSERT(errcode > 0);
aiocbp->aio_result = -errcode;
}
else
{
aiocbp->aio_result = nwritten;
}
aiocbp->aio_result = nwritten;
#ifdef AIO_HAVE_FILEP
errout: