Review of previous commit

This commit is contained in:
Gregory Nutt
2017-03-30 12:28:40 -06:00
parent 9e2b3da3e8
commit 7b789f57ac
2 changed files with 66 additions and 52 deletions
-4
View File
@@ -2829,8 +2829,6 @@ config STM32_TICKLESS_CHANNEL
endif # SCHED_TICKLESS endif # SCHED_TICKLESS
if !SCHED_TICKLESS
config STM32_ONESHOT config STM32_ONESHOT
bool "TIM one-shot wrapper" bool "TIM one-shot wrapper"
default n default n
@@ -2845,8 +2843,6 @@ config STM32_FREERUN
Enable a wrapper around the low level timer/counter functions to Enable a wrapper around the low level timer/counter functions to
support a free-running timer. support a free-running timer.
endif # !SCHED_TICKLESS
config STM32_ONESHOT_MAXTIMERS config STM32_ONESHOT_MAXTIMERS
int "Maximum number of oneshot timers" int "Maximum number of oneshot timers"
default 1 default 1
+66 -48
View File
@@ -161,7 +161,8 @@ static inline void stm32_putreg16(uint8_t offset, uint16_t value)
* *
************************************************************************************/ ************************************************************************************/
static inline void stm32_modifyreg16(uint8_t offset, uint16_t clearbits, uint16_t setbits) static inline void stm32_modifyreg16(uint8_t offset, uint16_t clearbits,
uint16_t setbits)
{ {
modifyreg16(g_tickless.base + offset, clearbits, setbits); modifyreg16(g_tickless.base + offset, clearbits, setbits);
} }
@@ -236,14 +237,17 @@ static int stm32_tickless_setchannel(uint8_t channel)
|| g_tickless.base == STM32_TIM7_BASE || g_tickless.base == STM32_TIM7_BASE
#endif #endif
#if STM32_NBTIM > 0 #if STM32_NBTIM > 0
) )
{ {
return -EINVAL; return -EINVAL;
} }
#endif #endif
/* frozen mode because we don't want to change the gpio, preload register disabled */ /* Frozen mode because we don't want to change the GPIO, preload register
ccmr_val = (ATIM_CCMR_MODE_FRZN << ATIM_CCMR1_OC1M_SHIFT); * disabled.
*/
ccmr_val = (ATIM_CCMR_MODE_FRZN << ATIM_CCMR1_OC1M_SHIFT);
/* Set polarity */ /* Set polarity */
@@ -251,7 +255,7 @@ static int stm32_tickless_setchannel(uint8_t channel)
/* Define its position (shift) and get register offset */ /* Define its position (shift) and get register offset */
if (channel & 1) if ((channel & 1) != 0)
{ {
ccmr_val <<= 8; ccmr_val <<= 8;
ccmr_mask <<= 8; ccmr_mask <<= 8;
@@ -293,7 +297,7 @@ static void stm32_interval_handler(void)
{ {
tmrinfo("Expired...\n"); tmrinfo("Expired...\n");
/* Disable the compare interrupt now. */ /* Disable the compare interrupt now. */
stm32_tickless_disableint(g_tickless.channel); stm32_tickless_disableint(g_tickless.channel);
stm32_tickless_ackint(g_tickless.channel); stm32_tickless_ackint(g_tickless.channel);
@@ -303,7 +307,6 @@ static void stm32_interval_handler(void)
sched_timer_expiration(); sched_timer_expiration();
} }
/**************************************************************************** /****************************************************************************
* Name: stm32_timing_handler * Name: stm32_timing_handler
* *
@@ -328,7 +331,6 @@ static void stm32_timing_handler(void)
} }
#endif /* CONFIG_CLOCK_TIMEKEEPING */ #endif /* CONFIG_CLOCK_TIMEKEEPING */
/**************************************************************************** /****************************************************************************
* Name: stm32_tickless_handler * Name: stm32_tickless_handler
* *
@@ -350,11 +352,15 @@ static int stm32_tickless_handler(int irq, void *context, void *arg)
#ifndef CONFIG_CLOCK_TIMEKEEPING #ifndef CONFIG_CLOCK_TIMEKEEPING
if (interrupt_flags & ATIM_SR_UIF) if (interrupt_flags & ATIM_SR_UIF)
stm32_timing_handler(); {
stm32_timing_handler();
}
#endif /* CONFIG_CLOCK_TIMEKEEPING */ #endif /* CONFIG_CLOCK_TIMEKEEPING */
if (interrupt_flags & (1 << g_tickless.channel)) if (interrupt_flags & (1 << g_tickless.channel))
stm32_interval_handler(); {
stm32_interval_handler();
}
return OK; return OK;
} }
@@ -395,98 +401,108 @@ void arm_timer_initialize(void)
#ifdef CONFIG_STM32_TIM1 #ifdef CONFIG_STM32_TIM1
case 1: case 1:
g_tickless.base = STM32_TIM1_BASE; g_tickless.base = STM32_TIM1_BASE;
break; break;
#endif #endif
#ifdef CONFIG_STM32_TIM2 #ifdef CONFIG_STM32_TIM2
case 2: case 2:
g_tickless.base = STM32_TIM2_BASE; g_tickless.base = STM32_TIM2_BASE;
break; break;
#endif #endif
#ifdef CONFIG_STM32_TIM3 #ifdef CONFIG_STM32_TIM3
case 3: case 3:
g_tickless.base = STM32_TIM3_BASE; g_tickless.base = STM32_TIM3_BASE;
break; break;
#endif #endif
#ifdef CONFIG_STM32_TIM4 #ifdef CONFIG_STM32_TIM4
case 4: case 4:
g_tickless.base = STM32_TIM4_BASE; g_tickless.base = STM32_TIM4_BASE;
break; break;
#endif #endif
#ifdef CONFIG_STM32_TIM5 #ifdef CONFIG_STM32_TIM5
case 5: case 5:
g_tickless.base = STM32_TIM5_BASE; g_tickless.base = STM32_TIM5_BASE;
break; break;
#endif #endif
#ifdef CONFIG_STM32_TIM6 #ifdef CONFIG_STM32_TIM6
case 6: case 6:
/* Basic timers not supported by this implementation */ /* Basic timers not supported by this implementation */
ASSERT(0); ASSERT(0);
break; break;
#endif #endif
#ifdef CONFIG_STM32_TIM7 #ifdef CONFIG_STM32_TIM7
case 7: case 7:
/* Basic timers not supported by this implementation */ /* Basic timers not supported by this implementation */
ASSERT(0); ASSERT(0);
break; break;
#endif #endif
#ifdef CONFIG_STM32_TIM8 #ifdef CONFIG_STM32_TIM8
case 8: case 8:
g_tickless.base = STM32_TIM8_BASE; g_tickless.base = STM32_TIM8_BASE;
break; break;
#endif #endif
#ifdef CONFIG_STM32_TIM9 #ifdef CONFIG_STM32_TIM9
case 9: case 9:
g_tickless.base = STM32_TIM9_BASE; g_tickless.base = STM32_TIM9_BASE;
break; break;
#endif #endif
#ifdef CONFIG_STM32_TIM10 #ifdef CONFIG_STM32_TIM10
case 10: case 10:
g_tickless.base = STM32_TIM10_BASE; g_tickless.base = STM32_TIM10_BASE;
break; break;
#endif #endif
#ifdef CONFIG_STM32_TIM11 #ifdef CONFIG_STM32_TIM11
case 11: case 11:
g_tickless.base = STM32_TIM11_BASE; g_tickless.base = STM32_TIM11_BASE;
break; break;
#endif #endif
#ifdef CONFIG_STM32_TIM12 #ifdef CONFIG_STM32_TIM12
case 12: case 12:
g_tickless.base = STM32_TIM12_BASE; g_tickless.base = STM32_TIM12_BASE;
break; break;
#endif #endif
#ifdef CONFIG_STM32_TIM13 #ifdef CONFIG_STM32_TIM13
case 13: case 13:
g_tickless.base = STM32_TIM13_BASE; g_tickless.base = STM32_TIM13_BASE;
break; break;
#endif #endif
#ifdef CONFIG_STM32_TIM14 #ifdef CONFIG_STM32_TIM14
case 14: case 14:
g_tickless.base = STM32_TIM14_BASE; g_tickless.base = STM32_TIM14_BASE;
break; break;
#endif #endif
#ifdef CONFIG_STM32_TIM15 #ifdef CONFIG_STM32_TIM15
case 15: case 15:
g_tickless.base = STM32_TIM15_BASE; g_tickless.base = STM32_TIM15_BASE;
break; break;
#endif #endif
#ifdef CONFIG_STM32_TIM16 #ifdef CONFIG_STM32_TIM16
case 16: case 16:
g_tickless.base = STM32_TIM16_BASE; g_tickless.base = STM32_TIM16_BASE;
break; break;
#endif #endif
#ifdef CONFIG_STM32_TIM17 #ifdef CONFIG_STM32_TIM17
case 17: case 17:
g_tickless.base = STM32_TIM17_BASE; g_tickless.base = STM32_TIM17_BASE;
break; break;
#endif #endif
default: default:
ASSERT(0); ASSERT(0);
} }
/* Get the TC frequency that corresponds to the requested resolution */ /* Get the TC frequency that corresponds to the requested resolution */
@@ -749,6 +765,7 @@ int up_timer_cancel(FAR struct timespec *ts)
ts->tv_sec = 0; ts->tv_sec = 0;
ts->tv_nsec = 0; ts->tv_nsec = 0;
} }
leave_critical_section(flags); leave_critical_section(flags);
return OK; return OK;
} }
@@ -773,7 +790,7 @@ int up_timer_cancel(FAR struct timespec *ts)
* remaining? * remaining?
*/ */
if (ts) if (ts != NULL)
{ {
/* Yes.. then calculate and return the time remaining on the /* Yes.. then calculate and return the time remaining on the
* oneshot timer. * oneshot timer.
@@ -786,7 +803,7 @@ int up_timer_cancel(FAR struct timespec *ts)
{ {
/* Handle rollover */ /* Handle rollover */
period += UINT16_MAX; period += UINT16_MAX;
} }
else if (count == period) else if (count == period)
{ {
@@ -794,27 +811,27 @@ int up_timer_cancel(FAR struct timespec *ts)
ts->tv_sec = 0; ts->tv_sec = 0;
ts->tv_nsec = 0; ts->tv_nsec = 0;
return OK; return OK;
} }
/* The total time remaining is the difference. Convert that /* The total time remaining is the difference. Convert that
* to units of microseconds. * to units of microseconds.
* *
* frequency = ticks / second * frequency = ticks / second
* seconds = ticks * frequency * seconds = ticks * frequency
* usecs = (ticks * USEC_PER_SEC) / frequency; * usecs = (ticks * USEC_PER_SEC) / frequency;
*/ */
usec = (((uint64_t)(period - count)) * USEC_PER_SEC) / usec = (((uint64_t)(period - count)) * USEC_PER_SEC) /
g_tickless.frequency; g_tickless.frequency;
/* Return the time remaining in the correct form */ /* Return the time remaining in the correct form */
sec = usec / USEC_PER_SEC; sec = usec / USEC_PER_SEC;
nsec = ((usec) - (sec * USEC_PER_SEC)) * NSEC_PER_USEC; nsec = ((usec) - (sec * USEC_PER_SEC)) * NSEC_PER_USEC;
ts->tv_sec = (time_t)sec; ts->tv_sec = (time_t)sec;
ts->tv_nsec = (unsigned long)nsec; ts->tv_nsec = (unsigned long)nsec;
tmrinfo("remaining (%lu, %lu)\n", tmrinfo("remaining (%lu, %lu)\n",
(unsigned long)ts->tv_sec, (unsigned long)ts->tv_nsec); (unsigned long)ts->tv_sec, (unsigned long)ts->tv_nsec);
@@ -897,7 +914,8 @@ int up_timer_start(FAR const struct timespec *ts)
g_tickless.period = (uint16_t)(period + count); g_tickless.period = (uint16_t)(period + count);
STM32_TIM_SETCOMPARE(g_tickless.tch, g_tickless.channel, g_tickless.period); STM32_TIM_SETCOMPARE(g_tickless.tch, g_tickless.channel,
g_tickless.period);
/* Enable interrupts. We should get the callback when the interrupt /* Enable interrupts. We should get the callback when the interrupt
* occurs. * occurs.