Mirrors_Framework/nuttx
1
0
Fork 0
mirror of https://github.com/apache/nuttx.git synced 2026-05-26 10:46:28 +08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

fs/inode: remove all unnecessary check for filep/inode

Browse Source 
Since VFS layer already contains sanity checks, so remove unnecessary lower half checks

Signed-off-by: chao an <anchao@xiaomi.com>
This commit is contained in:
chao an
2023-08-28 17:17:05 +08:00
committed by Xiang Xiao
parent baabf4bbf3
commit 7aa45305b7
158 changed files with 412 additions and 714 deletions
Download Patch File Download Diff File Expand all files Collapse all files
drivers/input/button_upper.c
+3 -6
View File
@@ -309,7 +309,6 @@ static int btn_open(FAR struct file *filep)
btn_buttonset_t supported;
irqstate_t flags;
DEBUGASSERT(filep && filep->f_inode);
inode = filep->f_inode;
DEBUGASSERT(inode->i_private);
priv = (FAR struct btn_upperhalf_s *)inode->i_private;
@@ -364,7 +363,7 @@ static int btn_close(FAR struct file *filep)
FAR struct btn_open_s *prev;
irqstate_t flags;
DEBUGASSERT(filep && filep->f_priv && filep->f_inode);
DEBUGASSERT(filep->f_priv);
opriv = filep->f_priv;
inode = filep->f_inode;
DEBUGASSERT(inode->i_private);
@@ -432,7 +431,6 @@ static ssize_t btn_read(FAR struct file *filep, FAR char *buffer,
FAR const struct btn_lowerhalf_s *lower;
irqstate_t flags;
DEBUGASSERT(filep && filep->f_inode);
opriv = filep->f_priv;
inode = filep->f_inode;
DEBUGASSERT(inode->i_private);
@@ -478,7 +476,6 @@ static ssize_t btn_write(FAR struct file *filep, FAR const char *buffer,
irqstate_t flags;
int ret;
DEBUGASSERT(filep && filep->f_inode);
inode = filep->f_inode;
DEBUGASSERT(inode->i_private);
priv = (FAR struct btn_upperhalf_s *)inode->i_private;
@@ -529,7 +526,7 @@ static int btn_ioctl(FAR struct file *filep, int cmd, unsigned long arg)
irqstate_t flags;
int ret = OK;
DEBUGASSERT(filep && filep->f_priv && filep->f_inode);
DEBUGASSERT(filep->f_priv);
opriv = filep->f_priv;
inode = filep->f_inode;
DEBUGASSERT(inode->i_private);
@@ -656,7 +653,7 @@ static int btn_poll(FAR struct file *filep, FAR struct pollfd *fds,
int ret = OK;
int i;
DEBUGASSERT(filep && filep->f_priv && filep->f_inode);
DEBUGASSERT(filep->f_priv);
opriv = filep->f_priv;
inode = filep->f_inode;
DEBUGASSERT(inode->i_private);