Mirrors_Framework/nuttx
1
0
Fork 0
mirror of https://github.com/apache/nuttx.git synced 2026-06-02 01:21:26 +08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

I'm worried about the stm32_tim_getcounter funtion. It returns always 32 bits. But major stm32 timers have 16 bits counters. I think, it's not a good idea to return the memory behind the TIMx_CNT register. This changes adds the register size checking.

Browse Source
This commit is contained in:
Sergei Ustinov
2017-08-31 11:45:28 -06:00
committed by Gregory Nutt
parent a7fd8eb203
commit 795650a2fb
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
arch/arm/src/stm32/stm32_tim.c
+3 -1
View File
@@ -903,7 +903,9 @@ static void stm32_tim_setperiod(FAR struct stm32_tim_dev_s *dev,
static uint32_t stm32_tim_getcounter(FAR struct stm32_tim_dev_s *dev) static uint32_t stm32_tim_getcounter(FAR struct stm32_tim_dev_s *dev)
{ {
DEBUGASSERT(dev != NULL); DEBUGASSERT(dev != NULL);
return stm32_getreg32(dev, STM32_BTIM_CNT_OFFSET); return stm32_tim_getwidth(dev) > 16 ?
stm32_getreg32(dev, STM32_BTIM_CNT_OFFSET) :
(uint32_t)stm32_getreg16(dev, STM32_BTIM_CNT_OFFSET);
} }
/************************************************************************************ /************************************************************************************