From 6d1cd731b54a087db7cd88a2d83344d7dcac5189 Mon Sep 17 00:00:00 2001 From: Gregory Nutt Date: Fri, 17 Jun 2016 08:43:22 -0600 Subject: [PATCH] Eliminate a warning --- graphics/vnc/server/vnc_server.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/graphics/vnc/server/vnc_server.c b/graphics/vnc/server/vnc_server.c index 7c4aa84ad32..513d10c7367 100644 --- a/graphics/vnc/server/vnc_server.c +++ b/graphics/vnc/server/vnc_server.c @@ -248,17 +248,25 @@ int vnc_server(int argc, FAR char *argv[]) if (argc != 2) { + /* In this case the start-up logic will probably hang, waiting for the + * display-related semaphore to be set. + */ + gerr("ERROR: Unexpected number of arguments: %d\n", argc); ret = -EINVAL; - goto errout_with_post; + goto errout_with_hang; } display = atoi(argv[1]); if (display < 0 || display >= RFB_MAX_DISPLAYS) { + /* In this case the start-up logic will probably hang, waiting for the + * display-related semaphore to be set. + */ + gerr("ERROR: Invalid display number: %d\n", display); ret = -EINVAL; - goto errout_with_post; + goto errout_with_hang; } ginfo("Server started for Display %d\n", display); @@ -373,5 +381,7 @@ errout_with_fb: errout_with_post: g_fbstartup[display].result = ret; sem_post(&g_fbstartup[display].fbconnect); + +errout_with_hang: return EXIT_FAILURE; }