Most cosmetic, but includes some fixes to some range checking

This commit is contained in:
Gregory Nutt
2015-07-23 14:36:49 -06:00
parent 53a17bfd99
commit 5baa738019
8 changed files with 18 additions and 133 deletions
+4
View File
@@ -45,6 +45,10 @@
#include <debug.h> #include <debug.h>
#include <errno.h> #include <errno.h>
/****************************************************************************
* Public Functions
****************************************************************************/
/**************************************************************************** /****************************************************************************
* Function: pthread_attr_setschedparam * Function: pthread_attr_setschedparam
* *
+5 -33
View File
@@ -1,7 +1,7 @@
/************************************************************************ /************************************************************************
* libc/sched/sched_getprioritymax.c * libc/sched/sched_getprioritymax.c
* *
* Copyright (C) 2007, 2009, 2011 Gregory Nutt. All rights reserved. * Copyright (C) 2007, 2009, 2011, 2015 Gregory Nutt. All rights reserved.
* Author: Gregory Nutt <gnutt@nuttx.org> * Author: Gregory Nutt <gnutt@nuttx.org>
* *
* Redistribution and use in source and binary forms, with or without * Redistribution and use in source and binary forms, with or without
@@ -39,32 +39,10 @@
#include <nuttx/config.h> #include <nuttx/config.h>
#include <assert.h>
#include <nuttx/arch.h> #include <nuttx/arch.h>
/************************************************************************
* Pre-processor Definitions
************************************************************************/
/************************************************************************
* Private Type Declarations
************************************************************************/
/************************************************************************
* Global Variables
************************************************************************/
/************************************************************************
* Private Variables
************************************************************************/
/************************************************************************
* Private Function Prototypes
************************************************************************/
/************************************************************************
* Private Functions
************************************************************************/
/************************************************************************ /************************************************************************
* Public Functions * Public Functions
************************************************************************/ ************************************************************************/
@@ -89,12 +67,6 @@
int sched_get_priority_max(int policy) int sched_get_priority_max(int policy)
{ {
if (policy != SCHED_FIFO && policy != SCHED_RR) DEBUGASSERT(policy >= SCHED_FIFO && policy <= SCHED_OTHER);
{ return SCHED_PRIORITY_MAX;
return ERROR;
}
else
{
return SCHED_PRIORITY_MAX;
}
} }
+5 -33
View File
@@ -1,7 +1,7 @@
/************************************************************************ /************************************************************************
* libc/sched/sched_getprioritymin.c * libc/sched/sched_getprioritymin.c
* *
* Copyright (C) 2007, 2009, 2011 Gregory Nutt. All rights reserved. * Copyright (C) 2007, 2009, 2011, 2015 Gregory Nutt. All rights reserved.
* Author: Gregory Nutt <gnutt@nuttx.org> * Author: Gregory Nutt <gnutt@nuttx.org>
* *
* Redistribution and use in source and binary forms, with or without * Redistribution and use in source and binary forms, with or without
@@ -39,32 +39,10 @@
#include <nuttx/config.h> #include <nuttx/config.h>
#include <assert.h>
#include <nuttx/arch.h> #include <nuttx/arch.h>
/************************************************************************
* Pre-processor Definitions
************************************************************************/
/************************************************************************
* Private Type Declarations
************************************************************************/
/************************************************************************
* Global Variables
************************************************************************/
/************************************************************************
* Private Variables
************************************************************************/
/************************************************************************
* Private Function Prototypes
************************************************************************/
/************************************************************************
* Private Functions
************************************************************************/
/************************************************************************ /************************************************************************
* Public Functions * Public Functions
************************************************************************/ ************************************************************************/
@@ -89,12 +67,6 @@
int sched_get_priority_min(int policy) int sched_get_priority_min(int policy)
{ {
if (policy != SCHED_FIFO && policy != SCHED_RR) DEBUGASSERT(policy >= SCHED_FIFO && policy <= SCHED_OTHER);
{ return SCHED_PRIORITY_MIN;
return ERROR;
}
else
{
return SCHED_PRIORITY_MIN;
}
} }
+1 -1
View File
@@ -44,7 +44,7 @@
#include <assert.h> #include <assert.h>
/**************************************************************************** /****************************************************************************
* Global Functions * Public Functions
****************************************************************************/ ****************************************************************************/
/**************************************************************************** /****************************************************************************
+2 -9
View File
@@ -58,16 +58,9 @@
#include "pthread/pthread.h" #include "pthread/pthread.h"
/**************************************************************************** /****************************************************************************
* Pre-processor Definitions * Public Data
****************************************************************************/ ****************************************************************************/
/****************************************************************************
* Private Type Declarations
****************************************************************************/
/****************************************************************************
* Global Variables
****************************************************************************/
/* Default pthread attributes (see include/nuttx/pthread.h). When configured /* Default pthread attributes (see include/nuttx/pthread.h). When configured
* to build separate kernel- and user-address spaces, this global is * to build separate kernel- and user-address spaces, this global is
* duplicated in each address spaced. This copy can only be shared within * duplicated in each address spaced. This copy can only be shared within
@@ -77,7 +70,7 @@
const pthread_attr_t g_default_pthread_attr = PTHREAD_ATTR_INITIALIZER; const pthread_attr_t g_default_pthread_attr = PTHREAD_ATTR_INITIALIZER;
/**************************************************************************** /****************************************************************************
* Private Variables * Private Data
****************************************************************************/ ****************************************************************************/
/* This is the name for name-less pthreads */ /* This is the name for name-less pthreads */
-24
View File
@@ -48,30 +48,6 @@
#include "clock/clock.h" #include "clock/clock.h"
#include "sched/sched.h" #include "sched/sched.h"
/****************************************************************************
* Pre-processor Definitions
****************************************************************************/
/****************************************************************************
* Private Type Declarations
****************************************************************************/
/****************************************************************************
* Global Variables
****************************************************************************/
/****************************************************************************
* Private Variables
****************************************************************************/
/****************************************************************************
* Private Function Prototypes
****************************************************************************/
/****************************************************************************
* Private Functions
****************************************************************************/
/**************************************************************************** /****************************************************************************
* Public Functions * Public Functions
****************************************************************************/ ****************************************************************************/
-24
View File
@@ -49,30 +49,6 @@
#include "sched/sched.h" #include "sched/sched.h"
#include "clock/clock.h" #include "clock/clock.h"
/****************************************************************************
* Pre-processor Definitions
****************************************************************************/
/****************************************************************************
* Private Type Declarations
****************************************************************************/
/****************************************************************************
* Global Variables
****************************************************************************/
/****************************************************************************
* Private Variables
****************************************************************************/
/****************************************************************************
* Private Function Prototypes
****************************************************************************/
/****************************************************************************
* Private Functions
****************************************************************************/
/**************************************************************************** /****************************************************************************
* Public Functions * Public Functions
****************************************************************************/ ****************************************************************************/
+1 -9
View File
@@ -49,10 +49,6 @@
#include "task/spawn.h" #include "task/spawn.h"
#include "task/task.h" #include "task/task.h"
/****************************************************************************
* Private Types
****************************************************************************/
/**************************************************************************** /****************************************************************************
* Public Data * Public Data
****************************************************************************/ ****************************************************************************/
@@ -63,10 +59,6 @@ sem_t g_spawn_execsem = SEM_INITIALIZER(0);
#endif #endif
struct spawn_parms_s g_spawn_parms; struct spawn_parms_s g_spawn_parms;
/****************************************************************************
* Private Data
****************************************************************************/
/**************************************************************************** /****************************************************************************
* Private Functions * Private Functions
****************************************************************************/ ****************************************************************************/
@@ -310,7 +302,7 @@ int spawn_execattrs(pid_t pid, FAR const posix_spawnattr_t *attr)
* file_actions - The attributes to use * file_actions - The attributes to use
* *
* Returned Value: * Returned Value:
* 0 (OK) on successed; A negated errno value is returned on failure. * 0 (OK) on success; A negated errno value is returned on failure.
* *
****************************************************************************/ ****************************************************************************/