Mirrors_Framework/nuttx
1
0
Fork 0
mirror of https://github.com/apache/nuttx.git synced 2026-05-31 14:27:37 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

virtio/gpu: minor revision on virtio_gpu_send_cmd()

Browse Source 
This revises comments and completes reclaiming buf param.

Signed-off-by: Yanfeng Liu <yfliu2008@qq.com>
This commit is contained in:
Yanfeng Liu
2024-03-31 09:15:04 +08:00
committed by Xiang Xiao
parent 715f8de1bb
commit 1eb96c3446
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
drivers/virtio/virtio-gpu.c
+8 -1
View File
@@ -133,6 +133,8 @@ static FAR struct virtio_gpu_priv_s *g_virtio_gpu[VIRTIO_GPU_MAX_DISP];
/**************************************************************************** /****************************************************************************
* Name: virtio_gpu_send_cmd * Name: virtio_gpu_send_cmd
* Note: the caller should not touch `buf` after calling this, as it will be
* freed either here or in virtio_gpu_done().
****************************************************************************/ ****************************************************************************/
static int virtio_gpu_send_cmd(FAR struct virtqueue *vq, static int virtio_gpu_send_cmd(FAR struct virtqueue *vq,
@@ -146,6 +148,7 @@ static int virtio_gpu_send_cmd(FAR struct virtqueue *vq,
sem_t sem; sem_t sem;
struct virtio_gpu_cookie_s cookie; struct virtio_gpu_cookie_s cookie;
virtio_free_buf(vq->vq_dev, buf);
nxsem_init(&sem, 0, 0); nxsem_init(&sem, 0, 0);
cookie.blocking = true; cookie.blocking = true;
cookie.p = &sem; cookie.p = &sem;
@@ -180,10 +183,14 @@ static int virtio_gpu_send_cmd(FAR struct virtqueue *vq,
} }
else else
{ {
virtio_free_buf(vq->vq_dev, buf);
kmm_free(cookie); kmm_free(cookie);
} }
} }
if (buf && ret < 0)
{
virtio_free_buf(vq->vq_dev, buf);
}
} }
return ret; return ret;