From 1ba443aab252cc5b0e265a6123060dfb39cd2e7a Mon Sep 17 00:00:00 2001 From: Huang Qi Date: Tue, 23 Aug 2022 23:39:45 +0800 Subject: [PATCH] prctl: Replace strncpy with strlcpy for safety strlcpy ensure the destination is NUL-terminated, and also fix warning: ```c task/task_prctl.c:138:15: warning: 'strncpy' output may be truncated copying 30 bytes from a string of length 31 [-Wstringop-truncation] 138 | strncpy(name, tcb->name, CONFIG_TASK_NAME_SIZE - 1); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ``` Signed-off-by: Huang Qi --- sched/task/task_prctl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sched/task/task_prctl.c b/sched/task/task_prctl.c index 017ee5b55b8..15192127d0d 100644 --- a/sched/task/task_prctl.c +++ b/sched/task/task_prctl.c @@ -126,7 +126,7 @@ int prctl(int option, ...) * necessary. */ - strncpy(tcb->name, name, CONFIG_TASK_NAME_SIZE); + strlcpy(tcb->name, name, sizeof(tcb->name)); tcb->name[CONFIG_TASK_NAME_SIZE] = '\0'; } else @@ -135,7 +135,7 @@ int prctl(int option, ...) * necessary. */ - strncpy(name, tcb->name, CONFIG_TASK_NAME_SIZE - 1); + strlcpy(name, tcb->name, sizeof(tcb->name)); name[CONFIG_TASK_NAME_SIZE - 1] = '\0'; } }