mirror of
https://github.com/apache/nuttx.git
synced 2026-05-28 11:56:10 +08:00
fs/procfs: Remove the unnecessary strcmp
since the procfs already make the same check for us Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
This commit is contained in:
committed by
Petro Karashchenko
parent
10bb48b9b4
commit
1b77ae88ef
@@ -137,14 +137,6 @@ static int dvfs_open(FAR struct file *filep, FAR const char *relpath,
|
|||||||
|
|
||||||
finfo("Open '%s'\n", relpath);
|
finfo("Open '%s'\n", relpath);
|
||||||
|
|
||||||
/* "dvfs" is the only acceptable value for the relpath */
|
|
||||||
|
|
||||||
if (strcmp(relpath, "dvfs") != 0)
|
|
||||||
{
|
|
||||||
ferr("ERROR: relpath is '%s'\n", relpath);
|
|
||||||
return -ENOENT;
|
|
||||||
}
|
|
||||||
|
|
||||||
/* Allocate a container to hold the task and attribute selection */
|
/* Allocate a container to hold the task and attribute selection */
|
||||||
|
|
||||||
priv = (FAR struct dvfs_file_s *)kmm_zalloc(sizeof(struct dvfs_file_s));
|
priv = (FAR struct dvfs_file_s *)kmm_zalloc(sizeof(struct dvfs_file_s));
|
||||||
@@ -355,12 +347,6 @@ static int dvfs_dup(FAR const struct file *oldp, FAR struct file *newp)
|
|||||||
|
|
||||||
static int dvfs_stat(const char *relpath, struct stat *buf)
|
static int dvfs_stat(const char *relpath, struct stat *buf)
|
||||||
{
|
{
|
||||||
if (strcmp(relpath, "dvfs") != 0)
|
|
||||||
{
|
|
||||||
ferr("ERROR: relpath is '%s'\n", relpath);
|
|
||||||
return -ENOENT;
|
|
||||||
}
|
|
||||||
|
|
||||||
buf->st_mode =
|
buf->st_mode =
|
||||||
S_IFREG |
|
S_IFREG |
|
||||||
S_IROTH | S_IWOTH |
|
S_IROTH | S_IWOTH |
|
||||||
|
|||||||
@@ -146,14 +146,6 @@ static int resetcause_open(FAR struct file *filep, FAR const char *relpath,
|
|||||||
return -EACCES;
|
return -EACCES;
|
||||||
}
|
}
|
||||||
|
|
||||||
/* "resetcause" is the only acceptable value for the relpath */
|
|
||||||
|
|
||||||
if (strcmp(relpath, "resetcause") != 0)
|
|
||||||
{
|
|
||||||
ferr("ERROR: relpath is '%s'\n", relpath);
|
|
||||||
return -ENOENT;
|
|
||||||
}
|
|
||||||
|
|
||||||
/* Allocate a container to hold the file attributes */
|
/* Allocate a container to hold the file attributes */
|
||||||
|
|
||||||
attr = kmm_zalloc(sizeof(struct resetcause_file_s));
|
attr = kmm_zalloc(sizeof(struct resetcause_file_s));
|
||||||
@@ -278,14 +270,6 @@ static int resetcause_dup(FAR const struct file *oldp, FAR struct file *newp)
|
|||||||
|
|
||||||
static int resetcause_stat(FAR const char *relpath, FAR struct stat *buf)
|
static int resetcause_stat(FAR const char *relpath, FAR struct stat *buf)
|
||||||
{
|
{
|
||||||
/* "resetcause" is the only acceptable value for the relpath */
|
|
||||||
|
|
||||||
if (strcmp(relpath, "resetcause") != 0)
|
|
||||||
{
|
|
||||||
ferr("ERROR: relpath is '%s'\n", relpath);
|
|
||||||
return -ENOENT;
|
|
||||||
}
|
|
||||||
|
|
||||||
/* "resetcause" is the name for a read-only file */
|
/* "resetcause" is the name for a read-only file */
|
||||||
|
|
||||||
memset(buf, 0, sizeof(struct stat));
|
memset(buf, 0, sizeof(struct stat));
|
||||||
|
|||||||
@@ -138,14 +138,6 @@ static int cpuload_open(FAR struct file *filep, FAR const char *relpath,
|
|||||||
return -EACCES;
|
return -EACCES;
|
||||||
}
|
}
|
||||||
|
|
||||||
/* "cpuload" is the only acceptable value for the relpath */
|
|
||||||
|
|
||||||
if (strcmp(relpath, "cpuload") != 0)
|
|
||||||
{
|
|
||||||
ferr("ERROR: relpath is '%s'\n", relpath);
|
|
||||||
return -ENOENT;
|
|
||||||
}
|
|
||||||
|
|
||||||
/* Allocate a container to hold the file attributes */
|
/* Allocate a container to hold the file attributes */
|
||||||
|
|
||||||
attr = kmm_zalloc(sizeof(struct cpuload_file_s));
|
attr = kmm_zalloc(sizeof(struct cpuload_file_s));
|
||||||
@@ -310,14 +302,6 @@ static int cpuload_dup(FAR const struct file *oldp, FAR struct file *newp)
|
|||||||
|
|
||||||
static int cpuload_stat(const char *relpath, struct stat *buf)
|
static int cpuload_stat(const char *relpath, struct stat *buf)
|
||||||
{
|
{
|
||||||
/* "cpuload" is the only acceptable value for the relpath */
|
|
||||||
|
|
||||||
if (strcmp(relpath, "cpuload") != 0)
|
|
||||||
{
|
|
||||||
ferr("ERROR: relpath is '%s'\n", relpath);
|
|
||||||
return -ENOENT;
|
|
||||||
}
|
|
||||||
|
|
||||||
/* "cpuload" is the name for a read-only file */
|
/* "cpuload" is the name for a read-only file */
|
||||||
|
|
||||||
memset(buf, 0, sizeof(struct stat));
|
memset(buf, 0, sizeof(struct stat));
|
||||||
|
|||||||
@@ -137,14 +137,6 @@ static int critmon_open(FAR struct file *filep, FAR const char *relpath,
|
|||||||
return -EACCES;
|
return -EACCES;
|
||||||
}
|
}
|
||||||
|
|
||||||
/* "critmon" is the only acceptable value for the relpath */
|
|
||||||
|
|
||||||
if (strcmp(relpath, "critmon") != 0)
|
|
||||||
{
|
|
||||||
ferr("ERROR: relpath is '%s'\n", relpath);
|
|
||||||
return -ENOENT;
|
|
||||||
}
|
|
||||||
|
|
||||||
/* Allocate a container to hold the file attributes */
|
/* Allocate a container to hold the file attributes */
|
||||||
|
|
||||||
attr = kmm_zalloc(sizeof(struct critmon_file_s));
|
attr = kmm_zalloc(sizeof(struct critmon_file_s));
|
||||||
@@ -359,14 +351,6 @@ static int critmon_dup(FAR const struct file *oldp, FAR struct file *newp)
|
|||||||
|
|
||||||
static int critmon_stat(const char *relpath, struct stat *buf)
|
static int critmon_stat(const char *relpath, struct stat *buf)
|
||||||
{
|
{
|
||||||
/* "critmon" is the only acceptable value for the relpath */
|
|
||||||
|
|
||||||
if (strcmp(relpath, "critmon") != 0)
|
|
||||||
{
|
|
||||||
ferr("ERROR: relpath is '%s'\n", relpath);
|
|
||||||
return -ENOENT;
|
|
||||||
}
|
|
||||||
|
|
||||||
/* "critmon" is the name for a read-only file */
|
/* "critmon" is the name for a read-only file */
|
||||||
|
|
||||||
memset(buf, 0, sizeof(struct stat));
|
memset(buf, 0, sizeof(struct stat));
|
||||||
|
|||||||
@@ -209,14 +209,6 @@ static int iobinfo_open(FAR struct file *filep, FAR const char *relpath,
|
|||||||
return -EACCES;
|
return -EACCES;
|
||||||
}
|
}
|
||||||
|
|
||||||
/* "iobinfo" is the only acceptable value for the relpath */
|
|
||||||
|
|
||||||
if (strcmp(relpath, "iobinfo") != 0)
|
|
||||||
{
|
|
||||||
ferr("ERROR: relpath is '%s'\n", relpath);
|
|
||||||
return -ENOENT;
|
|
||||||
}
|
|
||||||
|
|
||||||
/* Allocate a container to hold the file attributes */
|
/* Allocate a container to hold the file attributes */
|
||||||
|
|
||||||
procfile = (FAR struct iobinfo_file_s *)
|
procfile = (FAR struct iobinfo_file_s *)
|
||||||
@@ -395,14 +387,6 @@ static int iobinfo_dup(FAR const struct file *oldp, FAR struct file *newp)
|
|||||||
|
|
||||||
static int iobinfo_stat(FAR const char *relpath, FAR struct stat *buf)
|
static int iobinfo_stat(FAR const char *relpath, FAR struct stat *buf)
|
||||||
{
|
{
|
||||||
/* "iobinfo" is the only acceptable value for the relpath */
|
|
||||||
|
|
||||||
if (strcmp(relpath, "iobinfo") != 0)
|
|
||||||
{
|
|
||||||
ferr("ERROR: relpath is '%s'\n", relpath);
|
|
||||||
return -ENOENT;
|
|
||||||
}
|
|
||||||
|
|
||||||
/* "iobinfo" is the name for a read-only file */
|
/* "iobinfo" is the name for a read-only file */
|
||||||
|
|
||||||
memset(buf, 0, sizeof(struct stat));
|
memset(buf, 0, sizeof(struct stat));
|
||||||
|
|||||||
@@ -218,14 +218,6 @@ static int meminfo_open(FAR struct file *filep, FAR const char *relpath,
|
|||||||
return -EACCES;
|
return -EACCES;
|
||||||
}
|
}
|
||||||
|
|
||||||
/* "meminfo" is the only acceptable value for the relpath */
|
|
||||||
|
|
||||||
if (strcmp(relpath, "meminfo") != 0)
|
|
||||||
{
|
|
||||||
ferr("ERROR: relpath is '%s'\n", relpath);
|
|
||||||
return -ENOENT;
|
|
||||||
}
|
|
||||||
|
|
||||||
/* Allocate a container to hold the file attributes */
|
/* Allocate a container to hold the file attributes */
|
||||||
|
|
||||||
procfile = (FAR struct meminfo_file_s *)
|
procfile = (FAR struct meminfo_file_s *)
|
||||||
@@ -439,14 +431,6 @@ static int meminfo_dup(FAR const struct file *oldp, FAR struct file *newp)
|
|||||||
|
|
||||||
static int meminfo_stat(FAR const char *relpath, FAR struct stat *buf)
|
static int meminfo_stat(FAR const char *relpath, FAR struct stat *buf)
|
||||||
{
|
{
|
||||||
/* "meminfo" is the only acceptable value for the relpath */
|
|
||||||
|
|
||||||
if (strcmp(relpath, "meminfo") != 0)
|
|
||||||
{
|
|
||||||
ferr("ERROR: relpath is '%s'\n", relpath);
|
|
||||||
return -ENOENT;
|
|
||||||
}
|
|
||||||
|
|
||||||
/* "meminfo" is the name for a read-only file */
|
/* "meminfo" is the name for a read-only file */
|
||||||
|
|
||||||
memset(buf, 0, sizeof(struct stat));
|
memset(buf, 0, sizeof(struct stat));
|
||||||
|
|||||||
@@ -136,14 +136,6 @@ static int tcbinfo_open(FAR struct file *filep, FAR const char *relpath,
|
|||||||
return -EACCES;
|
return -EACCES;
|
||||||
}
|
}
|
||||||
|
|
||||||
/* "tcbinfo" is the only acceptable value for the relpath */
|
|
||||||
|
|
||||||
if (strcmp(relpath, "tcbinfo") != 0)
|
|
||||||
{
|
|
||||||
ferr("ERROR: relpath is '%s'\n", relpath);
|
|
||||||
return -ENOENT;
|
|
||||||
}
|
|
||||||
|
|
||||||
/* Allocate a container to hold the file attributes */
|
/* Allocate a container to hold the file attributes */
|
||||||
|
|
||||||
attr = (FAR struct tcbinfo_file_s *)
|
attr = (FAR struct tcbinfo_file_s *)
|
||||||
@@ -274,14 +266,6 @@ static int tcbinfo_dup(FAR const struct file *oldp, FAR struct file *newp)
|
|||||||
|
|
||||||
static int tcbinfo_stat(FAR const char *relpath, FAR struct stat *buf)
|
static int tcbinfo_stat(FAR const char *relpath, FAR struct stat *buf)
|
||||||
{
|
{
|
||||||
/* "tcbinfo" is the only acceptable value for the relpath */
|
|
||||||
|
|
||||||
if (strcmp(relpath, "tcbinfo") != 0)
|
|
||||||
{
|
|
||||||
ferr("ERROR: relpath is '%s'\n", relpath);
|
|
||||||
return -ENOENT;
|
|
||||||
}
|
|
||||||
|
|
||||||
/* "tcbinfo" is the name for a read-only file */
|
/* "tcbinfo" is the name for a read-only file */
|
||||||
|
|
||||||
memset(buf, 0, sizeof(struct stat));
|
memset(buf, 0, sizeof(struct stat));
|
||||||
|
|||||||
@@ -139,14 +139,6 @@ static int uptime_open(FAR struct file *filep, FAR const char *relpath,
|
|||||||
return -EACCES;
|
return -EACCES;
|
||||||
}
|
}
|
||||||
|
|
||||||
/* "uptime" is the only acceptable value for the relpath */
|
|
||||||
|
|
||||||
if (strcmp(relpath, "uptime") != 0)
|
|
||||||
{
|
|
||||||
ferr("ERROR: relpath is '%s'\n", relpath);
|
|
||||||
return -ENOENT;
|
|
||||||
}
|
|
||||||
|
|
||||||
/* Allocate a container to hold the file attributes */
|
/* Allocate a container to hold the file attributes */
|
||||||
|
|
||||||
attr = kmm_zalloc(sizeof(struct uptime_file_s));
|
attr = kmm_zalloc(sizeof(struct uptime_file_s));
|
||||||
@@ -330,14 +322,6 @@ static int uptime_dup(FAR const struct file *oldp, FAR struct file *newp)
|
|||||||
|
|
||||||
static int uptime_stat(FAR const char *relpath, FAR struct stat *buf)
|
static int uptime_stat(FAR const char *relpath, FAR struct stat *buf)
|
||||||
{
|
{
|
||||||
/* "uptime" is the only acceptable value for the relpath */
|
|
||||||
|
|
||||||
if (strcmp(relpath, "uptime") != 0)
|
|
||||||
{
|
|
||||||
ferr("ERROR: relpath is '%s'\n", relpath);
|
|
||||||
return -ENOENT;
|
|
||||||
}
|
|
||||||
|
|
||||||
/* "uptime" is the name for a read-only file */
|
/* "uptime" is the name for a read-only file */
|
||||||
|
|
||||||
memset(buf, 0, sizeof(struct stat));
|
memset(buf, 0, sizeof(struct stat));
|
||||||
|
|||||||
@@ -139,14 +139,6 @@ static int version_open(FAR struct file *filep, FAR const char *relpath,
|
|||||||
return -EACCES;
|
return -EACCES;
|
||||||
}
|
}
|
||||||
|
|
||||||
/* "version" is the only acceptable value for the relpath */
|
|
||||||
|
|
||||||
if (strcmp(relpath, "version") != 0)
|
|
||||||
{
|
|
||||||
ferr("ERROR: relpath is '%s'\n", relpath);
|
|
||||||
return -ENOENT;
|
|
||||||
}
|
|
||||||
|
|
||||||
/* Allocate a container to hold the file attributes */
|
/* Allocate a container to hold the file attributes */
|
||||||
|
|
||||||
attr = (FAR struct version_file_s *)
|
attr = (FAR struct version_file_s *)
|
||||||
@@ -279,14 +271,6 @@ static int version_dup(FAR const struct file *oldp, FAR struct file *newp)
|
|||||||
|
|
||||||
static int version_stat(FAR const char *relpath, FAR struct stat *buf)
|
static int version_stat(FAR const char *relpath, FAR struct stat *buf)
|
||||||
{
|
{
|
||||||
/* "version" is the only acceptable value for the relpath */
|
|
||||||
|
|
||||||
if (strcmp(relpath, "version") != 0)
|
|
||||||
{
|
|
||||||
ferr("ERROR: relpath is '%s'\n", relpath);
|
|
||||||
return -ENOENT;
|
|
||||||
}
|
|
||||||
|
|
||||||
/* "version" is the name for a read-only file */
|
/* "version" is the name for a read-only file */
|
||||||
|
|
||||||
memset(buf, 0, sizeof(struct stat));
|
memset(buf, 0, sizeof(struct stat));
|
||||||
|
|||||||
@@ -284,14 +284,6 @@ static int irq_open(FAR struct file *filep, FAR const char *relpath,
|
|||||||
return -EACCES;
|
return -EACCES;
|
||||||
}
|
}
|
||||||
|
|
||||||
/* "irqs" is the only acceptable value for the relpath */
|
|
||||||
|
|
||||||
if (strcmp(relpath, "irqs") != 0)
|
|
||||||
{
|
|
||||||
ferr("ERROR: relpath is '%s'\n", relpath);
|
|
||||||
return -ENOENT;
|
|
||||||
}
|
|
||||||
|
|
||||||
/* Allocate a container to hold the file attributes */
|
/* Allocate a container to hold the file attributes */
|
||||||
|
|
||||||
irqfile = (FAR struct irq_file_s *)kmm_zalloc(sizeof(struct irq_file_s));
|
irqfile = (FAR struct irq_file_s *)kmm_zalloc(sizeof(struct irq_file_s));
|
||||||
@@ -422,14 +414,6 @@ static int irq_dup(FAR const struct file *oldp, FAR struct file *newp)
|
|||||||
|
|
||||||
static int irq_stat(const char *relpath, struct stat *buf)
|
static int irq_stat(const char *relpath, struct stat *buf)
|
||||||
{
|
{
|
||||||
/* "irqs" is the only acceptable value for the relpath */
|
|
||||||
|
|
||||||
if (strcmp(relpath, "irqs") != 0)
|
|
||||||
{
|
|
||||||
ferr("ERROR: relpath is '%s'\n", relpath);
|
|
||||||
return -ENOENT;
|
|
||||||
}
|
|
||||||
|
|
||||||
/* "irqs" is the name for a read-only file */
|
/* "irqs" is the name for a read-only file */
|
||||||
|
|
||||||
memset(buf, 0, sizeof(struct stat));
|
memset(buf, 0, sizeof(struct stat));
|
||||||
|
|||||||
Reference in New Issue
Block a user