Mirrors_Framework/nuttx
1
0
Fork 0
mirror of https://github.com/apache/nuttx.git synced 2026-05-31 23:40:19 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

getopt_commont(): Add some comments

Browse Source 
Add a trivial comment about handling in certain corner cases where I am not certain what the correct behavior should be.
This commit is contained in:
Gregory Nutt
2021-04-04 08:55:26 -06:00
committed by Xiang Xiao
parent 6481eb6523
commit 1b4af6e90d
1 changed files with 13 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
libs/libc/unistd/lib_getopt_common.c
+13 -3
View File
@@ -387,7 +387,7 @@ int getopt_common(int argc, FAR char * const argv[],
ret = getopt_long_option(go, argv, longopts, longindex); ret = getopt_long_option(go, argv, longopts, longindex);
if (ret == '?') if (ret == '?')
{ {
/* Skip over the unrecognized long option */ /* Skip over the unrecognized long option. */
go->go_optind++; go->go_optind++;
go->go_optptr = NULL; go->go_optptr = NULL;
@@ -412,13 +412,23 @@ int getopt_common(int argc, FAR char * const argv[],
ret = getopt_long_option(go, argv, longopts, longindex); ret = getopt_long_option(go, argv, longopts, longindex);
if (ret != '?') if (ret != '?')
{ {
/* Success or ERROR */ /* Return success or ERROR */
return ret; return ret;
} }
/* Check for single character option.
*
* REVISIT: There is no way to distinguish a sequence of
* short arguments like -abc (meaning -a -b -c) from a single
* long argument (like "abc"). I am not sure of the correct
* behavior in this case. While supported for getopt(), I do
* not think that the first interpretation is standard.
*/
else if (*(go->go_optptr + 1) != '\0') else if (*(go->go_optptr + 1) != '\0')
{ {
/* Skip over the unrecognized long option */ /* Skip over the unrecognized long option. */
go->go_optind++; go->go_optind++;
go->go_optptr = NULL; go->go_optptr = NULL;