Mirrors_Framework/nuttx
1
0
Fork 0
mirror of https://github.com/apache/nuttx.git synced 2026-05-28 03:45:50 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

fs/semaphore/open: fix the inode information update outside of lock

Browse Source 
For re-enter case, the inode information may unlock with not filled,
and get by other user. that lead to the error behavior.
Especially SMP scene.

Signed-off-by: buxiasen <buxiasen@xiaomi.com>
This commit is contained in:
buxiasen
2025-07-16 12:15:53 +08:00
committed by Xiang Xiao
parent d3e5e756c5
commit 1794fbaa61
1 changed files with 26 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files
fs/semaphore/sem_open.c
+26 -22
View File
@@ -176,19 +176,6 @@ int nxsem_open(FAR sem_t **sem, FAR const char *name, int oflags, ...)
goto errout_with_search;
}
/* Create an inode in the pseudo-filesystem at this path. The new
* inode will be created with a reference count of zero.
*/
inode_lock();
ret = inode_reserve(fullpath, mode, &inode);
inode_unlock();
if (ret < 0)
{
goto errout_with_search;
}
/* Allocate the semaphore structure (using the appropriate allocator
* for the group)
*/
@@ -197,22 +184,39 @@ int nxsem_open(FAR sem_t **sem, FAR const char *name, int oflags, ...)
if (!nsem)
{
ret = -ENOMEM;
goto errout_with_inode;
goto errout_with_search;
}
/* Link to the inode */
/* Create an inode in the pseudo-filesystem at this path. The new
* inode will be created with a reference count of zero.
*/
inode->u.i_nsem = nsem;
nsem->ns_inode = inode;
inode_lock();
ret = inode_reserve(fullpath, mode, &inode);
if (ret >= 0)
{
/* Link to the inode */
/* Initialize the inode */
inode->u.i_nsem = nsem;
nsem->ns_inode = inode;
INODE_SET_NAMEDSEM(inode);
atomic_fetch_add(&inode->i_crefs, 1);
/* Initialize the inode */
/* Initialize the semaphore */
INODE_SET_NAMEDSEM(inode);
atomic_fetch_add(&inode->i_crefs, 1);
nxsem_init(&nsem->ns_sem, 0, value);
/* Initialize the semaphore */
nxsem_init(&nsem->ns_sem, 0, value);
}
inode_unlock();
if (ret < 0)
{
group_free(NULL, nsem);
goto errout_with_search;
}
/* Return a reference to the semaphore */