From 0c7871edd1b9b308af29045e048a1a99ea87a33b Mon Sep 17 00:00:00 2001
From: patacongo <patacongo@42af7a65-404d-4744-a932-0658087f49c3>
Date: Mon, 25 Jun 2012 15:24:52 +0000
Subject: [PATCH] Fix a critical PIC32 GPIO configuration bug

git-svn-id: svn://svn.code.sf.net/p/nuttx/code/trunk@4867 42af7a65-404d-4744-a932-0658087f49c3
---
 ChangeLog                              |  3 +++
 Documentation/NxWidgets.html           | 21 ++++++++++++++++++++-
 arch/mips/src/pic32mx/pic32mx-gpio.c   |  8 +++-----
 arch/mips/src/pic32mx/pic32mx-ioport.h |  1 +
 4 files changed, 27 insertions(+), 6 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 15a09989d5e..626af37ed1b 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -2923,5 +2923,8 @@
 	  the Mirtoo module.
 	* configs/mirtoo/scripts:  Move all Mirtoo linker scripts to a common
 	  directory.
+	* arch/mips/src/pic32mx/pic32mx-gpio.c:  All digital inputs were being
+	  configured as outputs.  This is a *critical* bug fix and needs to be
+	  incorporated by any PIC32 users.
 
 
diff --git a/Documentation/NxWidgets.html b/Documentation/NxWidgets.html
index 165248145b4..cef99d49433 100755
--- a/Documentation/NxWidgets.html
+++ b/Documentation/NxWidgets.html
@@ -57,7 +57,26 @@
 </p>
 <h1>NXWidgets DOxygen Documentation</h1>
 <p>
-  DOxygen documentation for the NxWidgets-1.0 is now available online at <a href="http://www.nx-engineering.com/nxwidgets_v1_0/">this location</a>.
+  Release notes, DOxygen documentation, as well as downloads for the latest NxWidgets releases are available online:
+</p>
+<ul>
+  <li>
+    <b>NxWidgets-1.0</b>:
+    <a href="http://www.nx-engineering.com/nxwidgets_v1_0/">Documentation</a>, and
+    <a href="http://sourceforge.net/projects/nuttx/files/NxWidgets/NxWidgets-1.0/">Downloads</a>
+  </li>
+  <li>
+    <b>NxWidgets-1.1</b>:
+    <a href="http://www.nx-engineering.com/nxwidgets_v1_1/">Documentation</a>,
+    <a href="http://sourceforge.net/projects/nuttx/files/NxWidgets/NxWidgets-1.1/">Release notes</a>, and
+    <a href="http://sourceforge.net/projects/nuttx/files/NxWidgets/NxWidgets-1.1/">Downloads</a>
+  </li>
+  <li>
+    <b>NxWidgets-1.2</b>:
+    <a href="http://www.nx-engineering.com/nxwidgets_v1_2/">Documentation</a>,
+    <a href="http://sourceforge.net/projects/nuttx/files/NxWidgets/NxWidgets-1.2/">Release notes</a>, and
+    <a href="http://sourceforge.net/projects/nuttx/files/NxWidgets/NxWidgets-1.2/">Downloads</a>
+  </li>
 </p>
 <p>
   Thanks go to Jose Pablo Carballo for contributing this!
diff --git a/arch/mips/src/pic32mx/pic32mx-gpio.c b/arch/mips/src/pic32mx/pic32mx-gpio.c
index a4bef478369..ecff125adf3 100644
--- a/arch/mips/src/pic32mx/pic32mx-gpio.c
+++ b/arch/mips/src/pic32mx/pic32mx-gpio.c
@@ -160,7 +160,7 @@ int pic32mx_configgpio(uint16_t cfgset)
       sched_lock();
       if (pic32mx_output(cfgset))
         {
-          /* It is an output; set the corresponding bit in the TRIS register */
+          /* It is an output; clear the corresponding bit in the TRIS register */
 
           putreg32(1 << pin, base + PIC32MX_IOPORT_TRISCLR_OFFSET);
 
@@ -189,11 +189,9 @@ int pic32mx_configgpio(uint16_t cfgset)
         }
       else
         {
-          /* It is an input; clear the corresponding bit in the TRIS
-           * register.
-           */
+          /* It is an input; set the corresponding bit in the TRIS register. */
 
-          putreg32(1 << pin, base + PIC32MX_IOPORT_TRISCLR_OFFSET);
+          putreg32(1 << pin, base + PIC32MX_IOPORT_TRISSET_OFFSET);
           putreg32(1 << pin, base + PIC32MX_IOPORT_ODCCLR_OFFSET);
         }
 
diff --git a/arch/mips/src/pic32mx/pic32mx-ioport.h b/arch/mips/src/pic32mx/pic32mx-ioport.h
index 578ce055bb9..fb70676fe4a 100644
--- a/arch/mips/src/pic32mx/pic32mx-ioport.h
+++ b/arch/mips/src/pic32mx/pic32mx-ioport.h
@@ -73,6 +73,7 @@
 #  define PIC32MX_IOPORT_ODCCLR_OFFSET    0x0044 /* Open drain control clear register */
 #  define PIC32MX_IOPORT_ODCSET_OFFSET    0x0048 /* Open drain control set register */
 #  define PIC32MX_IOPORT_ODCINV_OFFSET    0x004c /* Open drain control invert register */
+
 #  define PIC32MX_IOPORT_CNPU_OFFSET      0x0050 /* Change Notification Pull-up register */
 #  define PIC32MX_IOPORT_CNPUCLR_OFFSET   0x0054 /* Change Notification Pull-up clear register */
 #  define PIC32MX_IOPORT_CNPUSET_OFFSET   0x0058 /* Change Notification Pull-up set register */