Mirrors_Framework/nuttx
1
0
Fork 0
mirror of https://github.com/apache/nuttx.git synced 2026-05-27 19:36:35 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

serial/uart_rpmsg: Remove redundant CONFIG_RPMSG_UART_CONSOLE macro check
Build Documentation / build-html (push) Has been cancelled
Details

Browse Source 
Remove the unnecessary CONFIG_RPMSG_UART_CONSOLE preprocessor guard around
the console registration logic in uart_rpmsg_init().

The uart_rpmsg_init() function already accepts a bool isconsole parameter to
dynamically control console registration, which is designed to support flexible
console setup in distributed multi-core SOC systems. Adding the macro check on
top of this runtime parameter is redundant and negates the dynamic registration
capability.

This change fixes a regression introduced by PR #18410, which broke the functionality
of sim/rpproxy and sim/rpserver due to the incorrect macro guard preventing proper
console registration for the rpmsg UART device.

Signed-off-by: chao an <anchao.archer@bytedance.com>
This commit is contained in:
chao an
2026-03-03 18:24:42 +08:00
committed by Matteo Golin
parent d5b02b6954
commit 0a6a2e5e04
2 changed files with 0 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
drivers/serial/uart_rpmsg.c
-2
View File
@@ -458,12 +458,10 @@ int uart_rpmsg_init(FAR const char *cpuname, FAR const char *devname,
UART_RPMSG_DEV_PREFIX, devname); UART_RPMSG_DEV_PREFIX, devname);
uart_register(name, dev); uart_register(name, dev);
#ifdef CONFIG_RPMSG_UART_CONSOLE
if (dev->isconsole) if (dev->isconsole)
{ {
uart_register(UART_RPMSG_DEV_CONSOLE, dev); uart_register(UART_RPMSG_DEV_CONSOLE, dev);
} }
#endif
return 0; return 0;
} }
drivers/serial/uart_rpmsg_raw.c
-2
View File
@@ -369,12 +369,10 @@ int uart_rpmsg_raw_init(FAR const char *cpuname, FAR const char *devname,
UART_RPMSG_DEV_PREFIX, devname); UART_RPMSG_DEV_PREFIX, devname);
uart_register(name, dev); uart_register(name, dev);
#ifdef CONFIG_RPMSG_UART_RAW_CONSOLE
if (dev->isconsole) if (dev->isconsole)
{ {
uart_register(UART_RPMSG_DEV_CONSOLE, dev); uart_register(UART_RPMSG_DEV_CONSOLE, dev);
} }
#endif
return 0; return 0;
} }