diff --git a/configs/lc823450-xgevk/README.txt b/configs/lc823450-xgevk/README.txt index 8994500bf4e..bc0b9e72a3b 100644 --- a/configs/lc823450-xgevk/README.txt +++ b/configs/lc823450-xgevk/README.txt @@ -14,7 +14,6 @@ LC823450 related documents are available at This port is intended to test LC823450 features including SMP. Supported peripherals are UART, TIMER, RTC, GPIO, DMA, I2C, SPI, LCD. - Settings ^^^^^^^^ @@ -25,7 +24,6 @@ Settings 5. Serial console can be used via external USB-UART (115200/8/N/1). 6. Interrupt handlers except for inter-cpu are handled on CPU0. - SMP related Status ^^^^^^^^^^^^^^^^^^ @@ -36,7 +34,6 @@ output into the console because UART operates in FIFO mode. 1. "nsh> smp" works but the result will be corrupted. 2. "nsh> ostest" works but might cause a deadlock or assertion. - Other Status ^^^^^^^^^^^^ @@ -76,7 +73,6 @@ nxhello_main: Screen resolution (128,48) nxhello_hello: Position (31,20) nxhello_main: Close NX - TODO ^^^^ diff --git a/configs/lc823450-xgevk/include/board.h b/configs/lc823450-xgevk/include/board.h index be0bd236c06..a65cc9c9106 100644 --- a/configs/lc823450-xgevk/include/board.h +++ b/configs/lc823450-xgevk/include/board.h @@ -33,7 +33,6 @@ * ****************************************************************************/ - #ifndef __CONFIGS_LC823450_XGEVK_INCLUDE_BOARD_H #define __CONFIGS_LC823450_XGEVK_INCLUDE_BOARD_H @@ -46,7 +45,8 @@ #if defined(__cplusplus) #define EXTERN extern "C" -extern "C" { +extern "C" +{ #else #define EXTERN extern #endif @@ -59,7 +59,6 @@ extern unsigned int XT1OSC_CLK; void up_init_default_mux(void); - #undef EXTERN #if defined(__cplusplus) } diff --git a/configs/lc823450-xgevk/scripts/ld.script b/configs/lc823450-xgevk/scripts/ld.script index 1b638ebb319..9d6b60a1d84 100644 --- a/configs/lc823450-xgevk/scripts/ld.script +++ b/configs/lc823450-xgevk/scripts/ld.script @@ -33,7 +33,6 @@ * ****************************************************************************/ - MEMORY { progmem (rx) : ORIGIN = 0x02040000, LENGTH = 480K diff --git a/configs/lc823450-xgevk/src/lc823450-xgevk.h b/configs/lc823450-xgevk/src/lc823450-xgevk.h index b3e6ef698a6..54fe7d5b3b8 100644 --- a/configs/lc823450-xgevk/src/lc823450-xgevk.h +++ b/configs/lc823450-xgevk/src/lc823450-xgevk.h @@ -33,7 +33,6 @@ * ****************************************************************************/ - #ifndef __CONFIGS_LC823450_XGEVK_SRC_LC823450_XGEVK_H #define __CONFIGS_LC823450_XGEVK_SRC_LC823450_XGEVK_H @@ -57,15 +56,6 @@ # undef HAVE_I2CTOOL #endif - -/**************************************************************************** - * Public Types - ****************************************************************************/ - -/**************************************************************************** - * Public data - ****************************************************************************/ - #ifndef __ASSEMBLY__ /**************************************************************************** @@ -84,10 +74,10 @@ int lc823450_bringup(void); #endif - /************************************************************************************ * Name: lc823450_bma250initialize ************************************************************************************/ + #ifdef CONFIG_BMA250 int lc823450_bma250initialize(FAR const char *devpath); #endif diff --git a/configs/lc823450-xgevk/src/lc823450-xgevk_mux.h b/configs/lc823450-xgevk/src/lc823450-xgevk_mux.h index bc64b00a4ce..d55b81da09e 100644 --- a/configs/lc823450-xgevk/src/lc823450-xgevk_mux.h +++ b/configs/lc823450-xgevk/src/lc823450-xgevk_mux.h @@ -37,10 +37,6 @@ #ifndef __CONFIGS_LC823450_XGEVK_SRC_LC823450_XGEVK_MUX_H #define __CONFIGS_LC823450_XGEVK_SRC_LC823450_XGEVK_MUX_H -/**************************************************************************** - * Included Files - ****************************************************************************/ - /**************************************************************************** * Pre-processor Definitions ****************************************************************************/ @@ -234,7 +230,6 @@ 0 << 14 | /* GPIO1E 0:0, 1:1 */ \ 0 << 15 /* GPIO1F 0:0, 1:1 */ \ - /**************************************************************************** * PORT2 ****************************************************************************/ @@ -329,7 +324,6 @@ 0 << 14 | /* GPIO2E 0:0, 1:1 */ \ 0 << 15 /* GPIO2F 0:0, 1:1 */ \ - /**************************************************************************** * PORT3 ****************************************************************************/ @@ -424,7 +418,6 @@ 0 << 14 | /* GPIO3E 0:0, 1:1 */ \ 0 << 15 /* GPIO3F 0:0, 1:1 */ - /**************************************************************************** * PORT4 ****************************************************************************/ @@ -519,7 +512,6 @@ 0 << 14 | /* GPIO4E 0:0, 1:1 */ \ 0 << 15 /* GPIO4F 0:0, 1:1 */ - /**************************************************************************** * PORT5 ****************************************************************************/ @@ -613,17 +605,4 @@ 0 << 22 | /* XTALI0 0:2mA, 1:---, 2:4mA, 3:8mA */ \ 0 << 24 /* XTALI1 0:2mA, 1:---, 2:4mA, 3:8mA */ - -/**************************************************************************** - * Public Types - ****************************************************************************/ - -/**************************************************************************** - * Public data - ****************************************************************************/ - -/**************************************************************************** - * Public Functions - ****************************************************************************/ - #endif /* __CONFIGS_LC823450_XGEVK_SRC_LC823450_XGEVK_MUX_H */ diff --git a/configs/lc823450-xgevk/src/lc823450_appinit.c b/configs/lc823450-xgevk/src/lc823450_appinit.c index 9d4a8fb42f4..1506410836d 100644 --- a/configs/lc823450-xgevk/src/lc823450_appinit.c +++ b/configs/lc823450-xgevk/src/lc823450_appinit.c @@ -40,6 +40,7 @@ #include #include +#include #include #include @@ -49,10 +50,6 @@ #ifdef CONFIG_LIB_BOARDCTL -/**************************************************************************** - * Pre-processor Definitions - ****************************************************************************/ - /**************************************************************************** * Private Functions ****************************************************************************/ @@ -74,14 +71,15 @@ static void lc823450_i2c_register(int bus) i2c = lc823450_i2cbus_initialize(bus); if (i2c == NULL) { - _err("ERROR: Failed to get I2C%d interface\n", bus); + syslog(LOG_ERR, "ERROR: Failed to get I2C%d interface\n", bus); } else { ret = i2c_register(i2c, bus); if (ret < 0) { - _err("ERROR: Failed to register I2C%d driver: %d\n", bus, ret); + syslog(LOG_ERR, "ERROR: Failed to register I2C%d driver: %d\n", + bus, ret); lc823450_i2cbus_uninitialize(i2c); } } @@ -114,7 +112,6 @@ static void lc823450_i2ctool(void) * Public Functions ****************************************************************************/ - /**************************************************************************** * Name: board_app_initialize * @@ -152,7 +149,7 @@ int board_app_initialize(uintptr_t arg) int ret = lc823450_mtd_initialize(CONFIG_MTD_DEVNO_EMMC); if (ret != OK) { - _err("Failed to initialize eMMC: ret=%d\n", ret); + syslog(LOG_ERR, "Failed to initialize eMMC: ret=%d\n", ret); } #ifdef CONFIG_LC823450_SDIF_SDC @@ -161,7 +158,7 @@ int board_app_initialize(uintptr_t arg) ret = lc823450_mtd_initialize(CONFIG_MTD_DEVNO_SDC); if (ret != OK) { - _err("Failed to initialize uSD: ret=%d\n", ret); + syslog(LOG_ERR, "Failed to initialize uSD: ret=%d\n", ret); } #endif /* CONFIG_LC823450_SDIF_SDC */ diff --git a/configs/lc823450-xgevk/src/lc823450_boot.c b/configs/lc823450-xgevk/src/lc823450_boot.c index 3c70f673e2b..ef5374f98a0 100644 --- a/configs/lc823450-xgevk/src/lc823450_boot.c +++ b/configs/lc823450-xgevk/src/lc823450_boot.c @@ -33,25 +33,14 @@ * ****************************************************************************/ - /**************************************************************************** * Included Files ****************************************************************************/ - #include #include #include - -/**************************************************************************** - * Pre-processor Definitions - ****************************************************************************/ - -/**************************************************************************** - * Private Functions - ****************************************************************************/ - /**************************************************************************** * Public Functions ****************************************************************************/ diff --git a/configs/lc823450-xgevk/src/lc823450_bringup.c b/configs/lc823450-xgevk/src/lc823450_bringup.c index 4f033231ccd..814010eba25 100644 --- a/configs/lc823450-xgevk/src/lc823450_bringup.c +++ b/configs/lc823450-xgevk/src/lc823450_bringup.c @@ -47,14 +47,6 @@ #include "lc823450-xgevk.h" -/**************************************************************************** - * Pre-processor Definitions - ****************************************************************************/ - -/**************************************************************************** - * Private Functions - ****************************************************************************/ - /**************************************************************************** * Public Functions ****************************************************************************/ diff --git a/configs/lc823450-xgevk/src/lc823450_mux.c b/configs/lc823450-xgevk/src/lc823450_mux.c index f054d84415e..5b7debd0ada 100644 --- a/configs/lc823450-xgevk/src/lc823450_mux.c +++ b/configs/lc823450-xgevk/src/lc823450_mux.c @@ -52,15 +52,6 @@ #include "lc823450-xgevk_mux.h" - -/**************************************************************************** - * Pre-processor Definitions - ****************************************************************************/ - -/**************************************************************************** - * Private Functions - ****************************************************************************/ - /**************************************************************************** * Public Functions ****************************************************************************/ @@ -129,5 +120,4 @@ void up_init_default_mux(void) putreg32(PORT6_PUPD, PUDCNT6); putreg32(PORT6_DRV, PTDRVCNT6); - } diff --git a/configs/lc823450-xgevk/src/lc823450_spi.c b/configs/lc823450-xgevk/src/lc823450_spi.c index ea3563662ac..e6aad8f7983 100644 --- a/configs/lc823450-xgevk/src/lc823450_spi.c +++ b/configs/lc823450-xgevk/src/lc823450_spi.c @@ -47,15 +47,10 @@ #include "lc823450_gpio.h" -/**************************************************************************** - * Pre-processor Definitions - ****************************************************************************/ - /**************************************************************************** * Public Functions ****************************************************************************/ - /**************************************************************************** * Name: lc823450_spiselect * @@ -66,7 +61,6 @@ void lc823450_spiselect(FAR struct spi_dev_s *dev, uint32_t devid, bool selected /* no need */ } - /**************************************************************************** * Name: lc823450_spiinitialize * diff --git a/configs/lc823450-xgevk/src/lc823450_st7565.c b/configs/lc823450-xgevk/src/lc823450_st7565.c index c939cc00420..fdfd226ba0e 100644 --- a/configs/lc823450-xgevk/src/lc823450_st7565.c +++ b/configs/lc823450-xgevk/src/lc823450_st7565.c @@ -37,7 +37,6 @@ * Included Files ****************************************************************************/ - #include #include @@ -57,7 +56,6 @@ #include "lc823450_spi.h" #include "lc823450-xgevk.h" - #ifdef CONFIG_NX_LCDDRIVER /**************************************************************************** @@ -74,7 +72,6 @@ * Private Data ****************************************************************************/ - static void lc823450_st7565_reset(FAR struct st7565_lcd_s *lcd, bool on); static void lc823450_st7565_select(FAR struct st7565_lcd_s *lcd); static void lc823450_st7565_deselect(FAR struct st7565_lcd_s *lcd); @@ -97,7 +94,6 @@ static struct st7565_lcd_s g_st7565_dev = .backlight = lc823450_st7565_backlight, }; - /**************************************************************************** * Private Functions ****************************************************************************/ @@ -166,8 +162,6 @@ static int lc823450_st7565_backlight(FAR struct st7565_lcd_s *lcd, int level) return 0; } - - /**************************************************************************** * Public Functions ****************************************************************************/ @@ -188,7 +182,6 @@ int board_lcd_initialize(void) return 0; } - /**************************************************************************** * Name: board_lcd_getdev ****************************************************************************/