Mirrors_Framework/nuttx
1
0
Fork 0
mirror of https://github.com/apache/nuttx.git synced 2026-06-06 08:36:24 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

risc-v/mpfs: IHC: clarify semaphore usage

Browse Source 
g_mpfs_ack_sig and g_mpfs_rx_sig are better used with
SEM_INITIALIZER(0) (signalling) rather than with
SEM_INITIALIZER(1) (mutual exclusion).

Co-authored-by: Petro Karashchenko <petro.karashchenko@gmail.com>
Signed-off-by: Eero Nurkkala <eero.nurkkala@offcode.fi>
This commit is contained in:
Eero Nurkkala
2022-05-13 11:38:29 +03:00
committed by Petro Karashchenko
parent 6f6338cea0
commit 0178792a01
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
arch/risc-v/src/mpfs/mpfs_ihc.c
+5 -5
View File
@@ -169,8 +169,8 @@ static struct mpfs_rptun_shmem_s g_shmem;
static struct rpmsg_device *g_mpfs_rpmsg_device; static struct rpmsg_device *g_mpfs_rpmsg_device;
static struct rpmsg_virtio_device *g_mpfs_virtio_device; static struct rpmsg_virtio_device *g_mpfs_virtio_device;
static sem_t g_mpfs_ack_lock = SEM_INITIALIZER(1); static sem_t g_mpfs_ack_sig = SEM_INITIALIZER(0);
static sem_t g_mpfs_rx_sig = SEM_INITIALIZER(1); static sem_t g_mpfs_rx_sig = SEM_INITIALIZER(0);
static struct list_node g_dev_list = LIST_INITIAL_VALUE(g_dev_list); static struct list_node g_dev_list = LIST_INITIAL_VALUE(g_dev_list);
static uint32_t g_connected_hart_ints; static uint32_t g_connected_hart_ints;
@@ -335,7 +335,7 @@ static uint32_t mpfs_ihc_context_to_remote_hart_id(ihc_channel_t channel)
* *
* Description: * Description:
* This handles the received information and either lets the vq to proceed * This handles the received information and either lets the vq to proceed
* via posting g_mpfs_ack_lock, or lets the mpfs_rptun_thread() run as it * via posting g_mpfs_ack_sig, or lets the mpfs_rptun_thread() run as it
* waits for the g_mpfs_rx_sig. virtqueue_notification() cannot be called * waits for the g_mpfs_rx_sig. virtqueue_notification() cannot be called
* from the interrupt context, thus the thread that will perform it. * from the interrupt context, thus the thread that will perform it.
* *
@@ -354,7 +354,7 @@ static void mpfs_ihc_rx_handler(uint32_t *message, bool is_ack)
{ {
/* Received the ack */ /* Received the ack */
nxsem_post(&g_mpfs_ack_lock); nxsem_post(&g_mpfs_ack_sig);
} }
else else
{ {
@@ -683,7 +683,7 @@ static int mpfs_ihc_tx_message(ihc_channel_t channel, uint32_t *message)
/* Wait for the ACK to arrive to maintain the logic */ /* Wait for the ACK to arrive to maintain the logic */
nxsem_wait_uninterruptible(&g_mpfs_ack_lock); nxsem_wait_uninterruptible(&g_mpfs_ack_sig);
} }
return OK; return OK;