From e22030bb2cfc2e2af564e7ab75d532f7aaa2f9da Mon Sep 17 00:00:00 2001 From: "Roger A. Light" Date: Wed, 31 Aug 2022 09:49:37 +0100 Subject: [PATCH] Try to convince Coverity this string is terminated. --- src/persist_read_v234.c | 2 +- src/persist_read_v5.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/persist_read_v234.c b/src/persist_read_v234.c index 7460c309..49147bba 100644 --- a/src/persist_read_v234.c +++ b/src/persist_read_v234.c @@ -180,9 +180,9 @@ int persist__chunk_msg_store_read_v234(FILE *db_fptr, struct P_msg_store *chunk, log__printf(NULL, MOSQ_LOG_ERR, "Error: Out of memory."); return MOSQ_ERR_NOMEM; } + read_e(db_fptr, chunk->payload, chunk->F.payloadlen); /* Ensure zero terminated regardless of contents */ ((uint8_t *)chunk->payload)[chunk->F.payloadlen] = 0; - read_e(db_fptr, chunk->payload, chunk->F.payloadlen); } return MOSQ_ERR_SUCCESS; diff --git a/src/persist_read_v5.c b/src/persist_read_v5.c index abc9a580..173046ed 100644 --- a/src/persist_read_v5.c +++ b/src/persist_read_v5.c @@ -203,9 +203,9 @@ int persist__chunk_msg_store_read_v56(FILE *db_fptr, struct P_msg_store *chunk, log__printf(NULL, MOSQ_LOG_ERR, "Error: Out of memory."); return MOSQ_ERR_NOMEM; } + read_e(db_fptr, chunk->payload, chunk->F.payloadlen); /* Ensure zero terminated regardless of contents */ ((uint8_t *)chunk->payload)[chunk->F.payloadlen] = 0; - read_e(db_fptr, chunk->payload, chunk->F.payloadlen); } if(length > 0){