From 684c99261a33735afac00dabe5aed00cbc65ee28 Mon Sep 17 00:00:00 2001 From: "Roger A. Light" Date: Wed, 3 Aug 2022 17:57:40 +0100 Subject: [PATCH] argv tests for mosquitto_rr --- test/client/04-rr-argv-errors.py | 127 +++++++++++++++++++++++++++++++ test/client/Makefile | 5 +- test/client/test.py | 2 + 3 files changed, 133 insertions(+), 1 deletion(-) create mode 100755 test/client/04-rr-argv-errors.py diff --git a/test/client/04-rr-argv-errors.py b/test/client/04-rr-argv-errors.py new file mode 100755 index 00000000..2a0fec8b --- /dev/null +++ b/test/client/04-rr-argv-errors.py @@ -0,0 +1,127 @@ +#!/usr/bin/env python3 + +# + +from mosq_test_helper import * + +def do_test(args, stderr_expected, rc_expected): + rc = 1 + + port = mosq_test.get_port() + + env = { + 'LD_LIBRARY_PATH': mosq_test.get_build_root() + '/lib', + 'XDG_CONFIG_HOME':'/tmp/missing' + } + cmd = ['../../client/mosquitto_rr'] + args + + sub = subprocess.Popen(cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE, env=env) + sub.wait() + (stdo, stde) = sub.communicate() + if sub.returncode != rc_expected: + raise mosq_test.TestError(sub.returncode) + if stderr_expected is not None and stde.decode('utf-8') != stderr_expected: + raise mosq_test.TestError(stde) + + +if __name__ == '__main__': + helps = "\nUse 'mosquitto_rr --help' to see usage.\n" + + # Usage, ignore actual text though. + do_test(['--help'], None, 1) + + # Missing args + do_test(['-A'], "Error: -A argument given but no address specified.\n\n" + helps, 1) + do_test(['--cafile'], "Error: --cafile argument given but no file specified.\n\n" + helps, 1) + do_test(['--capath'], "Error: --capath argument given but no directory specified.\n\n" + helps, 1) + do_test(['--cert'], "Error: --cert argument given but no file specified.\n\n" + helps, 1) + do_test(['--ciphers'], "Error: --ciphers argument given but no ciphers specified.\n\n" + helps, 1) + do_test(['-e'], "Error: -e argument given but no response topic specified.\n\n" + helps, 1) + do_test(['-h'], "Error: -h argument given but no host specified.\n\n" + helps, 1) + do_test(['-i'], "Error: -i argument given but no id specified.\n\n" + helps, 1) + do_test(['-I'], "Error: -I argument given but no id prefix specified.\n\n" + helps, 1) + do_test(['-k'], "Error: -k argument given but no keepalive specified.\n\n" + helps, 1) + do_test(['--key'], "Error: --key argument given but no file specified.\n\n" + helps, 1) + do_test(['--keyform'], "Error: --keyform argument given but no keyform specified.\n\n" + helps, 1) + do_test(['-L'], "Error: -L argument given but no URL specified.\n\n" + helps, 1) + do_test(['-M'], "Error: -M argument given but max_inflight not specified.\n\n" + helps, 1) + do_test(['-m'], "Error: -m argument given but no message specified.\n\n" + helps, 1) + do_test(['-o'], "Error: -o argument given but no options file specified.\n\n" + helps, 1) + do_test(['-p'], "Error: -p argument given but no port specified.\n\n" + helps, 1) + do_test(['-P'], "Error: -P argument given but no password specified.\n\n" + helps, 1) + do_test(['--proxy'], "Error: --proxy argument given but no proxy url specified.\n\n" + helps, 1) + do_test(['--psk'], "Error: --psk argument given but no key specified.\n\n" + helps, 1) + do_test(['--psk-identity'], "Error: --psk-identity argument given but no identity specified.\n\n" + helps, 1) + do_test(['-q'], "Error: -q argument given but no QoS specified.\n\n" + helps, 1) + do_test(['-t'], "Error: -t argument given but no topic specified.\n\n" + helps, 1) + do_test(['--tls-alpn'], "Error: --tls-alpn argument given but no protocol specified.\n\n" + helps, 1) + do_test(['--tls-engine'], "Error: --tls-engine argument given but no engine_id specified.\n\n" + helps, 1) + do_test(['--tls-engine-kpass-sha1'], "Error: --tls-engine-kpass-sha1 argument given but no kpass sha1 specified.\n\n" + helps, 1) + do_test(['--tls-version'], "Error: --tls-version argument given but no version specified.\n\n" + helps, 1) + do_test(['-u'], "Error: -u argument given but no username specified.\n\n" + helps, 1) + do_test(['--unix'], "Error: --unix argument given but no socket path specified.\n\n" + helps, 1) + do_test(['-V'], "Error: --protocol-version argument given but no version specified.\n\n" + helps, 1) + do_test(['--will-payload'], "Error: --will-payload argument given but no will payload specified.\n\n" + helps, 1) + do_test(['--will-qos'], "Error: --will-qos argument given but no will QoS specified.\n\n" + helps, 1) + do_test(['--will-topic'], "Error: --will-topic argument given but no will topic specified.\n\n" + helps, 1) + do_test(['-x'], "Error: -x argument given but no session expiry interval specified.\n\n" + helps, 1) + do_test(['-F'], "Error: -F argument given but no format specified.\n\n" + helps, 1) + do_test(['-o'], "Error: -o argument given but no options file specified.\n\n" + helps, 1) + do_test(['-W'], "Error: -W argument given but no timeout specified.\n\n" + helps, 1) + do_test(['--will-payload', 'payload'], "Error: Will payload given, but no will topic given.\n" + helps, 1) + # No -t or -U + do_test([], "Error: All of topic, message, and response topic must be supplied.\n" + helps, 1) + + # Invalid combinations + do_test(['-i', 'id', '-I', 'id-prefix'], "Error: -i and -I argument cannot be used together.\n\n" + helps, 1) + do_test(['-I', 'id-prefix', '-i', 'id'], "Error: -i and -I argument cannot be used together.\n\n" + helps, 1) + + # Invalid output format + do_test(['-F', '%'], "Error: Incomplete format specifier.\n" + helps, 1) + do_test(['-F', '%0'], "Error: Incomplete format specifier.\n" + helps, 1) + do_test(['-F', '%-'], "Error: Incomplete format specifier.\n" + helps, 1) + do_test(['-F', '%1'], "Error: Incomplete format specifier.\n" + helps, 1) + do_test(['-F', '%.'], "Error: Incomplete format specifier.\n" + helps, 1) + do_test(['-F', '%.1'], "Error: Incomplete format specifier.\n" + helps, 1) + do_test(['-F', '%Z'], "Error: Invalid format specifier 'Z'.\n" + helps, 1) + do_test(['-F', '@'], "Error: Incomplete format specifier.\n" + helps, 1) + do_test(['-F', '\\'], "Error: Incomplete escape specifier.\n" + helps, 1) + do_test(['-F', '\\Z'], "Error: Invalid escape specifier 'Z'.\n" + helps, 1) + + # Invalid values + do_test(['-k', '-1'], "Error: Invalid keepalive given, it must be between 5 and 65535 inclusive.\n\n" + helps, 1) + do_test(['-k', '65536'], "Error: Invalid keepalive given, it must be between 5 and 65535 inclusive.\n\n" + helps, 1) + do_test(['-M', '0'], "Error: Maximum inflight messages must be greater than 0.\n\n" + helps, 1) + do_test(['-p', '-1'], "Error: Invalid port given: -1\n" + helps, 1) + do_test(['-p', '65536'], "Error: Invalid port given: 65536\n" + helps, 1) + do_test(['-q', '-1'], "Error: Invalid QoS given: -1\n" + helps, 1) + do_test(['-q', '3'], "Error: Invalid QoS given: 3\n" + helps, 1) + do_test(['-L', 'invalid://'], "Error: Unsupported URL scheme.\n\n" + helps, 1) + do_test(['-L', 'mqtt://localhost'], "Error: Invalid URL for -L argument specified - topic missing.\n" + helps, 1) + do_test(['-V', '5', '-D', 'connect', 'request-problem-information', '-1'], "Error: Property value (-1) out of range for property request-problem-information.\n\n" + helps, 1) + do_test(['-V', '5', '-D', 'connect', 'request-problem-information', '256'], "Error: Property value (256) out of range for property request-problem-information.\n\n" + helps, 1) + do_test(['-V', '5', '-D', 'connect', 'receive-maximum', '-1'], "Error: Property value (-1) out of range for property receive-maximum.\n\n" + helps, 1) + do_test(['-V', '5', '-D', 'connect', 'receive-maximum', '65536'], "Error: Property value (65536) out of range for property receive-maximum.\n\n" + helps, 1) + do_test(['-V', '5', '-D', 'connect', 'session-expiry-interval', '-1'], "Error: Property value (-1) out of range for property session-expiry-interval.\n\n" + helps, 1) + do_test(['-V', '5', '-D', 'connect', 'session-expiry-interval', '4294967296'], "Error: Property value (4294967296) out of range for property session-expiry-interval.\n\n" + helps, 1) + do_test(['-V', '5', '-D', 'subscribe', 'subscription-identifier', '-1'], "Error: Property value (-1) out of range for property subscription-identifier.\n\n" + helps, 1) + do_test(['-V', '5', '-D', 'subscribe', 'subscription-identifier', '4294967296'], "Error: Property value (4294967296) out of range for property subscription-identifier.\n\n" + helps, 1) + do_test(['-V', '5', '-D', 'subscribe', 'topic-alias', '1'], "Error: topic-alias property not allowed for subscribe in --property argument.\n\n" + helps, 1) + do_test(['-V', '0'], "Error: Invalid protocol version argument given.\n\n" + helps, 1) + do_test(['-W', '0'], "Error: Invalid timeout \"0\".\n\n" + helps, 1) + do_test(['--will-qos', '-1'], "Error: Invalid will QoS -1.\n\n" + helps, 1) + do_test(['--will-qos', '3'], "Error: Invalid will QoS 3.\n\n" + helps, 1) + do_test(['--will-topic', '+'], "Error: Invalid will topic '+', does it contain '+' or '#'?\n" + helps, 1) + do_test(['-x', 'A'], "Error: session-expiry-interval not a number.\n\n" + helps, 1) + do_test(['-x', '-2'], "Error: session-expiry-interval out of range.\n\n" + helps, 1) + do_test(['-x', '4294967296'], "Error: session-expiry-interval out of range.\n\n" + helps, 1) + + # Mixed message types + do_test(['-m', 'message', '-f', 'file'], "Error: Only one type of message can be sent at once.\n\n" + helps, 1) + + # Unknown options + do_test(['--unknown'], "Error: Unknown option '--unknown'.\n" + helps, 1) + do_test(['-l'], "Error: Unknown option '-l'.\n" + helps, 1) + do_test(['-r'], "Error: Unknown option '-r'.\n" + helps, 1) + do_test(['--repeat'], "Error: Unknown option '--repeat'.\n" + helps, 1) + do_test(['--repeat-delay'], "Error: Unknown option '--repeat-delay'.\n" + helps, 1) diff --git a/test/client/Makefile b/test/client/Makefile index 3acb8525..bb5d43f3 100644 --- a/test/client/Makefile +++ b/test/client/Makefile @@ -4,7 +4,7 @@ all : check : test -test : 02 03 +test : 02 03 04 ./test.sh #./test-ws.sh @@ -35,6 +35,9 @@ test : 02 03 ./03-publish-stdin-line.py ./03-publish-url.py +04 : + ./04-rr-argv-errors.py + ptest : ./test.sh #./test-ws.sh diff --git a/test/client/test.py b/test/client/test.py index 26ec68ae..22b70969 100755 --- a/test/client/test.py +++ b/test/client/test.py @@ -29,6 +29,8 @@ tests = [ (2, './03-publish-socks.py'), (1, './03-publish-stdin-file.py'), (1, './03-publish-stdin-line.py'), + + (1, './04-rr-argv-errors.py'), ] ptest.run_tests(tests)