From 41f5d1fd432ccbddb99d9ac434fc06e9dad65c0f Mon Sep 17 00:00:00 2001
From: "Roger A. Light" <roger@atchoo.org>
Date: Mon, 17 Nov 2014 20:18:53 +0000
Subject: [PATCH] Fix parsing of malformed socks urls.

---
 client/client_shared.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/client/client_shared.c b/client/client_shared.c
index d2484dcd..7c41d825 100644
--- a/client/client_shared.c
+++ b/client/client_shared.c
@@ -816,6 +816,10 @@ static int mosquitto__parse_socks_url(struct mosq_config *cfg, char *url)
 			if(have_auth){
 				/* Have already seen a @ , so this must be of form
 				 * socks5h://username[:password]@host:port */
+				if(host){
+					/* Already seen a host, must be malformed. */
+					goto cleanup;
+				}
 				len = i-start;
 				host = malloc(len + 1);
 				memcpy(host, &(str[start]), len);
@@ -849,6 +853,10 @@ static int mosquitto__parse_socks_url(struct mosq_config *cfg, char *url)
 			}else{
 				/* Haven't seen a : yet, so must be of form
 				 * socks5h://username@... */
+				if(username){
+					/* Already got a username, must be malformed. */
+					goto cleanup;
+				}
 				len = i-start;
 				username = malloc(len + 1);
 				memcpy(username, &(str[start]), len);