Mirrors_Framework/ghidra
1
0
Fork 0
mirror of https://github.com/NationalSecurityAgency/ghidra.git synced 2026-05-29 03:55:53 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

GP-0: Fix VarargsFilter doing nothing due to firstVarArgSlot never being set

Browse Source 
When the Function Editor assigns parameter storage, PrototypePieces.firstVarArgSlot
was always left at -1, causing VarargsFilter.filter() to unconditionally return false.
Any .cspec rule using <varargs/> (e.g. MSP430's goto_stack for the last fixed arg) had
no effect when storage was (re-)assigned via the UI.

Fix: add a getStorageLocations overload that accepts an isVarArgs flag. When true,
firstVarArgSlot is set to proto.intypes.size() — meaning all supplied parameters are
non-optional and the first vararg slot follows immediately after the last one.
FunctionData.updateParameterAndReturnStorage() now passes hasVarArgs to this overload,
so VarargsFilter-based rules fire correctly.

Fixes #9091

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
vigneshakaviki
2026-04-04 18:43:08 -07:00
committed by James
parent 49155d2384
commit 5259f4b7ae
2 changed files with 29 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Ghidra/Features/Base/src/main/java/ghidra/app/plugin/core/function/editor/FunctionData.java
+1 -1
View File
@@ -218,7 +218,7 @@ class FunctionData extends FunctionDataView {
}
VariableStorage[] paramStorage =
effectiveCallingConvention.getStorageLocations(getProgram(), dataTypes, true);
effectiveCallingConvention.getStorageLocations(getProgram(), dataTypes, true, hasVarArgs);
returnInfo.setStorage(paramStorage[0]);