Merge remote-tracking branch 'origin/GP-0-dragonmacher-test-fixes-12-3-24'

This commit is contained in:
Ryan Kurtz
2024-12-03 10:02:43 -05:00
3 changed files with 4 additions and 4 deletions
@@ -146,7 +146,7 @@ public abstract class ComponentProvider implements HelpDescriptor, ActionContext
* {@link #getContextType()} * {@link #getContextType()}
*/ */
public ComponentProvider(Tool tool, String name, String owner, Class<?> contextType) { public ComponentProvider(Tool tool, String name, String owner, Class<?> contextType) {
this.dockingTool = tool; this.dockingTool = Objects.requireNonNull(tool);
this.name = name; this.name = name;
this.owner = owner; this.owner = owner;
this.title = name; this.title = name;
@@ -503,7 +503,7 @@ public class DockingWindowManager implements PropertyChangeListener, Placeholder
} }
/** /**
* Returns true if the specified provider's component is visible * Returns true if the specified provider's component is or soon will be visible.
* *
* @param provider component provider * @param provider component provider
* @return true if the specified provider's component is visible * @return true if the specified provider's component is visible
@@ -511,7 +511,7 @@ public class DockingWindowManager implements PropertyChangeListener, Placeholder
public boolean isVisible(ComponentProvider provider) { public boolean isVisible(ComponentProvider provider) {
ComponentPlaceholder placeholder = getActivePlaceholder(provider); ComponentPlaceholder placeholder = getActivePlaceholder(provider);
if (placeholder != null) { if (placeholder != null) {
return placeholder.isShowing(); return placeholder.isActive();
} }
return false; return false;
} }
@@ -64,7 +64,7 @@ class PlaceholderManager {
} }
if (defaultPlaceholder.isActive() != restoredPlaceholder.isActive()) { if (defaultPlaceholder.isActive() != restoredPlaceholder.isActive()) {
if (restoredPlaceholder.isShowing()) { if (restoredPlaceholder.isActive()) {
provider.componentShown(); provider.componentShown();
} }
else { else {