Mirrors_Framework/ghidra
1
0
Fork 0
mirror of https://github.com/NationalSecurityAgency/ghidra.git synced 2026-05-30 16:47:43 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

GP-0: Fix tests by brackgrounding patch commands.

Browse Source
This commit is contained in:
Dan
2025-12-22 15:51:49 +00:00
committed by Ryan Kurtz
parent 99298769b9
commit 3e5849c6a9
3 changed files with 92 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Ghidra/Test/DebuggerIntegrationTest/src/test/java/ghidra/app/plugin/core/debug/gui/control/DebuggerControlPluginTest.java
+12 -4
View File
@@ -466,15 +466,19 @@ public class DebuggerControlPluginTest extends AbstractGhidraHeadedDebuggerInteg
assertTrue(
helper.patchInstructionAction.isAddToPopup(listingProvider.getActionContext(null)));
long snapBefore = traceManager.getCurrent().getViewSnap();
Instruction ins =
helper.patchInstructionAt(tb.addr(0x00400123), "imm r0,#0x0", "imm r0,#0x3d2");
assertEquals(2, ins.getLength());
waitForPass(() -> assertNotEquals(snapBefore, traceManager.getCurrent().getViewSnap()));
long snap = traceManager.getCurrent().getViewSnap();
assertTrue(Lifespan.isScratch(snap));
byte[] bytes = new byte[2];
view.getMemory().getBytes(tb.addr(0x00400123), bytes);
assertArrayEquals(tb.arr(0x30, 0xd2), bytes);
waitForPass(noExc(() -> {
view.getMemory().getBytes(tb.addr(0x00400123), bytes);
assertArrayEquals(tb.arr(0x30, 0xd2), bytes);
}));
}
@Test
@@ -517,6 +521,7 @@ public class DebuggerControlPluginTest extends AbstractGhidraHeadedDebuggerInteg
goTo(listingProvider.getListingPanel(), new ProgramLocation(view, tb.addr(0x00400123)));
assertTrue(helper.patchDataAction.isAddToPopup(listingProvider.getActionContext(null)));
long snapBefore = traceManager.getCurrent().getViewSnap();
/**
* TODO: There's a bug in the trace forking: Data units are not replaced when bytes changed.
@@ -525,11 +530,14 @@ public class DebuggerControlPluginTest extends AbstractGhidraHeadedDebuggerInteg
/*Data data =*/ helper.patchDataAt(tb.addr(0x00400123), "0h", "5h");
// assertEquals(2, data.getLength());
waitForPass(() -> assertNotEquals(snapBefore, traceManager.getCurrent().getViewSnap()));
long snap = traceManager.getCurrent().getViewSnap();
assertTrue(Lifespan.isScratch(snap));
byte[] bytes = new byte[2];
view.getMemory().getBytes(tb.addr(0x00400123), bytes);
assertArrayEquals(tb.arr(0, 5), bytes);
waitForPass(noExc(() -> {
view.getMemory().getBytes(tb.addr(0x00400123), bytes);
assertArrayEquals(tb.arr(0, 5), bytes);
}));
}
@Test