J. Nick Koston
a5bd718fc9
[api] Make ProtoDecodableMessage::decode() non-virtual
...
decode() is never called polymorphically - all call sites in
read_message_() use concrete types. The only indirect call site was
decode_to_message(), which also always knows the concrete type.
Convert decode_to_message() to a template so the concrete type is
preserved, allowing decode() to be non-virtual. The two classes that
override decode() (ExecuteServiceArgument, ExecuteServiceRequest) now
hide the base method, which works since all calls use concrete types.
This removes one vtable slot (4 bytes) from each decodable message
class vtable, saving ~148 bytes of flash.
2026-03-21 20:51:28 -10:00
J. Nick Koston
1d191d2461
[api] Fix review comments and add USE_API guards
...
- Update comments to reflect that ProtoService methods moved to
APIConnection, not APIServerConnectionBase
- Fix comment referring to read_message as "override"
- Wrap #include "api_connection.h" and read_message_ implementation
in #ifdef USE_API guards
2026-03-20 21:29:42 -10:00
J. Nick Koston
20d3e7c13a
[api] Remove virtual destructor and rename read_message to read_message_
...
The virtual destructor was unnecessary since APIConnection is only
stored as unique_ptr<APIConnection>, never via a base class pointer.
Removing it eliminates the vtable entirely.
Rename read_message to read_message_ per clang-tidy naming convention
for protected methods.
2026-03-20 21:21:09 -10:00
J. Nick Koston
2067053adb
[api] Remove ProtoService base class
...
ProtoService was an abstract interface with 6 pure virtual methods,
but APIConnection was the only concrete implementation. Move all
functionality directly into APIConnection and remove the unnecessary
virtual dispatch and vtable overhead.
2026-03-20 21:14:45 -10:00
J. Nick Koston
391ad05d45
[api] Devirtualize API command dispatch
...
Move read_message() from APIServerConnectionBase into APIConnection
and drop the virtual keyword from all 64 on_* handler declarations.
Since APIConnection is final and the only subclass, the virtual
dispatch was unnecessary. With read_message and the on_* handlers
in the same class, the compiler can devirtualize the calls and
inline small handlers directly into the switch cases.
2026-03-20 20:58:54 -10:00
J. Nick Koston
05d285ba86
[api] Fix heap-buffer-overflow in protobuf message dump for StringRef ( #14721 )
CI / Create common environment (push) Has been cancelled
CI / Check pylint (push) Has been cancelled
CI / Run script/ci-custom (push) Has been cancelled
CI / Run pytest (macOS-latest, 3.11) (push) Has been cancelled
CI / Run pytest (macOS-latest, 3.14) (push) Has been cancelled
CI / Run pytest (ubuntu-latest, 3.11) (push) Has been cancelled
CI / Run pytest (ubuntu-latest, 3.13) (push) Has been cancelled
CI / Run pytest (ubuntu-latest, 3.14) (push) Has been cancelled
CI / Run pytest (windows-latest, 3.11) (push) Has been cancelled
CI / Run pytest (windows-latest, 3.14) (push) Has been cancelled
CI / Determine which jobs to run (push) Has been cancelled
CI / Run integration tests (push) Has been cancelled
CI / Run C++ unit tests (push) Has been cancelled
CI / Run script/clang-tidy for ESP32 IDF (push) Has been cancelled
CI / Run script/clang-tidy for ESP8266 (push) Has been cancelled
CI / Run script/clang-tidy for ZEPHYR (push) Has been cancelled
CI / Run script/clang-tidy for ESP32 Arduino (push) Has been cancelled
CI / Run script/clang-tidy for ESP32 Arduino 1/4 (push) Has been cancelled
CI / Run script/clang-tidy for ESP32 Arduino 2/4 (push) Has been cancelled
CI / Run script/clang-tidy for ESP32 Arduino 3/4 (push) Has been cancelled
CI / Run script/clang-tidy for ESP32 Arduino 4/4 (push) Has been cancelled
CI / Test components batch (${{ matrix.components }}) (push) Has been cancelled
CI / pre-commit.ci lite (push) Has been cancelled
CI / Build target branch for memory impact (push) Has been cancelled
CI / Build PR branch for memory impact (push) Has been cancelled
CI / Comment memory impact (push) Has been cancelled
CI / CI Status (push) Has been cancelled
CI for docker images / Build docker containers (docker, ubuntu-24.04) (push) Has been cancelled
CI for docker images / Build docker containers (docker, ubuntu-24.04-arm) (push) Has been cancelled
CI for docker images / Build docker containers (ha-addon, ubuntu-24.04) (push) Has been cancelled
CI for docker images / Build docker containers (ha-addon, ubuntu-24.04-arm) (push) Has been cancelled
Stale / stale (push) Has been cancelled
Lock closed issues and PRs / lock (push) Has been cancelled
Publish Release / Initialize build (push) Has been cancelled
Publish Release / Build and publish to PyPi (push) Has been cancelled
Publish Release / Build ESPHome amd64 (push) Has been cancelled
Publish Release / Build ESPHome arm64 (push) Has been cancelled
Publish Release / Publish ESPHome docker to dockerhub (push) Has been cancelled
Publish Release / Publish ESPHome docker to ghcr (push) Has been cancelled
Publish Release / Publish ESPHome ha-addon to dockerhub (push) Has been cancelled
Publish Release / Publish ESPHome ha-addon to ghcr (push) Has been cancelled
Publish Release / deploy-ha-addon-repo (push) Has been cancelled
Publish Release / deploy-esphome-schema (push) Has been cancelled
Publish Release / version-notifier (push) Has been cancelled
Synchronise Device Classes from Home Assistant / Sync Device Classes (push) Has been cancelled
2026-03-12 07:16:53 -10:00
J. Nick Koston
6e468936ec
[api] Inline ProtoVarInt::parse fast path and return consumed in struct ( #14638 )
...
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com >
2026-03-10 09:10:55 -10:00
J. Nick Koston
be6c3c52ac
[api] Add force proto field option to skip zero checks on hot path ( #14610 )
...
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com >
2026-03-07 18:59:13 -10:00
J. Nick Koston
77f2c371b2
[api] Single-pass protobuf encode for BLE proxy advertisements ( #14575 )
2026-03-07 07:26:34 -10:00
J. Nick Koston
42dbb51022
[api] Devirtualize protobuf encode/calculate_size ( #14449 )
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
2026-03-06 19:03:54 +00:00
J. Nick Koston
f68a3ed15d
[api] Remove virtual destructor from ProtoMessage ( #14393 )
2026-03-01 18:09:00 -10:00
J. Nick Koston
8bb577de64
[api] Split ProtoVarInt::parse into 32-bit and 64-bit phases ( #14039 )
2026-02-25 12:23:13 -06:00
J. Nick Koston
f77da803c9
[api] Write protobuf encode output to pre-sized buffer directly ( #14018 )
2026-02-20 21:39:18 -06:00
J. Nick Koston
6c6da8a3cd
[api] Skip class generation for empty SOURCE_CLIENT protobuf messages ( #13880 )
2026-02-09 18:45:24 +00:00
J. Nick Koston
c658d7b57f
[api] Merge auth check into base read_message, eliminate APIServerConnection ( #13873 )
2026-02-09 12:02:02 -06:00
J. Nick Koston
3cde3daceb
[api] Collapse APIServerConnection intermediary layer ( #13872 )
2026-02-09 08:45:33 -06:00
J. Nick Koston
140ec0639c
[api] Elide empty message construction in protobuf dispatch ( #13871 )
2026-02-09 03:24:45 -06:00
J. Nick Koston
55ef8393af
[api] Remove is_single parameter and fix batch buffer preparation ( #13773 )
...
CI / Create common environment (push) Has been cancelled
CI / Check pylint (push) Has been cancelled
CI / Run script/ci-custom (push) Has been cancelled
CI / Run pytest (macOS-latest, 3.11) (push) Has been cancelled
CI / Run pytest (ubuntu-latest, 3.11) (push) Has been cancelled
CI / Run pytest (ubuntu-latest, 3.13) (push) Has been cancelled
CI / Run pytest (windows-latest, 3.11) (push) Has been cancelled
CI / Determine which jobs to run (push) Has been cancelled
CI / Run integration tests (push) Has been cancelled
CI / Run C++ unit tests (push) Has been cancelled
CI / Run script/clang-tidy for ESP32 IDF (push) Has been cancelled
CI / Run script/clang-tidy for ESP8266 (push) Has been cancelled
CI / Run script/clang-tidy for ZEPHYR (push) Has been cancelled
CI / Run script/clang-tidy for ESP32 Arduino (push) Has been cancelled
CI / Run script/clang-tidy for ESP32 Arduino 1/4 (push) Has been cancelled
CI / Run script/clang-tidy for ESP32 Arduino 2/4 (push) Has been cancelled
CI / Run script/clang-tidy for ESP32 Arduino 3/4 (push) Has been cancelled
CI / Run script/clang-tidy for ESP32 Arduino 4/4 (push) Has been cancelled
CI / Test components batch (${{ matrix.components }}) (push) Has been cancelled
CI / pre-commit.ci lite (push) Has been cancelled
CI / Build target branch for memory impact (push) Has been cancelled
CI / Build PR branch for memory impact (push) Has been cancelled
CI / Comment memory impact (push) Has been cancelled
CI / CI Status (push) Has been cancelled
CodeQL Advanced / Analyze (python) (push) Has been cancelled
Stale / stale (push) Has been cancelled
Lock closed issues and PRs / lock (push) Has been cancelled
Publish Release / Initialize build (push) Has been cancelled
Publish Release / Build and publish to PyPi (push) Has been cancelled
Publish Release / Build ESPHome amd64 (push) Has been cancelled
Publish Release / Build ESPHome arm64 (push) Has been cancelled
Publish Release / Publish ESPHome docker to dockerhub (push) Has been cancelled
Publish Release / Publish ESPHome docker to ghcr (push) Has been cancelled
Publish Release / Publish ESPHome ha-addon to dockerhub (push) Has been cancelled
Publish Release / Publish ESPHome ha-addon to ghcr (push) Has been cancelled
Publish Release / deploy-ha-addon-repo (push) Has been cancelled
Publish Release / deploy-esphome-schema (push) Has been cancelled
Publish Release / version-notifier (push) Has been cancelled
Synchronise Device Classes from Home Assistant / Sync Device Classes (push) Has been cancelled
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
2026-02-05 15:19:03 +01:00
dependabot[bot]
4d05cd3059
Bump ruff from 0.14.14 to 0.15.0 ( #13752 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: J. Nick Koston <nick@home-assistant.io >
2026-02-04 09:24:05 +00:00
J. Nick Koston
8d0ce49eb4
[api] Eliminate intermediate buffers in protobuf dump helpers ( #13742 )
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
2026-02-03 16:34:15 +01:00
J. Nick Koston
7fed9144a6
[api] Use stack buffer for VERY_VERBOSE proto message dumps ( #13176 )
2026-01-13 08:04:48 -10:00
J. Nick Koston
7ea6bcef88
[api] Use stack buffer for bytes field dumping in proto message logs ( #13162 )
2026-01-12 07:37:58 -10:00
J. Nick Koston
912f94d1e8
[api] Use StringRef for HomeassistantServiceMap.value to eliminate heap allocations ( #13154 )
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
2026-01-11 17:54:06 -10:00
Keith Burzinski
f2eb61a767
[api] Proto code generator changes for #12985 ( #13100 )
...
Co-authored-by: J. Nick Koston <nick@koston.org >
2026-01-10 15:43:27 -10:00
J. Nick Koston
546cdbde0d
[api] Simplify string handling by removing bifurcated client/server storage ( #12822 )
2026-01-07 08:23:28 -10:00
J. Nick Koston
2a5be725c8
[api] Enable zero-copy bytes SOURCE_BOTH messages ( #12816 )
2026-01-02 19:50:30 -10:00
J. Nick Koston
e7001c5eea
[api] Auto-generate zero-copy pointer access for incoming API bytes fields ( #12654 )
2026-01-02 14:05:37 -10:00
J. Nick Koston
6d4f4d8d23
[api] Auto-generate StringRef for incoming API string fields ( #12648 )
2026-01-02 08:17:05 -10:00
J. Nick Koston
b47b7d43fd
[api] Remove unused force parameter from encode_message ( #12551 )
2025-12-18 09:06:16 -07:00
J. Nick Koston
fb82362e9c
[api] Eliminate rx_buf heap churn and release buffers after initial sync ( #12133 )
2025-11-28 12:13:29 -06:00
Jonathan Swoboda
61cef0a75c
[api] Fix format warnings in dump ( #11999 )
2025-11-19 12:58:47 -05:00
J. Nick Koston
42833c85f5
[climate] Replace std::vector<std::string> with const char* for custom fan modes and presets ( #11621 )
2025-11-02 23:16:39 -06:00
J. Nick Koston
f3634edc22
[select] Store options in flash to reduce RAM usage ( #11514 )
2025-10-29 15:28:16 +13:00
J. Nick Koston
fdecda3d65
[light] Use bitmask instead of std::set for color modes ( #11348 )
2025-10-20 07:48:14 +13:00
J. Nick Koston
6943b1d985
[api] Use FixedVector for ExecuteServiceRequest/Argument arrays to eliminate reallocations ( #11270 )
2025-10-16 16:22:08 +13:00
J. Nick Koston
8a15c18066
[bluetooth_proxy] Use FixedVector for GATT characteristics and descriptors ( #11214 )
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
2025-10-14 16:05:13 +13:00
J. Nick Koston
adfacdf1b7
[api] Consolidate authentication checks to reduce function call overhead ( #10852 )
2025-09-23 19:43:55 -05:00
J. Nick Koston
d0d7abb542
Implement zero-copy for strings in base API calls ( #10851 )
2025-09-23 16:15:28 -05:00
J. Nick Koston
2f8a4d0caa
[api] Implement zero-copy API for bluetooth_proxy writes ( #10840 )
2025-09-23 13:48:57 -05:00
Jesse Hills
9ea3643b74
[core] os.path -> Path ( #10654 )
...
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Co-authored-by: J. Nick Koston <nick@koston.org >
Co-authored-by: J. Nick Koston <nick@home-assistant.io >
2025-09-19 12:59:48 +00:00
Keith Burzinski
9c201afe76
[api_protobuf.py] Use type appropriate for estimated_size ( #10797 )
2025-09-18 20:55:45 -05:00
Keith Burzinski
adcba4fd9a
[api_protobuf.py] Use type based on size/length ( #10696 )
2025-09-13 17:02:04 -05:00
J. Nick Koston
23c6650902
[api] Fix VERY_VERBOSE logging compilation error with bool arrays ( #10539 )
2025-09-04 08:07:13 +12:00
J. Nick Koston
761c6c6685
[api] Mark protobuf message classes as final to enable compiler optimizations ( #10276 )
2025-08-18 15:55:30 -05:00
J. Nick Koston
42aee53dde
[bluetooth_proxy] Replace dynamic vector with fixed array for BLE advertisements ( #10174 )
2025-08-11 15:47:46 -05:00
J. Nick Koston
00d9baed11
[bluetooth_proxy] Eliminate heap allocations in connection state reporting ( #10010 )
2025-08-01 20:26:00 -10:00
J. Nick Koston
f13e742bd5
[ruff] Enable RET and fix all violations ( #9929 )
2025-08-01 02:10:56 +00:00
J. Nick Koston
28b277c1c4
[bluetooth_proxy] Optimize UUID transmission with efficient short_uuid field ( #9995 )
2025-07-31 16:20:53 -05:00
J. Nick Koston
76d33308d9
[api] Eliminate heap allocations when populating repeated fields from containers ( #9948 )
2025-07-30 10:41:37 +12:00
J. Nick Koston
2c9987869e
[api] Align ProtoSize API design with ProtoWriteBuffer pattern ( #9920 )
2025-07-29 10:28:32 +12:00
