Mirrors_Framework/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-05-27 03:36:19 +08:00
Code Issues Actions 11 Packages Projects Releases Wiki Activity

[inkbird_ibsth1_mini][speaker][speaker_source] Fix performance-unnecessary-copy-initialization (#16101)

Browse Source
This commit is contained in:
Jonathan Swoboda
2026-04-28 20:56:03 -04:00
committed by GitHub
parent 0b5835284a
commit 77b76ac48a
3 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
esphome/components/inkbird_ibsth1_mini/inkbird_ibsth1_mini.cpp
+2 -2
View File
@@ -41,12 +41,12 @@ bool InkbirdIbstH1Mini::parse_device(const esp32_ble_tracker::ESPBTDevice &devic
ESP_LOGVV(TAG, "parse_device(): service_data is expected to be empty"); ESP_LOGVV(TAG, "parse_device(): service_data is expected to be empty");
return false; return false;
} }
auto mnf_datas = device.get_manufacturer_datas(); const auto &mnf_datas = device.get_manufacturer_datas();
if (mnf_datas.size() != 1) { if (mnf_datas.size() != 1) {
ESP_LOGVV(TAG, "parse_device(): manufacturer_datas is expected to have a single element"); ESP_LOGVV(TAG, "parse_device(): manufacturer_datas is expected to have a single element");
return false; return false;
} }
auto mnf_data = mnf_datas[0]; const auto &mnf_data = mnf_datas[0];
if (mnf_data.uuid.get_uuid().len != ESP_UUID_LEN_16) { if (mnf_data.uuid.get_uuid().len != ESP_UUID_LEN_16) {
ESP_LOGVV(TAG, "parse_device(): manufacturer data element is expected to have uuid of length 16"); ESP_LOGVV(TAG, "parse_device(): manufacturer data element is expected to have uuid of length 16");
return false; return false;
esphome/components/speaker/media_player/speaker_media_player.cpp
+1 -1
View File
@@ -502,7 +502,7 @@ void SpeakerMediaPlayer::control(const media_player::MediaPlayerCall &call) {
media_command.announce = false; media_command.announce = false;
} }
auto media_url = call.get_media_url(); const auto &media_url = call.get_media_url();
if (media_url.has_value()) { if (media_url.has_value()) {
media_command.url = media_command.url =
new std::string(*media_url); // Must be manually deleted after receiving media_command from a queue new std::string(*media_url); // Must be manually deleted after receiving media_command from a queue
esphome/components/speaker_source/speaker_source_media_player.cpp
+1 -1
View File
@@ -698,7 +698,7 @@ void SpeakerSourceMediaPlayer::control(const media_player::MediaPlayerCall &call
} }
} }
auto media_url = call.get_media_url(); const auto &media_url = call.get_media_url();
if (media_url.has_value()) { if (media_url.has_value()) {
auto command = call.get_command(); auto command = call.get_command();
bool enqueue = command.has_value() && command.value() == media_player::MEDIA_PLAYER_COMMAND_ENQUEUE; bool enqueue = command.has_value() && command.value() == media_player::MEDIA_PLAYER_COMMAND_ENQUEUE;