Mirrors_Framework/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-06-01 01:19:45 +08:00
Code Issues Actions 6 Packages Projects Releases Wiki Activity

[sensirion_common] Use SmallBufferWithHeapFallback helper (#14270)

Browse Source 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: J. Nick Koston <nick@home-assistant.io>
This commit is contained in:
Big Mike
2026-03-11 13:00:42 -05:00
committed by GitHub
parent 4e16f270a3
commit 3d4ebe74ce
1 changed files with 10 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
esphome/components/sensirion_common/i2c_sensirion.cpp
+10 -9
View File
@@ -12,24 +12,25 @@ static const char *const TAG = "sensirion_i2c";
static const size_t BUFFER_STACK_SIZE = 16; static const size_t BUFFER_STACK_SIZE = 16;
bool SensirionI2CDevice::read_data(uint16_t *data, const uint8_t len) { bool SensirionI2CDevice::read_data(uint16_t *data, const uint8_t len) {
const size_t num_bytes = len * 3; const size_t required_buffer_len = len * 3;
uint8_t buf[num_bytes]; SmallBufferWithHeapFallback<BUFFER_STACK_SIZE> buffer(required_buffer_len);
uint8_t *temp = buffer.get();
this->last_error_ = this->read(buf, num_bytes); this->last_error_ = this->read(temp, required_buffer_len);
if (this->last_error_ != i2c::ERROR_OK) { if (this->last_error_ != i2c::ERROR_OK) {
return false; return false;
} }
for (uint8_t i = 0; i < len; i++) { for (size_t i = 0; i < len; i++) {
const uint8_t j = 3 * i; const size_t j = i * 3;
// Use MSB first since Sensirion devices use CRC-8 with MSB first // Use MSB first since Sensirion devices use CRC-8 with MSB first
uint8_t crc = crc8(&buf[j], 2, 0xFF, CRC_POLYNOMIAL, true); uint8_t crc = crc8(&temp[j], 2, 0xFF, CRC_POLYNOMIAL, true);
if (crc != buf[j + 2]) { if (crc != temp[j + 2]) {
ESP_LOGE(TAG, "CRC invalid @ %d! 0x%02X != 0x%02X", i, buf[j + 2], crc); ESP_LOGE(TAG, "CRC invalid @ %zu! 0x%02X != 0x%02X", i, temp[j + 2], crc);
this->last_error_ = i2c::ERROR_CRC; this->last_error_ = i2c::ERROR_CRC;
return false; return false;
} }
data[i] = encode_uint16(buf[j], buf[j + 1]); data[i] = encode_uint16(temp[j], temp[j + 1]);
} }
return true; return true;
} }