Mirrors_Framework/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-06-02 11:08:06 +08:00
Code Issues Actions 7 Packages Projects Releases Wiki Activity

[analog_threshold] Fix oscillation when using invert filter (#12251)

Browse Source 
Co-authored-by: Claude <noreply@anthropic.com>
This commit is contained in:
Jonathan Swoboda
2025-12-02 13:40:46 -05:00
committed by GitHub
parent a6a6f482e6
commit 2f75962b19
2 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
esphome/components/analog_threshold/analog_threshold_binary_sensor.cpp
+7 -4
View File
@@ -12,10 +12,11 @@ void AnalogThresholdBinarySensor::setup() {
// TRUE state is defined to be when sensor is >= threshold // TRUE state is defined to be when sensor is >= threshold
// so when undefined sensor value initialize to FALSE // so when undefined sensor value initialize to FALSE
if (std::isnan(sensor_value)) { if (std::isnan(sensor_value)) {
this->raw_state_ = false;
this->publish_initial_state(false); this->publish_initial_state(false);
} else { } else {
this->publish_initial_state(sensor_value >= this->raw_state_ = sensor_value >= (this->lower_threshold_.value() + this->upper_threshold_.value()) / 2.0f;
(this->lower_threshold_.value() + this->upper_threshold_.value()) / 2.0f); this->publish_initial_state(this->raw_state_);
} }
} }
@@ -25,8 +26,10 @@ void AnalogThresholdBinarySensor::set_sensor(sensor::Sensor *analog_sensor) {
this->sensor_->add_on_state_callback([this](float sensor_value) { this->sensor_->add_on_state_callback([this](float sensor_value) {
// if there is an invalid sensor reading, ignore the change and keep the current state // if there is an invalid sensor reading, ignore the change and keep the current state
if (!std::isnan(sensor_value)) { if (!std::isnan(sensor_value)) {
this->publish_state(sensor_value >= // Use raw_state_ for hysteresis logic, not this->state which is post-filter
(this->state ? this->lower_threshold_.value() : this->upper_threshold_.value())); this->raw_state_ =
sensor_value >= (this->raw_state_ ? this->lower_threshold_.value() : this->upper_threshold_.value());
this->publish_state(this->raw_state_);
} }
}); });
} }
esphome/components/analog_threshold/analog_threshold_binary_sensor.h
+1
View File
@@ -20,6 +20,7 @@ class AnalogThresholdBinarySensor : public Component, public binary_sensor::Bina
sensor::Sensor *sensor_{nullptr}; sensor::Sensor *sensor_{nullptr};
TemplatableValue<float> upper_threshold_{}; TemplatableValue<float> upper_threshold_{};
TemplatableValue<float> lower_threshold_{}; TemplatableValue<float> lower_threshold_{};
bool raw_state_{false}; // Pre-filter state for hysteresis logic
}; };
} // namespace analog_threshold } // namespace analog_threshold