Mirrors_Framework/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-05-30 07:16:11 +08:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

[pipsolar] Guard handle_qmod_ against empty message (#16085)

Browse Source
This commit is contained in:
Jonathan Swoboda
2026-04-28 16:29:09 -04:00
committed by GitHub
parent c8dffcc9b8
commit 1f4136e76f
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
esphome/components/pipsolar/pipsolar.cpp
+7 -3
View File
@@ -433,13 +433,17 @@ void Pipsolar::handle_qpigs_(const char *message) {
} }
void Pipsolar::handle_qmod_(const char *message) { void Pipsolar::handle_qmod_(const char *message) {
std::string mode;
char device_mode = char(message[1]);
if (this->last_qmod_) { if (this->last_qmod_) {
this->last_qmod_->publish_state(message); this->last_qmod_->publish_state(message);
} }
// QMOD response is "(M" where M is the device-mode character. Bail out if the
// message is shorter than 2 chars (e.g. empty error response from
// handle_poll_error_) — reading message[1] would otherwise be out of bounds.
if (message[0] == '\0' || message[1] == '\0')
return;
if (this->device_mode_) { if (this->device_mode_) {
mode = device_mode; std::string mode;
mode = char(message[1]);
this->device_mode_->publish_state(mode); this->device_mode_->publish_state(mode);
} }
} }