[api] Fix heap-buffer-overflow in protobuf message dump for StringRef (#14721)

2026-05-26 11:17:00 +08:00 · 2026-03-12 07:16:53 -10:00
parent 186ca4e458
commit 05d285ba86
2 changed files with 3 additions and 3 deletions
@@ -642,7 +642,7 @@ class StringType(TypeInfo):
        # For SOURCE_BOTH, check if StringRef is set (sending) or use string (received)
        return (
            f"if (!this->{self.field_name}_ref_.empty()) {{"
-            f'  out.append("\'").append(this->{self.field_name}_ref_.c_str()).append("\'");'
+            f'  out.append("\'").append(this->{self.field_name}_ref_.c_str(), this->{self.field_name}_ref_.size()).append("\'");'
            f"}} else {{"
            f'  out.append("\'").append(this->{self.field_name}).append("\'");'
            f"}}"
@@ -2705,7 +2705,7 @@ namespace esphome::api {
 static inline void append_quoted_string(DumpBuffer &out, const StringRef &ref) {
  out.append("'");
  if (!ref.empty()) {
-    out.append(ref.c_str());
+    out.append(ref.c_str(), ref.size());
  }
  out.append("'");
 }