From dbe7af07be4a5a4dbd64bd982f49c8ade81e802f Mon Sep 17 00:00:00 2001 From: Peter Barker Date: Thu, 27 Aug 2026 20:57:47 +1000 Subject: [PATCH] AP_Camera: use the standard PARAMETER_CONVERSION annotation The RunCam annotation had text in front of the PARAMETER_CONVERSION token, so a grep anchored at the start of the comment did not find it. Both annotations also described the release in prose rather than in the standard form. The RunCam date was wrong as well. It read Nov-2024, but the conversion arrived in 399f9f6f98 "AP_Camera: RunCam camera backend", which was authored Apr-2024 and merged Dec-2024 - the annotations on this branch use the date the conversion landed in master, so it is Dec-2024. Established by content rather than by date: convert_runcam_params() is absent from Copter-4.6.0 and present in Copter-4.7.0; the CAM_TRIGG_TYPE to CAM1_TYPE conversion is absent from Copter-4.3.0 and present in Copter-4.4.0. No functional change. --- libraries/AP_Camera/AP_Camera.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libraries/AP_Camera/AP_Camera.cpp b/libraries/AP_Camera/AP_Camera.cpp index 230bd525d5b..f25d71fe3e3 100644 --- a/libraries/AP_Camera/AP_Camera.cpp +++ b/libraries/AP_Camera/AP_Camera.cpp @@ -1029,7 +1029,7 @@ void AP_Camera::convert_runcam_params() return; } - // RunCam PARAMETER_CONVERSION - Added: Nov-2024 ahead of 4.7 release + // PARAMETER_CONVERSION - Added: Dec-2024 for ArduPilot-4.7 // Since slot 1 is essentially used by the trigger type, we will use slot 2 for runcam int8_t rc_type = 0; @@ -1074,7 +1074,7 @@ void AP_Camera::convert_params() return; } - // PARAMETER_CONVERSION - Added: Feb-2023 ahead of 4.4 release + // PARAMETER_CONVERSION - Added: Feb-2023 for ArduPilot-4.4 // convert CAM_TRIGG_TYPE to CAM1_TYPE int8_t cam_trigg_type = 0;