From ca91edbbebb19161e68da01a3d6547cd2ecb508c Mon Sep 17 00:00:00 2001 From: Andrew Tridgell Date: Wed, 13 Dec 2017 12:06:11 +1100 Subject: [PATCH] AP_Beacon: removed create() method for objects See discussion here: https://github.com/ArduPilot/ardupilot/issues/7331 we were getting some uninitialised variables. While it only showed up in AP_SbusOut, it means we can't be sure it won't happen on other objects, so safest to remove the approach Thanks to assistance from Lucas, Peter and Francisco --- .../examples/AP_Marvelmind_test/AP_Marvelmind_test.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libraries/AP_Beacon/examples/AP_Marvelmind_test/AP_Marvelmind_test.cpp b/libraries/AP_Beacon/examples/AP_Marvelmind_test/AP_Marvelmind_test.cpp index 646b0f6dba2..051a7f756a5 100644 --- a/libraries/AP_Beacon/examples/AP_Marvelmind_test/AP_Marvelmind_test.cpp +++ b/libraries/AP_Beacon/examples/AP_Marvelmind_test/AP_Marvelmind_test.cpp @@ -16,7 +16,7 @@ void set_object_value_and_report(const void *object_pointer, const char *name, float value); const AP_HAL::HAL& hal = AP_HAL::get_HAL(); -static AP_SerialManager serial_manager = AP_SerialManager::create(); +static AP_SerialManager serial_manager; AP_Beacon beacon{serial_manager}; // try to set the object value but provide diagnostic if it failed