From 5bb5f442e1e306644b0a31df04c68c7da259041e Mon Sep 17 00:00:00 2001 From: Iampete1 Date: Fri, 3 May 2024 19:22:25 +0100 Subject: [PATCH] AP_Scripting: ignore lua-language-server-errors --- .../Aerobatics/FixedWing/RateBased/sport_aerobatics.lua | 4 ++++ .../applets/Aerobatics/FixedWing/plane_aerobatics.lua | 7 +++++++ libraries/AP_Scripting/applets/BattEstimate.lua | 3 +++ libraries/AP_Scripting/applets/Heli_IM_COL_Tune.lua | 1 + libraries/AP_Scripting/applets/Heli_idle_control.lua | 2 ++ libraries/AP_Scripting/applets/MissionSelector.lua | 2 ++ libraries/AP_Scripting/applets/RockBlock.lua | 4 +++- libraries/AP_Scripting/applets/Script_Controller.lua | 2 ++ libraries/AP_Scripting/applets/SmartAudio.lua | 3 +++ libraries/AP_Scripting/applets/VTOL-quicktune.lua | 3 +++ libraries/AP_Scripting/applets/copter-deadreckon-home.lua | 3 +++ .../AP_Scripting/applets/forward_flight_motor_shutdown.lua | 2 ++ libraries/AP_Scripting/applets/leds_on_a_switch.lua | 2 ++ libraries/AP_Scripting/applets/mount-poi.lua | 4 ++++ libraries/AP_Scripting/applets/net_webserver.lua | 4 ++++ libraries/AP_Scripting/applets/plane_package_place.lua | 1 + libraries/AP_Scripting/applets/plane_precland.lua | 2 ++ libraries/AP_Scripting/applets/plane_ship_landing.lua | 4 ++++ libraries/AP_Scripting/applets/revert_param.lua | 4 ++++ libraries/AP_Scripting/applets/rover-quicktune.lua | 3 +++ libraries/AP_Scripting/applets/winch-control.lua | 3 +++ libraries/AP_Scripting/drivers/BattMon_ANX.lua | 3 +++ libraries/AP_Scripting/drivers/EFI_HFE.lua | 5 +++++ libraries/AP_Scripting/drivers/EFI_Halo6000.lua | 5 +++++ libraries/AP_Scripting/drivers/EFI_SkyPower.lua | 6 ++++++ libraries/AP_Scripting/drivers/Generator_SVFFI.lua | 3 +++ libraries/AP_Scripting/drivers/Hobbywing_DataLink.lua | 2 ++ .../AP_Scripting/drivers/TOFSense-M/TOFSense-M_CAN.lua | 3 +++ .../AP_Scripting/drivers/TOFSense-M/TOFSense-M_Serial.lua | 4 ++++ libraries/AP_Scripting/drivers/mount-djirs2-driver.lua | 3 +++ libraries/AP_Scripting/drivers/mount-viewpro-driver.lua | 3 +++ libraries/AP_Scripting/examples/AHRS_switch.lua | 2 ++ libraries/AP_Scripting/examples/CAN_MiniCheetah_drive.lua | 2 ++ libraries/AP_Scripting/examples/CAN_logger.lua | 2 ++ libraries/AP_Scripting/examples/EFI_tester.lua | 4 ++++ libraries/AP_Scripting/examples/MAVLinkHL.lua | 7 ++++++- libraries/AP_Scripting/examples/RC_override.lua | 3 +++ .../AP_Scripting/examples/SN-GCJA5-particle-sensor.lua | 3 +++ libraries/AP_Scripting/examples/Serial_Dump.lua | 4 ++++ libraries/AP_Scripting/examples/UART_log.lua | 2 +- .../examples/ahrs-set-home-to-vehicle-location.lua | 2 ++ .../AP_Scripting/examples/ahrs-source-gps-optflow.lua | 2 ++ .../examples/ahrs-source-gps-wheelencoders.lua | 2 ++ libraries/AP_Scripting/examples/ahrs-source.lua | 3 +++ libraries/AP_Scripting/examples/analog_input_and_GPIO.lua | 2 ++ .../AP_Scripting/examples/benewakeH30_can_rangefinder.lua | 2 ++ libraries/AP_Scripting/examples/camera-test.lua | 2 ++ libraries/AP_Scripting/examples/cell_balance_check.lua | 2 ++ libraries/AP_Scripting/examples/copter-fast-descent.lua | 4 ++++ libraries/AP_Scripting/examples/copter-nav-script-time.lua | 3 +++ libraries/AP_Scripting/examples/frsky_wp.lua | 1 + libraries/AP_Scripting/examples/fw_vtol_failsafe.lua | 2 ++ libraries/AP_Scripting/examples/gen_control.lua | 2 ++ libraries/AP_Scripting/examples/i2c_scan.lua | 3 +++ libraries/AP_Scripting/examples/mission-edit-demo.lua | 3 +++ libraries/AP_Scripting/examples/mission-load.lua | 2 +- libraries/AP_Scripting/examples/mission-save.lua | 2 ++ libraries/AP_Scripting/examples/mount-test.lua | 2 ++ libraries/AP_Scripting/examples/net_test.lua | 2 ++ libraries/AP_Scripting/examples/plane-doublets.lua | 3 +++ libraries/AP_Scripting/examples/plane-wind-fs.lua | 3 +++ libraries/AP_Scripting/examples/plane_guided_follow.lua | 2 ++ libraries/AP_Scripting/examples/quadruped.lua | 2 ++ .../AP_Scripting/examples/rangefinder_quality_test.lua | 3 +++ libraries/AP_Scripting/examples/rover-MinFixType.lua | 2 ++ libraries/AP_Scripting/examples/rover-SaveTurns.lua | 3 +++ libraries/AP_Scripting/examples/rover-TerrainDetector.lua | 2 ++ libraries/AP_Scripting/examples/serial_test.lua | 2 ++ libraries/AP_Scripting/examples/servo_set_get.lua | 2 +- .../AP_Scripting/examples/set_target_posvel_circle.lua | 3 +++ libraries/AP_Scripting/examples/ship_vel_match.lua | 2 ++ .../AP_Scripting/examples/sub_test_synthetic_seafloor.lua | 2 ++ libraries/AP_Scripting/examples/test_load.lua | 1 + libraries/AP_Scripting/examples/wrap32_test.lua | 2 ++ libraries/AP_Scripting/tests/math.lua | 3 +++ libraries/AP_Scripting/tests/mavlink_test.lua | 3 +++ libraries/AP_Scripting/tests/strings.lua | 5 +++++ 77 files changed, 212 insertions(+), 5 deletions(-) diff --git a/libraries/AP_Scripting/applets/Aerobatics/FixedWing/RateBased/sport_aerobatics.lua b/libraries/AP_Scripting/applets/Aerobatics/FixedWing/RateBased/sport_aerobatics.lua index c0b674e5ae8..a6100ad6ba0 100644 --- a/libraries/AP_Scripting/applets/Aerobatics/FixedWing/RateBased/sport_aerobatics.lua +++ b/libraries/AP_Scripting/applets/Aerobatics/FixedWing/RateBased/sport_aerobatics.lua @@ -6,6 +6,10 @@ cmd = 4: knife edge at any angle, arg1 = roll angle to hold, arg2 = duration cmd = 5: pause, holding heading and alt to allow stabilization after a move, arg1 = duration in seconds ]]-- -- luacheck: only 0 +---@diagnostic disable: param-type-mismatch +---@diagnostic disable: need-check-nil +---@diagnostic disable: cast-local-type +---@diagnostic disable: undefined-global DO_JUMP = 177 k_throttle = 70 diff --git a/libraries/AP_Scripting/applets/Aerobatics/FixedWing/plane_aerobatics.lua b/libraries/AP_Scripting/applets/Aerobatics/FixedWing/plane_aerobatics.lua index 50da4616dd9..f98be87a34e 100644 --- a/libraries/AP_Scripting/applets/Aerobatics/FixedWing/plane_aerobatics.lua +++ b/libraries/AP_Scripting/applets/Aerobatics/FixedWing/plane_aerobatics.lua @@ -5,6 +5,13 @@ assistance from Paul Riseborough, testing by Henry Wurzburg ]]-- -- luacheck: ignore 212 (Unused argument) +---@diagnostic disable: param-type-mismatch +---@diagnostic disable: undefined-field +---@diagnostic disable: missing-parameter +---@diagnostic disable: cast-local-type +---@diagnostic disable: need-check-nil +---@diagnostic disable: undefined-global +---@diagnostic disable: inject-field -- setup param block for aerobatics, reserving 35 params beginning with AERO_ local PARAM_TABLE_KEY = 70 diff --git a/libraries/AP_Scripting/applets/BattEstimate.lua b/libraries/AP_Scripting/applets/BattEstimate.lua index 1221a4b74db..497e89fa53a 100644 --- a/libraries/AP_Scripting/applets/BattEstimate.lua +++ b/libraries/AP_Scripting/applets/BattEstimate.lua @@ -4,6 +4,9 @@ See Tools/scripts/battery_fit.py for a tool to calculate the coefficients from a log --]] +---@diagnostic disable: param-type-mismatch +---@diagnostic disable: cast-local-type + local MAV_SEVERITY = {EMERGENCY=0, ALERT=1, CRITICAL=2, ERROR=3, WARNING=4, NOTICE=5, INFO=6, DEBUG=7} local PARAM_TABLE_KEY = 14 diff --git a/libraries/AP_Scripting/applets/Heli_IM_COL_Tune.lua b/libraries/AP_Scripting/applets/Heli_IM_COL_Tune.lua index 84d2343f0e5..63f95da179b 100644 --- a/libraries/AP_Scripting/applets/Heli_IM_COL_Tune.lua +++ b/libraries/AP_Scripting/applets/Heli_IM_COL_Tune.lua @@ -5,6 +5,7 @@ -- the value of the 50% point on the curve. This can be used to set the collective position to aid with hovering -- at the midstick. -- luacheck: only 0 +---@diagnostic disable: cast-local-type -- Tested and working as of 25th Aug 2020 (Copter Dev) diff --git a/libraries/AP_Scripting/applets/Heli_idle_control.lua b/libraries/AP_Scripting/applets/Heli_idle_control.lua index 16e7de0a005..64e1a71bc8b 100644 --- a/libraries/AP_Scripting/applets/Heli_idle_control.lua +++ b/libraries/AP_Scripting/applets/Heli_idle_control.lua @@ -1,4 +1,6 @@ -- idle_control.lua: a closed loop control throttle control while on ground idle (trad-heli) +---@diagnostic disable: param-type-mismatch +---@diagnostic disable: need-check-nil local PARAM_TABLE_KEY = 73 local PARAM_TABLE_PREFIX = 'IDLE_' diff --git a/libraries/AP_Scripting/applets/MissionSelector.lua b/libraries/AP_Scripting/applets/MissionSelector.lua index b20c01835ef..53efa079fff 100644 --- a/libraries/AP_Scripting/applets/MissionSelector.lua +++ b/libraries/AP_Scripting/applets/MissionSelector.lua @@ -3,6 +3,8 @@ -- but also on the disarm to arm transition, it will load (if file exists) a file in the root named -- missionH.txt, missionM.txt, or missionH.txt corresponding to the the Mission Reset switch position of High/Mid/Low -- luacheck: only 0 +---@diagnostic disable: need-check-nil + local mission_loaded = false local rc_switch = rc:find_channel_for_option(24) --AUX FUNC sw for mission restart diff --git a/libraries/AP_Scripting/applets/RockBlock.lua b/libraries/AP_Scripting/applets/RockBlock.lua index f8e675cbb04..2c5e175b1be 100644 --- a/libraries/AP_Scripting/applets/RockBlock.lua +++ b/libraries/AP_Scripting/applets/RockBlock.lua @@ -24,12 +24,14 @@ The param SCR_VM_I_COUNT may need to be increased in some circumstances Written by Stephen Dade (stephen_dade@hotmail.com) ]]-- +---@diagnostic disable: cast-local-type + local PARAM_TABLE_KEY = 10 local PARAM_TABLE_PREFIX = "RCK_" local port = serial:find_serial(0) -if not port or baud == 0 then +if not port then gcs:send_text(0, "Rockblock: No Scripting Serial Port") return end diff --git a/libraries/AP_Scripting/applets/Script_Controller.lua b/libraries/AP_Scripting/applets/Script_Controller.lua index 6957455ae37..4fb787b0087 100644 --- a/libraries/AP_Scripting/applets/Script_Controller.lua +++ b/libraries/AP_Scripting/applets/Script_Controller.lua @@ -3,6 +3,8 @@ /1 /2 or /3 subdirectories of the scripts directory --]] -- luacheck: only 0 +---@diagnostic disable: param-type-mismatch + local THIS_SCRIPT = "Script_Controller.lua" local sel_ch = Parameter("SCR_USER6") diff --git a/libraries/AP_Scripting/applets/SmartAudio.lua b/libraries/AP_Scripting/applets/SmartAudio.lua index a5820d598e8..00a3142f08f 100644 --- a/libraries/AP_Scripting/applets/SmartAudio.lua +++ b/libraries/AP_Scripting/applets/SmartAudio.lua @@ -20,6 +20,9 @@ ---------and set to -1 for unchanged, 0 (PitMode),1,2,3, or 4 for power level (1 lowest,4 maximum) -- 3. Attach the UART's TX for the Serial port chosen above to the VTX's SmartAudio input +---@diagnostic disable: need-check-nil + + -- init local variables local startup_pwr = param:get('SCR_USER1') local scripting_rc = rc:find_channel_for_option(300) diff --git a/libraries/AP_Scripting/applets/VTOL-quicktune.lua b/libraries/AP_Scripting/applets/VTOL-quicktune.lua index 79d6af069ac..a04d5ed08eb 100644 --- a/libraries/AP_Scripting/applets/VTOL-quicktune.lua +++ b/libraries/AP_Scripting/applets/VTOL-quicktune.lua @@ -6,6 +6,9 @@ --]] +---@diagnostic disable: param-type-mismatch +---@diagnostic disable: need-check-nil +---@diagnostic disable: missing-parameter --[[ - TODO: diff --git a/libraries/AP_Scripting/applets/copter-deadreckon-home.lua b/libraries/AP_Scripting/applets/copter-deadreckon-home.lua index cb4b5cce6a8..152b752a004 100644 --- a/libraries/AP_Scripting/applets/copter-deadreckon-home.lua +++ b/libraries/AP_Scripting/applets/copter-deadreckon-home.lua @@ -56,6 +56,9 @@ -- b. SIM_WIND_SPD <-- sets wind speed in m/s -- +---@diagnostic disable: param-type-mismatch +---@diagnostic disable: cast-local-type + -- create and initialise parameters local PARAM_TABLE_KEY = 86 -- parameter table key must be used by only one script on a particular flight controller assert(param:add_table(PARAM_TABLE_KEY, "DR_", 9), 'could not add param table') diff --git a/libraries/AP_Scripting/applets/forward_flight_motor_shutdown.lua b/libraries/AP_Scripting/applets/forward_flight_motor_shutdown.lua index 50f856b4715..9c2daa97cba 100644 --- a/libraries/AP_Scripting/applets/forward_flight_motor_shutdown.lua +++ b/libraries/AP_Scripting/applets/forward_flight_motor_shutdown.lua @@ -5,6 +5,8 @@ -- slew up and down times allow to configure how fast the motors are disabled and re-enabled -- luacheck: only 0 +---@diagnostic disable: cast-local-type + -- Config diff --git a/libraries/AP_Scripting/applets/leds_on_a_switch.lua b/libraries/AP_Scripting/applets/leds_on_a_switch.lua index 9126289f340..e80f12be59d 100644 --- a/libraries/AP_Scripting/applets/leds_on_a_switch.lua +++ b/libraries/AP_Scripting/applets/leds_on_a_switch.lua @@ -1,6 +1,8 @@ -- leds_on_a_switch.lua: control led brightness with a radio switch -- +---@diagnostic disable: cast-local-type + -- constants local AuxSwitchPos = {LOW=0, MIDDLE=1, HIGH=2} local NTF_LED_BRIGHT = Parameter("NTF_LED_BRIGHT") diff --git a/libraries/AP_Scripting/applets/mount-poi.lua b/libraries/AP_Scripting/applets/mount-poi.lua index aa42620bc01..da56cfd6e8c 100644 --- a/libraries/AP_Scripting/applets/mount-poi.lua +++ b/libraries/AP_Scripting/applets/mount-poi.lua @@ -19,6 +19,10 @@ -- 10. interpolate between test_loc and prev_test_loc to find the lat, lon, alt (above sea-level) where alt-above-terrain is zero -- 11. display the POI to the user +---@diagnostic disable: param-type-mismatch +---@diagnostic disable: cast-local-type +---@diagnostic disable: missing-parameter + -- global definitions local MAV_SEVERITY = {EMERGENCY=0, ALERT=1, CRITICAL=2, ERROR=3, WARNING=4, NOTICE=5, INFO=6, DEBUG=7} local ALT_FRAME_ABSOLUTE = 0 diff --git a/libraries/AP_Scripting/applets/net_webserver.lua b/libraries/AP_Scripting/applets/net_webserver.lua index 278acd2b257..e8f7e2ad0fc 100644 --- a/libraries/AP_Scripting/applets/net_webserver.lua +++ b/libraries/AP_Scripting/applets/net_webserver.lua @@ -1,6 +1,10 @@ --[[ example script to test lua socket API --]] +---@diagnostic disable: param-type-mismatch +---@diagnostic disable: undefined-field +---@diagnostic disable: need-check-nil +---@diagnostic disable: redundant-parameter local MAV_SEVERITY = {EMERGENCY=0, ALERT=1, CRITICAL=2, ERROR=3, WARNING=4, NOTICE=5, INFO=6, DEBUG=7} diff --git a/libraries/AP_Scripting/applets/plane_package_place.lua b/libraries/AP_Scripting/applets/plane_package_place.lua index 242435fc7f3..cd690728702 100644 --- a/libraries/AP_Scripting/applets/plane_package_place.lua +++ b/libraries/AP_Scripting/applets/plane_package_place.lua @@ -2,6 +2,7 @@ support package place for quadplanes --]] -- luacheck: only 0 +---@diagnostic disable: param-type-mismatch local PARAM_TABLE_KEY = 9 diff --git a/libraries/AP_Scripting/applets/plane_precland.lua b/libraries/AP_Scripting/applets/plane_precland.lua index 9adcfdd84fb..1d5dc96cd8f 100644 --- a/libraries/AP_Scripting/applets/plane_precland.lua +++ b/libraries/AP_Scripting/applets/plane_precland.lua @@ -5,6 +5,8 @@ for development of a custom solution --]] +---@diagnostic disable: param-type-mismatch + local PARAM_TABLE_KEY = 12 local PARAM_TABLE_PREFIX = "PLND_" diff --git a/libraries/AP_Scripting/applets/plane_ship_landing.lua b/libraries/AP_Scripting/applets/plane_ship_landing.lua index 45bc9be2d42..da89c77e2f2 100644 --- a/libraries/AP_Scripting/applets/plane_ship_landing.lua +++ b/libraries/AP_Scripting/applets/plane_ship_landing.lua @@ -4,6 +4,10 @@ See this post for details: https://discuss.ardupilot.org/t/ship-landing-support --]] +---@diagnostic disable: param-type-mismatch +---@diagnostic disable: cast-local-type +---@diagnostic disable: need-check-nil + local MAV_SEVERITY = {EMERGENCY=0, ALERT=1, CRITICAL=2, ERROR=3, WARNING=4, NOTICE=5, INFO=6, DEBUG=7} local PARAM_TABLE_KEY = 7 diff --git a/libraries/AP_Scripting/applets/revert_param.lua b/libraries/AP_Scripting/applets/revert_param.lua index 8ea0498f47e..c92d1e5cc62 100644 --- a/libraries/AP_Scripting/applets/revert_param.lua +++ b/libraries/AP_Scripting/applets/revert_param.lua @@ -2,6 +2,10 @@ parameter reversion utility. This helps with manual tuning in-flight by giving a way to instantly revert parameters to the startup parameters --]] + +---@diagnostic disable: param-type-mismatch + + local MAV_SEVERITY = {EMERGENCY=0, ALERT=1, CRITICAL=2, ERROR=3, WARNING=4, NOTICE=5, INFO=6, DEBUG=7} local PARAM_TABLE_KEY = 31 diff --git a/libraries/AP_Scripting/applets/rover-quicktune.lua b/libraries/AP_Scripting/applets/rover-quicktune.lua index 0d09c6f5f92..7a05a533173 100644 --- a/libraries/AP_Scripting/applets/rover-quicktune.lua +++ b/libraries/AP_Scripting/applets/rover-quicktune.lua @@ -18,6 +18,9 @@ See the accompanying rover-quiktune.md file for instructions on how to use --]] +---@diagnostic disable: param-type-mismatch +---@diagnostic disable: need-check-nil + -- global definitions local MAV_SEVERITY = {EMERGENCY=0, ALERT=1, CRITICAL=2, ERROR=3, WARNING=4, NOTICE=5, INFO=6, DEBUG=7} diff --git a/libraries/AP_Scripting/applets/winch-control.lua b/libraries/AP_Scripting/applets/winch-control.lua index 12496f8891f..2e242df4136 100644 --- a/libraries/AP_Scripting/applets/winch-control.lua +++ b/libraries/AP_Scripting/applets/winch-control.lua @@ -10,6 +10,9 @@ -- Alternatively Mission Planner's Aux Function screen can be used in place of an actual RC switch -- +---@diagnostic disable: param-type-mismatch + + -- global definitions local MAV_SEVERITY = {EMERGENCY=0, ALERT=1, CRITICAL=2, ERROR=3, WARNING=4, NOTICE=5, INFO=6, DEBUG=7} local PARAM_TABLE_KEY = 80 diff --git a/libraries/AP_Scripting/drivers/BattMon_ANX.lua b/libraries/AP_Scripting/drivers/BattMon_ANX.lua index 80b32b924dc..d963850186f 100644 --- a/libraries/AP_Scripting/drivers/BattMon_ANX.lua +++ b/libraries/AP_Scripting/drivers/BattMon_ANX.lua @@ -2,6 +2,9 @@ device driver for ANX CAN battery monitor --]] +---@diagnostic disable: param-type-mismatch +---@diagnostic disable: missing-parameter + local MAV_SEVERITY = {EMERGENCY=0, ALERT=1, CRITICAL=2, ERROR=3, WARNING=4, NOTICE=5, INFO=6, DEBUG=7} local PARAM_TABLE_KEY = 45 diff --git a/libraries/AP_Scripting/drivers/EFI_HFE.lua b/libraries/AP_Scripting/drivers/EFI_HFE.lua index 08a28724142..0ed813159b4 100644 --- a/libraries/AP_Scripting/drivers/EFI_HFE.lua +++ b/libraries/AP_Scripting/drivers/EFI_HFE.lua @@ -2,6 +2,11 @@ EFI Scripting backend driver for HFE based on HFEDCN0191 Rev E --]] -- luacheck: only 0 +---@diagnostic disable: param-type-mismatch +---@diagnostic disable: redundant-parameter +---@diagnostic disable: undefined-field +---@diagnostic disable: missing-parameter +---@diagnostic disable: need-check-nil -- Check Script uses a miniumum firmware version diff --git a/libraries/AP_Scripting/drivers/EFI_Halo6000.lua b/libraries/AP_Scripting/drivers/EFI_Halo6000.lua index 4bb457b6f80..b353ff2d5d2 100644 --- a/libraries/AP_Scripting/drivers/EFI_Halo6000.lua +++ b/libraries/AP_Scripting/drivers/EFI_Halo6000.lua @@ -2,6 +2,11 @@ EFI Scripting backend driver for Halo6000 generator --]] +---@diagnostic disable: param-type-mismatch +---@diagnostic disable: undefined-field +---@diagnostic disable: missing-parameter +---@diagnostic disable: need-check-nil + -- Check Script uses a miniumum firmware version local SCRIPT_AP_VERSION = 4.3 local SCRIPT_NAME = "EFI: Halo6000 CAN" diff --git a/libraries/AP_Scripting/drivers/EFI_SkyPower.lua b/libraries/AP_Scripting/drivers/EFI_SkyPower.lua index 569295ff1ba..3b7c8240f1f 100644 --- a/libraries/AP_Scripting/drivers/EFI_SkyPower.lua +++ b/libraries/AP_Scripting/drivers/EFI_SkyPower.lua @@ -12,6 +12,12 @@ CAN_D1_BITRATE 500000 (500 kbit/s) --]] +---@diagnostic disable: param-type-mismatch +---@diagnostic disable: need-check-nil +---@diagnostic disable: undefined-field +---@diagnostic disable: missing-parameter + + -- Check Script uses a miniumum firmware version local SCRIPT_AP_VERSION = 4.3 local SCRIPT_NAME = "EFI: Skypower CAN" diff --git a/libraries/AP_Scripting/drivers/Generator_SVFFI.lua b/libraries/AP_Scripting/drivers/Generator_SVFFI.lua index a5267b4a099..eae7678a253 100644 --- a/libraries/AP_Scripting/drivers/Generator_SVFFI.lua +++ b/libraries/AP_Scripting/drivers/Generator_SVFFI.lua @@ -3,6 +3,9 @@ See http://www.svffi.com/en/ --]] +---@diagnostic disable: param-type-mismatch +---@diagnostic disable: missing-parameter + local PARAM_TABLE_KEY = 42 local PARAM_TABLE_PREFIX = "EFI_SVF_" diff --git a/libraries/AP_Scripting/drivers/Hobbywing_DataLink.lua b/libraries/AP_Scripting/drivers/Hobbywing_DataLink.lua index d1be31dfad6..76a490146a9 100644 --- a/libraries/AP_Scripting/drivers/Hobbywing_DataLink.lua +++ b/libraries/AP_Scripting/drivers/Hobbywing_DataLink.lua @@ -2,6 +2,8 @@ driver for HobbyWing DataLink ESC telemetry --]] +---@diagnostic disable: param-type-mismatch + local PARAM_TABLE_KEY = 44 local PARAM_TABLE_PREFIX = "ESC_HW_" diff --git a/libraries/AP_Scripting/drivers/TOFSense-M/TOFSense-M_CAN.lua b/libraries/AP_Scripting/drivers/TOFSense-M/TOFSense-M_CAN.lua index f5b3dc7ba10..8f53c081cc6 100644 --- a/libraries/AP_Scripting/drivers/TOFSense-M/TOFSense-M_CAN.lua +++ b/libraries/AP_Scripting/drivers/TOFSense-M/TOFSense-M_CAN.lua @@ -2,6 +2,9 @@ Driver for NoopLoop TOFSense-M CAN Version. Can be used as a 1-D RangeFidner or 3-D proximity sensor. Upto 3 CAN devices supported in this script although its easy to extend. --]] +---@diagnostic disable: undefined-field +---@diagnostic disable: undefined-global + local update_rate_ms = 10 -- update rate (in ms) of the driver. 10ms was found to be appropriate -- Global variables (DO NOT CHANGE) diff --git a/libraries/AP_Scripting/drivers/TOFSense-M/TOFSense-M_Serial.lua b/libraries/AP_Scripting/drivers/TOFSense-M/TOFSense-M_Serial.lua index d6c495422cc..bc487de7343 100644 --- a/libraries/AP_Scripting/drivers/TOFSense-M/TOFSense-M_Serial.lua +++ b/libraries/AP_Scripting/drivers/TOFSense-M/TOFSense-M_Serial.lua @@ -2,6 +2,10 @@ Upto 3 CAN devices supported in this script although its easy to extend. --]] +---@diagnostic disable: param-type-mismatch +---@diagnostic disable: cast-local-type +---@diagnostic disable: undefined-global + local sensor_no = 1 -- Sensor ID. Upload a copy of this script to the flight controller with this variable changed if you would like to use multiple of these sensors as serial. Switching to CAN highly recommended in that case local update_rate_ms = 10 -- update rate (in ms) of the driver. 10ms was found to be appropriate local bytes_to_parse = 100 -- serial bytes to parse in one interation of lua script. Reduce this if script is not able to complete in time diff --git a/libraries/AP_Scripting/drivers/mount-djirs2-driver.lua b/libraries/AP_Scripting/drivers/mount-djirs2-driver.lua index 61113d05d7d..5032ac9b90a 100644 --- a/libraries/AP_Scripting/drivers/mount-djirs2-driver.lua +++ b/libraries/AP_Scripting/drivers/mount-djirs2-driver.lua @@ -71,6 +71,9 @@ --]] +---@diagnostic disable: cast-local-type + + -- global definitions local INIT_INTERVAL_MS = 3000 -- attempt to initialise the gimbal at this interval local UPDATE_INTERVAL_MS = 1 -- update interval in millis diff --git a/libraries/AP_Scripting/drivers/mount-viewpro-driver.lua b/libraries/AP_Scripting/drivers/mount-viewpro-driver.lua index 9786e6327bb..3f04dff228e 100644 --- a/libraries/AP_Scripting/drivers/mount-viewpro-driver.lua +++ b/libraries/AP_Scripting/drivers/mount-viewpro-driver.lua @@ -31,6 +31,9 @@ n+2 checksum XOR of byte3 to n+1 (inclusive) --]] +---@diagnostic disable: cast-local-type +---@diagnostic disable: undefined-global + -- parameters local PARAM_TABLE_KEY = 39 assert(param:add_table(PARAM_TABLE_KEY, "VIEP_", 6), "could not add param table") diff --git a/libraries/AP_Scripting/examples/AHRS_switch.lua b/libraries/AP_Scripting/examples/AHRS_switch.lua index e24478cf24b..a9f06c5a57b 100644 --- a/libraries/AP_Scripting/examples/AHRS_switch.lua +++ b/libraries/AP_Scripting/examples/AHRS_switch.lua @@ -1,5 +1,7 @@ -- switch between DCM and EKF3 on a switch +---@diagnostic disable: need-check-nil + local scripting_rc1 = rc:find_channel_for_option(300) local EKF_TYPE = Parameter('AHRS_EKF_TYPE') diff --git a/libraries/AP_Scripting/examples/CAN_MiniCheetah_drive.lua b/libraries/AP_Scripting/examples/CAN_MiniCheetah_drive.lua index a06f15b7629..cd5b681ec8e 100644 --- a/libraries/AP_Scripting/examples/CAN_MiniCheetah_drive.lua +++ b/libraries/AP_Scripting/examples/CAN_MiniCheetah_drive.lua @@ -1,6 +1,8 @@ -- Control MiniCheetah motor driver over CAN -- https://os.mbed.com/users/benkatz/code/HKC_MiniCheetah/docs/tip/CAN__com_8cpp_source.html +---@diagnostic disable: param-type-mismatch + -- Load CAN driver with a buffer size of 20 local driver = CAN:get_device(20) diff --git a/libraries/AP_Scripting/examples/CAN_logger.lua b/libraries/AP_Scripting/examples/CAN_logger.lua index aa3c5ff990a..d23ccf8076b 100644 --- a/libraries/AP_Scripting/examples/CAN_logger.lua +++ b/libraries/AP_Scripting/examples/CAN_logger.lua @@ -4,6 +4,8 @@ Also need LOG_DISARMED set to 1 if running this while disarmed. --]] +---@diagnostic disable: param-type-mismatch + local can_driver = CAN:get_device(25) if not can_driver then diff --git a/libraries/AP_Scripting/examples/EFI_tester.lua b/libraries/AP_Scripting/examples/EFI_tester.lua index 0bb2719d85e..4015e079ec3 100644 --- a/libraries/AP_Scripting/examples/EFI_tester.lua +++ b/libraries/AP_Scripting/examples/EFI_tester.lua @@ -3,6 +3,10 @@ this can be used with a loopback cable between CAN1 and CAN2 to test CAN EFI Drivers --]] +---@diagnostic disable: param-type-mismatch +---@diagnostic disable: missing-parameter + + local driver2 = CAN.get_device2(25) if not driver2 then gcs:send_text(0,string.format("EFISIM: Failed to load CAN driver")) diff --git a/libraries/AP_Scripting/examples/MAVLinkHL.lua b/libraries/AP_Scripting/examples/MAVLinkHL.lua index 3ee4f4f5e0f..21cc968a63e 100644 --- a/libraries/AP_Scripting/examples/MAVLinkHL.lua +++ b/libraries/AP_Scripting/examples/MAVLinkHL.lua @@ -17,9 +17,14 @@ Caveats: Written by Stephen Dade (stephen_dade@hotmail.com) --]] + +---@diagnostic disable: need-check-nil +---@diagnostic disable: cast-local-type + + local port = serial:find_serial(0) -if not port or baud == 0 then +if not port then gcs:send_text(0, "No Scripting Serial Port") return end diff --git a/libraries/AP_Scripting/examples/RC_override.lua b/libraries/AP_Scripting/examples/RC_override.lua index 52b19f2945c..460c6e9ab66 100644 --- a/libraries/AP_Scripting/examples/RC_override.lua +++ b/libraries/AP_Scripting/examples/RC_override.lua @@ -1,5 +1,8 @@ -- example of overriding RC inputs +---@diagnostic disable: need-check-nil +---@diagnostic disable: param-type-mismatch + local RC4 = rc:get_channel(4) function update() diff --git a/libraries/AP_Scripting/examples/SN-GCJA5-particle-sensor.lua b/libraries/AP_Scripting/examples/SN-GCJA5-particle-sensor.lua index 163ae6ca8aa..524eb685cc0 100644 --- a/libraries/AP_Scripting/examples/SN-GCJA5-particle-sensor.lua +++ b/libraries/AP_Scripting/examples/SN-GCJA5-particle-sensor.lua @@ -8,6 +8,9 @@ https://github.com/sparkfun/SparkFun_Particle_Sensor_SN-GCJA5_Arduino_Library ]]-- +---@diagnostic disable: need-check-nil +---@diagnostic disable: undefined-global + -- search for a index without a file, this stops us overwriting from a previous run local index = 0 local file_name diff --git a/libraries/AP_Scripting/examples/Serial_Dump.lua b/libraries/AP_Scripting/examples/Serial_Dump.lua index bfff5392e8c..aae1eef966a 100644 --- a/libraries/AP_Scripting/examples/Serial_Dump.lua +++ b/libraries/AP_Scripting/examples/Serial_Dump.lua @@ -1,5 +1,9 @@ -- this script reads data from a serial port and dumps it to a file +---@diagnostic disable: param-type-mismatch +---@diagnostic disable: need-check-nil +---@diagnostic disable: cast-local-type + local file_name = 'raw serial dump.txt' local file_name_plain = 'serial dump.txt' local baud_rate = 9600 diff --git a/libraries/AP_Scripting/examples/UART_log.lua b/libraries/AP_Scripting/examples/UART_log.lua index 927b6054c6a..37a26ed286e 100644 --- a/libraries/AP_Scripting/examples/UART_log.lua +++ b/libraries/AP_Scripting/examples/UART_log.lua @@ -3,7 +3,7 @@ -- find the serial first (0) scripting serial port instance local port = serial:find_serial(0) -if not port or baud == 0 then +if not port then gcs:send_text(0, "No Scripting Serial Port") return end diff --git a/libraries/AP_Scripting/examples/ahrs-set-home-to-vehicle-location.lua b/libraries/AP_Scripting/examples/ahrs-set-home-to-vehicle-location.lua index 090c8288f7b..f4fcee1e69e 100644 --- a/libraries/AP_Scripting/examples/ahrs-set-home-to-vehicle-location.lua +++ b/libraries/AP_Scripting/examples/ahrs-set-home-to-vehicle-location.lua @@ -1,6 +1,8 @@ -- example script for using "set_home()" -- sets the home location to the current vehicle location every 5 seconds +---@diagnostic disable: param-type-mismatch + function update () if ahrs:home_is_set() then diff --git a/libraries/AP_Scripting/examples/ahrs-source-gps-optflow.lua b/libraries/AP_Scripting/examples/ahrs-source-gps-optflow.lua index 5ce72deced6..3d313ea2212 100644 --- a/libraries/AP_Scripting/examples/ahrs-source-gps-optflow.lua +++ b/libraries/AP_Scripting/examples/ahrs-source-gps-optflow.lua @@ -27,6 +27,8 @@ -- -- When the 2nd auxiliary switch (300/Scripting1) is pulled high automatic source selection uses these thresholds: -- luacheck: only 0 +---@diagnostic disable: cast-local-type +---@diagnostic disable: need-check-nil local rangefinder_rotation = 25 -- check downward (25) facing lidar local source_prev = 0 -- previous source, defaults to primary source diff --git a/libraries/AP_Scripting/examples/ahrs-source-gps-wheelencoders.lua b/libraries/AP_Scripting/examples/ahrs-source-gps-wheelencoders.lua index 75d54583f21..96c4f7ed5fc 100644 --- a/libraries/AP_Scripting/examples/ahrs-source-gps-wheelencoders.lua +++ b/libraries/AP_Scripting/examples/ahrs-source-gps-wheelencoders.lua @@ -10,6 +10,8 @@ -- if GPS speed accuracy <= SCR_USER2 and GPS innovations <= SRC_USER3 then the GPS (primary source set) will be used -- otherwise wheel encoders (secondary source set) will be used -- luacheck: only 0 +---@diagnostic disable: cast-local-type +---@diagnostic disable: need-check-nil local source_prev = 0 -- previous source, defaults to primary source local sw_source_prev = -1 -- previous source switch position diff --git a/libraries/AP_Scripting/examples/ahrs-source.lua b/libraries/AP_Scripting/examples/ahrs-source.lua index 186bee0832b..87f4d985368 100644 --- a/libraries/AP_Scripting/examples/ahrs-source.lua +++ b/libraries/AP_Scripting/examples/ahrs-source.lua @@ -16,6 +16,9 @@ -- otherwise source2 (T265) or source3 (optical flow) will be used based on rangefinder distance -- luacheck: only 0 +---@diagnostic disable: need-check-nil +---@diagnostic disable: cast-local-type + local rangefinder_rotation = 25 -- check downward (25) facing lidar local source_prev = 0 -- previous source, defaults to primary source local sw_source_prev = -1 -- previous source switch position diff --git a/libraries/AP_Scripting/examples/analog_input_and_GPIO.lua b/libraries/AP_Scripting/examples/analog_input_and_GPIO.lua index 5d0048b547c..0cb20b6be79 100644 --- a/libraries/AP_Scripting/examples/analog_input_and_GPIO.lua +++ b/libraries/AP_Scripting/examples/analog_input_and_GPIO.lua @@ -2,6 +2,8 @@ -- for these examples BRD_PWM_COUNT must be 0 +---@diagnostic disable: need-check-nil + -- load the analog pin, there are only 16 of these available -- some are used by the main AP code, ie battery monitors -- assign them like this in the init, not in the main loop diff --git a/libraries/AP_Scripting/examples/benewakeH30_can_rangefinder.lua b/libraries/AP_Scripting/examples/benewakeH30_can_rangefinder.lua index ca1539cccee..a092cf85f25 100644 --- a/libraries/AP_Scripting/examples/benewakeH30_can_rangefinder.lua +++ b/libraries/AP_Scripting/examples/benewakeH30_can_rangefinder.lua @@ -1,5 +1,7 @@ -- Lua Can Driver for Benewake CAN Rangefinder +---@diagnostic disable: undefined-global + -- User settable parameters local update_rate_ms = 10 -- update rate (in ms) of the driver local debug_enable = false -- true to enable debug messages diff --git a/libraries/AP_Scripting/examples/camera-test.lua b/libraries/AP_Scripting/examples/camera-test.lua index 9dec743e6a4..c55343be528 100644 --- a/libraries/AP_Scripting/examples/camera-test.lua +++ b/libraries/AP_Scripting/examples/camera-test.lua @@ -1,5 +1,7 @@ -- camera-test.lua. Tests triggering taking pictures at regular intervals +---@diagnostic disable: cast-local-type + -- global definitions local MAV_SEVERITY = {EMERGENCY=0, ALERT=1, CRITICAL=2, ERROR=3, WARNING=4, NOTICE=5, INFO=6, DEBUG=7} local TAKE_PIC_INTERVAL_MS = 5000 -- take pictures at this interval diff --git a/libraries/AP_Scripting/examples/cell_balance_check.lua b/libraries/AP_Scripting/examples/cell_balance_check.lua index a7274a4d14d..64bec40178f 100644 --- a/libraries/AP_Scripting/examples/cell_balance_check.lua +++ b/libraries/AP_Scripting/examples/cell_balance_check.lua @@ -2,6 +2,8 @@ script implementing pre-arm check that batteries are well balanced --]] +---@diagnostic disable: param-type-mismatch + local MAX_CELL_DEVIATION = 0.2 local auth_id = arming:get_aux_auth_id() diff --git a/libraries/AP_Scripting/examples/copter-fast-descent.lua b/libraries/AP_Scripting/examples/copter-fast-descent.lua index 0b4ab0bfa12..77bd9eba47f 100644 --- a/libraries/AP_Scripting/examples/copter-fast-descent.lua +++ b/libraries/AP_Scripting/examples/copter-fast-descent.lua @@ -6,6 +6,10 @@ -- b) slows the spiral and stops at the preset altitude -- c) switches to RTL +---@diagnostic disable: param-type-mismatch +---@diagnostic disable: cast-local-type +---@diagnostic disable: need-check-nil + -- constants local copter_guided_mode_num = 4 -- Guided mode is 4 on copter local copter_rtl_mode_num = 6 -- RTL is 6 on copter diff --git a/libraries/AP_Scripting/examples/copter-nav-script-time.lua b/libraries/AP_Scripting/examples/copter-nav-script-time.lua index ebb8c462135..5c6c93c54db 100644 --- a/libraries/AP_Scripting/examples/copter-nav-script-time.lua +++ b/libraries/AP_Scripting/examples/copter-nav-script-time.lua @@ -12,6 +12,9 @@ -- "arg2" specifies the height (e.g. North-South) in meters -- Once the vehicle completes the square or the timeout expires the mission will continue and the vehicle should RTL home +---@diagnostic disable: param-type-mismatch +---@diagnostic disable: need-check-nil + local running = false local last_id = -1 -- unique id used to detect if a new NAV_SCRIPT_TIME command has started local start_loc -- vehicle's location when command starts (South-West corner of square) diff --git a/libraries/AP_Scripting/examples/frsky_wp.lua b/libraries/AP_Scripting/examples/frsky_wp.lua index 3ec41571382..91b8c083d84 100644 --- a/libraries/AP_Scripting/examples/frsky_wp.lua +++ b/libraries/AP_Scripting/examples/frsky_wp.lua @@ -18,6 +18,7 @@ Note: 17 is the index, 0x71 is the actual ID --]] -- luacheck: only 0 +---@diagnostic disable: param-type-mismatch local loop_time = 1000 -- number of ms between runs diff --git a/libraries/AP_Scripting/examples/fw_vtol_failsafe.lua b/libraries/AP_Scripting/examples/fw_vtol_failsafe.lua index 08638ef1695..93eea1843f7 100644 --- a/libraries/AP_Scripting/examples/fw_vtol_failsafe.lua +++ b/libraries/AP_Scripting/examples/fw_vtol_failsafe.lua @@ -8,6 +8,8 @@ -- If the aircraft drops below a predetermined minimum altitude, QLAND mode is engaged and the aircraft lands at its current position. -- If the aircraft arrives within Q_FW_LND_APR_RAD of the return point before dropping below the minimum altitude, it should loiter down to the minimum altitude before switching to QRTL and landing. +---@diagnostic disable: cast-local-type + -- setup param block for VTOL failsafe params local PARAM_TABLE_KEY = 77 local PARAM_TABLE_PREFIX = "VTFS_" diff --git a/libraries/AP_Scripting/examples/gen_control.lua b/libraries/AP_Scripting/examples/gen_control.lua index 018c6ce23f8..a8013c049a4 100644 --- a/libraries/AP_Scripting/examples/gen_control.lua +++ b/libraries/AP_Scripting/examples/gen_control.lua @@ -7,6 +7,8 @@ --]] -- luacheck: only 0 +---@diagnostic disable: need-check-nil +---@diagnostic disable: param-type-mismatch UPDATE_RATE_HZ = 10 diff --git a/libraries/AP_Scripting/examples/i2c_scan.lua b/libraries/AP_Scripting/examples/i2c_scan.lua index 9e93806af75..8600c1e21ba 100644 --- a/libraries/AP_Scripting/examples/i2c_scan.lua +++ b/libraries/AP_Scripting/examples/i2c_scan.lua @@ -1,4 +1,7 @@ -- This script scans for devices on the i2c bus + +---@diagnostic disable: need-check-nil + local address = 0 local found = 0 diff --git a/libraries/AP_Scripting/examples/mission-edit-demo.lua b/libraries/AP_Scripting/examples/mission-edit-demo.lua index ecbebe9c54a..d750d3f3bf5 100644 --- a/libraries/AP_Scripting/examples/mission-edit-demo.lua +++ b/libraries/AP_Scripting/examples/mission-edit-demo.lua @@ -2,6 +2,9 @@ -- by Buzz 2020 -- luacheck: only 0 +---@diagnostic disable: param-type-mismatch +---@diagnostic disable: undefined-field + current_pos = nil home = 0 a = {} diff --git a/libraries/AP_Scripting/examples/mission-load.lua b/libraries/AP_Scripting/examples/mission-load.lua index 76f465b1fbb..0ea6506e77e 100644 --- a/libraries/AP_Scripting/examples/mission-load.lua +++ b/libraries/AP_Scripting/examples/mission-load.lua @@ -5,7 +5,7 @@ --The "mission1.txt" file containing the mission items should be placed in the directory above the "scripts" directory. --In case of placing it on SD Card, mission1.txt file should be placed in the APM directory root. - +---@diagnostic disable: param-type-mismatch local function read_mission(file_name) diff --git a/libraries/AP_Scripting/examples/mission-save.lua b/libraries/AP_Scripting/examples/mission-save.lua index 84d19da296f..806a37eb3d0 100644 --- a/libraries/AP_Scripting/examples/mission-save.lua +++ b/libraries/AP_Scripting/examples/mission-save.lua @@ -1,5 +1,7 @@ -- Example of saving the current mission to a file on the SD card on arming +---@diagnostic disable: need-check-nil + local function save_to_SD() -- check if there is a mission to save diff --git a/libraries/AP_Scripting/examples/mount-test.lua b/libraries/AP_Scripting/examples/mount-test.lua index 18ef6449890..93f66f473df 100644 --- a/libraries/AP_Scripting/examples/mount-test.lua +++ b/libraries/AP_Scripting/examples/mount-test.lua @@ -12,6 +12,8 @@ -- stage 9: point North and Down -- stage 10: move angle to neutral position +---@diagnostic disable: cast-local-type + local stage = 0 local stage_time_ms = 5000 local stage_start_time_ms = 0 diff --git a/libraries/AP_Scripting/examples/net_test.lua b/libraries/AP_Scripting/examples/net_test.lua index b83fa2f8f4b..191d6ed23b9 100644 --- a/libraries/AP_Scripting/examples/net_test.lua +++ b/libraries/AP_Scripting/examples/net_test.lua @@ -2,6 +2,8 @@ example script to test lua socket API --]] +---@diagnostic disable: param-type-mismatch + local MAV_SEVERITY = {EMERGENCY=0, ALERT=1, CRITICAL=2, ERROR=3, WARNING=4, NOTICE=5, INFO=6, DEBUG=7} PARAM_TABLE_KEY = 46 diff --git a/libraries/AP_Scripting/examples/plane-doublets.lua b/libraries/AP_Scripting/examples/plane-doublets.lua index 2c34a381f6c..da806fe754c 100644 --- a/libraries/AP_Scripting/examples/plane-doublets.lua +++ b/libraries/AP_Scripting/examples/plane-doublets.lua @@ -8,6 +8,9 @@ -- starting a doublet -- Charlie Johnson, Oklahoma State University 2020 +---@diagnostic disable: param-type-mismatch +---@diagnostic disable: cast-local-type + local DOUBLET_ACTION_CHANNEL = 6 -- RCIN channel to start a doublet when high (>1700) local DOUBLET_CHOICE_CHANNEL = 7 -- RCIN channel to choose elevator (low) or rudder (high) local DOUBLET_FUCNTION = 19 -- which control surface (SERVOx_FUNCTION) number will have a doublet happen diff --git a/libraries/AP_Scripting/examples/plane-wind-fs.lua b/libraries/AP_Scripting/examples/plane-wind-fs.lua index ef5fcfccd2e..2369a1d5a31 100644 --- a/libraries/AP_Scripting/examples/plane-wind-fs.lua +++ b/libraries/AP_Scripting/examples/plane-wind-fs.lua @@ -3,6 +3,9 @@ -- -- CAUTION: This script only works for Plane +---@diagnostic disable: cast-local-type +---@diagnostic disable: undefined-global + -- store the batt info as { instance, filtered, capacity, margin_mah } -- instance: the battery monitor instance (zero indexed) -- filtered: internal variable for current draw diff --git a/libraries/AP_Scripting/examples/plane_guided_follow.lua b/libraries/AP_Scripting/examples/plane_guided_follow.lua index 89e5ef09cd3..c5d6252f3ca 100644 --- a/libraries/AP_Scripting/examples/plane_guided_follow.lua +++ b/libraries/AP_Scripting/examples/plane_guided_follow.lua @@ -1,5 +1,7 @@ -- support follow in GUIDED mode in plane -- luacheck: only 0 +---@diagnostic disable: cast-local-type + local PARAM_TABLE_KEY = 11 local PARAM_TABLE_PREFIX = "GFOLL_" diff --git a/libraries/AP_Scripting/examples/quadruped.lua b/libraries/AP_Scripting/examples/quadruped.lua index a8d5536512d..f74e89b1f0c 100644 --- a/libraries/AP_Scripting/examples/quadruped.lua +++ b/libraries/AP_Scripting/examples/quadruped.lua @@ -19,6 +19,8 @@ -- -- CAUTION: This script should only be used with ArduPilot Rover's firmware +---@diagnostic disable: cast-local-type + local FRAME_LEN = 80 -- frame length in mm local FRAME_WIDTH = 150 -- frame width in mm diff --git a/libraries/AP_Scripting/examples/rangefinder_quality_test.lua b/libraries/AP_Scripting/examples/rangefinder_quality_test.lua index 28c78e7ff25..45772d4d35d 100644 --- a/libraries/AP_Scripting/examples/rangefinder_quality_test.lua +++ b/libraries/AP_Scripting/examples/rangefinder_quality_test.lua @@ -10,6 +10,9 @@ -- "RNGFND1_MIN_CM": 10, -- "RNGFND1_MAX_CM": 5000, +---@diagnostic disable: cast-local-type + + -- UPDATE_PERIOD_MS is the time between when a distance is set and -- when it is read. There is a periodic task that copies the set distance to -- the state structure that it is read from. If UPDATE_PERIOD_MS is too short this periodic diff --git a/libraries/AP_Scripting/examples/rover-MinFixType.lua b/libraries/AP_Scripting/examples/rover-MinFixType.lua index aabe1f44d61..7afb3d67f36 100644 --- a/libraries/AP_Scripting/examples/rover-MinFixType.lua +++ b/libraries/AP_Scripting/examples/rover-MinFixType.lua @@ -13,6 +13,8 @@ of a vehicle. Use this script AT YOUR OWN RISK. LICENSE - GNU GPLv3 https://www.gnu.org/licenses/gpl-3.0.en.html ------------------------------------------------------------------------------]] +---@diagnostic disable: param-type-mismatch + local SCRIPT_NAME = 'MinFixType' -------- MAVLINK/AUTOPILOT 'CONSTANTS' -------- diff --git a/libraries/AP_Scripting/examples/rover-SaveTurns.lua b/libraries/AP_Scripting/examples/rover-SaveTurns.lua index 9e530f23313..4aa68d021aa 100644 --- a/libraries/AP_Scripting/examples/rover-SaveTurns.lua +++ b/libraries/AP_Scripting/examples/rover-SaveTurns.lua @@ -12,6 +12,9 @@ of a vehicle. Use this script AT YOUR OWN RISK. LICENSE - GNU GPLv3 https://www.gnu.org/licenses/gpl-3.0.en.html ------------------------------------------------------------------------------]] +---@diagnostic disable: cast-local-type +---@diagnostic disable: need-check-nil + local SCRIPT_NAME = 'SaveTurns' -------- USER EDITABLE GLOBALS -------- diff --git a/libraries/AP_Scripting/examples/rover-TerrainDetector.lua b/libraries/AP_Scripting/examples/rover-TerrainDetector.lua index 7ba86468210..e220e7be282 100644 --- a/libraries/AP_Scripting/examples/rover-TerrainDetector.lua +++ b/libraries/AP_Scripting/examples/rover-TerrainDetector.lua @@ -28,6 +28,8 @@ https://www.youtube.com/watch?v=UdXGXjigxAo&t=7155s Credit to @ktrussell for the idea and discussion! ------------------------------------------------------------------------------]] +---@diagnostic disable: param-type-mismatch + local SCRIPT_NAME = 'TerrainDetector' local RUN_INTERVAL_MS = 25 -- needs to be pretty fast for good detection local SBY_INTERVAL_MS = 500 -- slower interval when detection is disabled diff --git a/libraries/AP_Scripting/examples/serial_test.lua b/libraries/AP_Scripting/examples/serial_test.lua index 6f7a2a5a038..a1108923c70 100644 --- a/libraries/AP_Scripting/examples/serial_test.lua +++ b/libraries/AP_Scripting/examples/serial_test.lua @@ -1,5 +1,7 @@ -- Lua script to write and read from a serial +---@diagnostic disable: need-check-nil + local port = serial:find_serial(0) port:begin(115200) diff --git a/libraries/AP_Scripting/examples/servo_set_get.lua b/libraries/AP_Scripting/examples/servo_set_get.lua index 0834bacce58..61ed0d20e39 100644 --- a/libraries/AP_Scripting/examples/servo_set_get.lua +++ b/libraries/AP_Scripting/examples/servo_set_get.lua @@ -5,7 +5,7 @@ local flipflop = true local K_AILERON = 4 -local aileron_channel = SRV_Channels:find_channel(K_AILERON) +local aileron_channel = assert(SRV_Channels:find_channel(K_AILERON)) function update() if flipflop then diff --git a/libraries/AP_Scripting/examples/set_target_posvel_circle.lua b/libraries/AP_Scripting/examples/set_target_posvel_circle.lua index 87d4d953826..3e068faa446 100644 --- a/libraries/AP_Scripting/examples/set_target_posvel_circle.lua +++ b/libraries/AP_Scripting/examples/set_target_posvel_circle.lua @@ -8,6 +8,9 @@ -- 3) the vehilce will follow a circle in clockwise direction with increasing speed until ramp_up_time_s time has passed. -- 4) switch out of and into the GUIDED mode any time to restart the trajectory from the start. +---@diagnostic disable: cast-local-type +---@diagnostic disable: redundant-parameter + -- Edit these variables local rad_xy_m = 10.0 -- circle radius in xy plane in m local target_speed_xy_mps = 5.0 -- maximum target speed in m/s diff --git a/libraries/AP_Scripting/examples/ship_vel_match.lua b/libraries/AP_Scripting/examples/ship_vel_match.lua index 38594caed48..9ceee3debc0 100644 --- a/libraries/AP_Scripting/examples/ship_vel_match.lua +++ b/libraries/AP_Scripting/examples/ship_vel_match.lua @@ -1,5 +1,7 @@ -- support takeoff with velocity matching for quadplanes +---@diagnostic disable: need-check-nil + local PARAM_TABLE_KEY = 35 local PARAM_TABLE_PREFIX = "SHIPV_" diff --git a/libraries/AP_Scripting/examples/sub_test_synthetic_seafloor.lua b/libraries/AP_Scripting/examples/sub_test_synthetic_seafloor.lua index a7815dec89f..ceb12ba36b9 100644 --- a/libraries/AP_Scripting/examples/sub_test_synthetic_seafloor.lua +++ b/libraries/AP_Scripting/examples/sub_test_synthetic_seafloor.lua @@ -13,6 +13,8 @@ -- SCR_USER3 is a bit field that controls driver logging. -- +---@diagnostic disable: param-type-mismatch +---@diagnostic disable: cast-local-type local UPDATE_PERIOD_MS = 50 diff --git a/libraries/AP_Scripting/examples/test_load.lua b/libraries/AP_Scripting/examples/test_load.lua index f09d6a48274..1d09e515c48 100644 --- a/libraries/AP_Scripting/examples/test_load.lua +++ b/libraries/AP_Scripting/examples/test_load.lua @@ -1,6 +1,7 @@ --[[ test the load function for loading new code from strings --]] +---@diagnostic disable: undefined-global gcs:send_text(0,"Testing load() method") diff --git a/libraries/AP_Scripting/examples/wrap32_test.lua b/libraries/AP_Scripting/examples/wrap32_test.lua index 9e088d58cbd..1ae5e90ffa9 100644 --- a/libraries/AP_Scripting/examples/wrap32_test.lua +++ b/libraries/AP_Scripting/examples/wrap32_test.lua @@ -8,6 +8,8 @@ a script to test handling of 32 bit micros timer wrap with BDShot - BRD_SAFETY_DFLT must be 0 - BDShot must be enabled on outputs 9-12 --]] +---@diagnostic disable: param-type-mismatch +---@diagnostic disable: cast-local-type local PARAM_TABLE_KEY = 138 local PARAM_TABLE_PREFIX = "WRAP32_" diff --git a/libraries/AP_Scripting/tests/math.lua b/libraries/AP_Scripting/tests/math.lua index 4cfeb4ffe46..e70d48ba661 100644 --- a/libraries/AP_Scripting/tests/math.lua +++ b/libraries/AP_Scripting/tests/math.lua @@ -33,6 +33,9 @@ -- luacheck: ignore 421 (Shadowing a local variable) -- luacheck: ignore 581 (Negation of a relational operator - operator can be flipped) +---@diagnostic disable: cast-local-type +---@diagnostic disable: undefined-global + gcs:send_text(6, "testing numbers and math lib") local minint = math.mininteger diff --git a/libraries/AP_Scripting/tests/mavlink_test.lua b/libraries/AP_Scripting/tests/mavlink_test.lua index cc2a062bdd1..c03fe2af24e 100644 --- a/libraries/AP_Scripting/tests/mavlink_test.lua +++ b/libraries/AP_Scripting/tests/mavlink_test.lua @@ -1,3 +1,6 @@ +---@diagnostic disable: param-type-mismatch +---@diagnostic disable: missing-parameter + local mavlink_msgs = require("mavlink/mavlink_msgs") local msg_map = {} diff --git a/libraries/AP_Scripting/tests/strings.lua b/libraries/AP_Scripting/tests/strings.lua index 79fde4c4fb8..fb19ebcda5a 100644 --- a/libraries/AP_Scripting/tests/strings.lua +++ b/libraries/AP_Scripting/tests/strings.lua @@ -29,6 +29,11 @@ -- luacheck: ignore 581 (Negation of a relational operator - operator can be flipped) +---@diagnostic disable: param-type-mismatch +---@diagnostic disable: missing-parameter +---@diagnostic disable: undefined-global + + gcs:send_text(6, 'testing strings and string library') local maxi, mini = math.maxinteger, math.mininteger