diff --git a/src/modules/commander/accelerometer_calibration.cpp b/src/modules/commander/accelerometer_calibration.cpp index ea5136221f..4ce21a6dbd 100644 --- a/src/modules/commander/accelerometer_calibration.cpp +++ b/src/modules/commander/accelerometer_calibration.cpp @@ -179,7 +179,7 @@ int do_accel_calibration(orb_advert_t *mavlink_log_pub) int fd; #endif - mavlink_and_console_log_info(mavlink_log_pub, CAL_QGC_STARTED_MSG, sensor_name); + calibration_log_info(mavlink_log_pub, CAL_QGC_STARTED_MSG, sensor_name); struct accel_calibration_s accel_scale; accel_scale.x_offset = 0.0f; @@ -210,7 +210,7 @@ int do_accel_calibration(orb_advert_t *mavlink_log_pub) px4_close(fd); if (res != OK) { - mavlink_and_console_log_critical(mavlink_log_pub, CAL_ERROR_RESET_CAL_MSG, s); + calibration_log_critical(mavlink_log_pub, CAL_ERROR_RESET_CAL_MSG, s); } #else (void)sprintf(str, "CAL_ACC%u_XOFF", s); @@ -265,7 +265,7 @@ int do_accel_calibration(orb_advert_t *mavlink_log_pub) if (res != OK) { if (active_sensors == 0) { - mavlink_and_console_log_critical(mavlink_log_pub, CAL_ERROR_SENSOR_MSG); + calibration_log_critical(mavlink_log_pub, CAL_ERROR_SENSOR_MSG); } return ERROR; } @@ -325,7 +325,7 @@ int do_accel_calibration(orb_advert_t *mavlink_log_pub) failed |= (OK != param_set_no_notification(param_find(str), &(device_id[i]))); if (failed) { - mavlink_and_console_log_critical(mavlink_log_pub, CAL_ERROR_SET_PARAMS_MSG, i); + calibration_log_critical(mavlink_log_pub, CAL_ERROR_SET_PARAMS_MSG, i); return ERROR; } @@ -334,7 +334,7 @@ int do_accel_calibration(orb_advert_t *mavlink_log_pub) fd = px4_open(str, 0); if (fd < 0) { - mavlink_and_console_log_critical(mavlink_log_pub, CAL_QGC_FAILED_MSG, "sensor does not exist"); + calibration_log_critical(mavlink_log_pub, CAL_QGC_FAILED_MSG, "sensor does not exist"); res = ERROR; } else { res = px4_ioctl(fd, ACCELIOCSSCALE, (long unsigned int)&accel_scale); @@ -342,7 +342,7 @@ int do_accel_calibration(orb_advert_t *mavlink_log_pub) } if (res != OK) { - mavlink_and_console_log_critical(mavlink_log_pub, CAL_ERROR_APPLY_CAL_MSG, i); + calibration_log_critical(mavlink_log_pub, CAL_ERROR_APPLY_CAL_MSG, i); } #endif } @@ -352,16 +352,16 @@ int do_accel_calibration(orb_advert_t *mavlink_log_pub) res = param_save_default(); if (res != OK) { - mavlink_and_console_log_critical(mavlink_log_pub, CAL_ERROR_SAVE_PARAMS_MSG); + calibration_log_critical(mavlink_log_pub, CAL_ERROR_SAVE_PARAMS_MSG); } /* if there is a any preflight-check system response, let the barrage of messages through */ usleep(200000); - mavlink_and_console_log_info(mavlink_log_pub, CAL_QGC_DONE_MSG, sensor_name); + calibration_log_info(mavlink_log_pub, CAL_QGC_DONE_MSG, sensor_name); } else { - mavlink_and_console_log_critical(mavlink_log_pub, CAL_QGC_FAILED_MSG, sensor_name); + calibration_log_critical(mavlink_log_pub, CAL_QGC_FAILED_MSG, sensor_name); } /* give this message enough time to propagate */ @@ -375,17 +375,17 @@ static calibrate_return accel_calibration_worker(detect_orientation_return orien const unsigned samples_num = 750; accel_worker_data_t* worker_data = (accel_worker_data_t*)(data); - mavlink_and_console_log_info(worker_data->mavlink_log_pub, "[cal] Hold still, measuring %s side", detect_orientation_str(orientation)); + calibration_log_info(worker_data->mavlink_log_pub, "[cal] Hold still, measuring %s side", detect_orientation_str(orientation)); read_accelerometer_avg(worker_data->subs, worker_data->accel_ref, orientation, samples_num); - mavlink_and_console_log_info(worker_data->mavlink_log_pub, "[cal] %s side result: [%8.4f %8.4f %8.4f]", detect_orientation_str(orientation), + calibration_log_info(worker_data->mavlink_log_pub, "[cal] %s side result: [%8.4f %8.4f %8.4f]", detect_orientation_str(orientation), (double)worker_data->accel_ref[0][orientation][0], (double)worker_data->accel_ref[0][orientation][1], (double)worker_data->accel_ref[0][orientation][2]); worker_data->done_count++; - mavlink_and_console_log_info(worker_data->mavlink_log_pub, CAL_QGC_PROGRESS_MSG, 17 * worker_data->done_count); + calibration_log_info(worker_data->mavlink_log_pub, CAL_QGC_PROGRESS_MSG, 17 * worker_data->done_count); return calibrate_return_ok; } @@ -440,7 +440,7 @@ calibrate_return do_accel_calibration_measurements(orb_advert_t *mavlink_log_pub device_id_primary = device_id[i]; } } else { - mavlink_and_console_log_critical(mavlink_log_pub, "[cal] Accel #%u no device id, abort", i); + calibration_log_critical(mavlink_log_pub, "[cal] Accel #%u no device id, abort", i); result = calibrate_return_error; break; } @@ -471,7 +471,7 @@ calibrate_return do_accel_calibration_measurements(orb_advert_t *mavlink_log_pub result = calculate_calibration_values(i, worker_data.accel_ref, accel_T, accel_offs, CONSTANTS_ONE_G); if (result != calibrate_return_ok) { - mavlink_and_console_log_critical(mavlink_log_pub, "[cal] ERROR: calibration calculation error"); + calibration_log_critical(mavlink_log_pub, "[cal] ERROR: calibration calculation error"); break; } } @@ -641,7 +641,7 @@ int do_level_calibration(orb_advert_t *mavlink_log_pub) { struct vehicle_attitude_s att; memset(&att, 0, sizeof(att)); - mavlink_and_console_log_info(mavlink_log_pub, CAL_QGC_STARTED_MSG, "level"); + calibration_log_info(mavlink_log_pub, CAL_QGC_STARTED_MSG, "level"); param_t roll_offset_handle = param_find("SENS_BOARD_X_OFF"); param_t pitch_offset_handle = param_find("SENS_BOARD_Y_OFF"); @@ -676,7 +676,7 @@ int do_level_calibration(orb_advert_t *mavlink_log_pub) { // sleep for some time hrt_abstime start = hrt_absolute_time(); while(hrt_elapsed_time(&start) < settle_time * 1000000) { - mavlink_and_console_log_info(mavlink_log_pub, CAL_QGC_PROGRESS_MSG, (int)(90*hrt_elapsed_time(&start)/1e6f/(float)settle_time)); + calibration_log_info(mavlink_log_pub, CAL_QGC_PROGRESS_MSG, (int)(90*hrt_elapsed_time(&start)/1e6f/(float)settle_time)); sleep(settle_time / 10); } @@ -687,8 +687,8 @@ int do_level_calibration(orb_advert_t *mavlink_log_pub) { if (pollret <= 0) { // attitude estimator is not running - mavlink_and_console_log_critical(mavlink_log_pub, "attitude estimator not running - check system boot"); - mavlink_and_console_log_critical(mavlink_log_pub, CAL_QGC_FAILED_MSG, "level"); + calibration_log_critical(mavlink_log_pub, "attitude estimator not running - check system boot"); + calibration_log_critical(mavlink_log_pub, CAL_QGC_FAILED_MSG, "level"); goto out; } @@ -698,21 +698,21 @@ int do_level_calibration(orb_advert_t *mavlink_log_pub) { counter++; } - mavlink_and_console_log_info(mavlink_log_pub, CAL_QGC_PROGRESS_MSG, 100); + calibration_log_info(mavlink_log_pub, CAL_QGC_PROGRESS_MSG, 100); if (counter > (cal_time * cal_hz / 2 )) { roll_mean /= counter; pitch_mean /= counter; } else { - mavlink_and_console_log_info(mavlink_log_pub, "not enough measurements taken"); + calibration_log_info(mavlink_log_pub, "not enough measurements taken"); success = false; goto out; } if (fabsf(roll_mean) > 0.8f ) { - mavlink_and_console_log_critical(mavlink_log_pub, "excess roll angle"); + calibration_log_critical(mavlink_log_pub, "excess roll angle"); } else if (fabsf(pitch_mean) > 0.8f ) { - mavlink_and_console_log_critical(mavlink_log_pub, "excess pitch angle"); + calibration_log_critical(mavlink_log_pub, "excess pitch angle"); } else { roll_mean *= (float)M_RAD_TO_DEG; pitch_mean *= (float)M_RAD_TO_DEG; @@ -723,13 +723,13 @@ int do_level_calibration(orb_advert_t *mavlink_log_pub) { out: if (success) { - mavlink_and_console_log_info(mavlink_log_pub, CAL_QGC_DONE_MSG, "level"); + calibration_log_info(mavlink_log_pub, CAL_QGC_DONE_MSG, "level"); return 0; } else { // set old parameters param_set(roll_offset_handle, &roll_offset_current); param_set(pitch_offset_handle, &pitch_offset_current); - mavlink_and_console_log_critical(mavlink_log_pub, CAL_QGC_FAILED_MSG, "level"); + calibration_log_critical(mavlink_log_pub, CAL_QGC_FAILED_MSG, "level"); return 1; } } diff --git a/src/modules/commander/airspeed_calibration.cpp b/src/modules/commander/airspeed_calibration.cpp index 7f24f0c201..97d461ae75 100644 --- a/src/modules/commander/airspeed_calibration.cpp +++ b/src/modules/commander/airspeed_calibration.cpp @@ -68,7 +68,7 @@ static const char *sensor_name = "dpress"; static void feedback_calibration_failed(orb_advert_t *mavlink_log_pub) { sleep(5); - mavlink_and_console_log_critical(mavlink_log_pub, CAL_QGC_FAILED_MSG, sensor_name); + calibration_log_critical(mavlink_log_pub, CAL_QGC_FAILED_MSG, sensor_name); } int do_airspeed_calibration(orb_advert_t *mavlink_log_pub) @@ -78,7 +78,7 @@ int do_airspeed_calibration(orb_advert_t *mavlink_log_pub) const unsigned maxcount = 2400; /* give directions */ - mavlink_and_console_log_info(mavlink_log_pub, CAL_QGC_STARTED_MSG, sensor_name); + calibration_log_info(mavlink_log_pub, CAL_QGC_STARTED_MSG, sensor_name); const unsigned calibration_count = (maxcount * 2) / 3; @@ -101,7 +101,7 @@ int do_airspeed_calibration(orb_advert_t *mavlink_log_pub) paramreset_successful = true; } else { - mavlink_and_console_log_critical(mavlink_log_pub, "[cal] airspeed offset zero failed"); + calibration_log_critical(mavlink_log_pub, "[cal] airspeed offset zero failed"); } px4_close(fd); @@ -115,18 +115,18 @@ int do_airspeed_calibration(orb_advert_t *mavlink_log_pub) float analog_scaling = 0.0f; param_get(param_find("SENS_DPRES_ANSC"), &(analog_scaling)); if (fabsf(analog_scaling) < 0.1f) { - mavlink_and_console_log_critical(mavlink_log_pub, "[cal] No airspeed sensor, see http://px4.io/help/aspd"); + calibration_log_critical(mavlink_log_pub, "[cal] No airspeed sensor, see http://px4.io/help/aspd"); goto error_return; } /* set scaling offset parameter */ if (param_set(param_find("SENS_DPRES_OFF"), &(diff_pres_offset))) { - mavlink_and_console_log_critical(mavlink_log_pub, CAL_ERROR_SET_PARAMS_MSG, 1); + calibration_log_critical(mavlink_log_pub, CAL_ERROR_SET_PARAMS_MSG, 1); goto error_return; } } - mavlink_and_console_log_critical(mavlink_log_pub, "[cal] Ensure sensor is not measuring wind"); + calibration_log_critical(mavlink_log_pub, "[cal] Ensure sensor is not measuring wind"); usleep(500 * 1000); while (calibration_counter < calibration_count) { @@ -149,7 +149,7 @@ int do_airspeed_calibration(orb_advert_t *mavlink_log_pub) calibration_counter++; if (calibration_counter % (calibration_count / 20) == 0) { - mavlink_and_console_log_info(mavlink_log_pub, CAL_QGC_PROGRESS_MSG, (calibration_counter * 80) / calibration_count); + calibration_log_info(mavlink_log_pub, CAL_QGC_PROGRESS_MSG, (calibration_counter * 80) / calibration_count); } } else if (poll_ret == 0) { @@ -167,14 +167,14 @@ int do_airspeed_calibration(orb_advert_t *mavlink_log_pub) airscale.offset_pa = diff_pres_offset; if (fd_scale > 0) { if (OK != px4_ioctl(fd_scale, AIRSPEEDIOCSSCALE, (long unsigned int)&airscale)) { - mavlink_and_console_log_critical(mavlink_log_pub, "[cal] airspeed offset update failed"); + calibration_log_critical(mavlink_log_pub, "[cal] airspeed offset update failed"); } px4_close(fd_scale); } if (param_set(param_find("SENS_DPRES_OFF"), &(diff_pres_offset))) { - mavlink_and_console_log_critical(mavlink_log_pub, CAL_ERROR_SET_PARAMS_MSG, 1); + calibration_log_critical(mavlink_log_pub, CAL_ERROR_SET_PARAMS_MSG, 1); goto error_return; } @@ -183,7 +183,7 @@ int do_airspeed_calibration(orb_advert_t *mavlink_log_pub) if (save_ret != 0) { warn("WARNING: auto-save of params to storage failed"); - mavlink_and_console_log_critical(mavlink_log_pub, CAL_ERROR_SAVE_PARAMS_MSG); + calibration_log_critical(mavlink_log_pub, CAL_ERROR_SAVE_PARAMS_MSG); goto error_return; } @@ -192,12 +192,12 @@ int do_airspeed_calibration(orb_advert_t *mavlink_log_pub) goto error_return; } - mavlink_and_console_log_critical(mavlink_log_pub, "[cal] Offset of %d Pascal", (int)diff_pres_offset); + calibration_log_critical(mavlink_log_pub, "[cal] Offset of %d Pascal", (int)diff_pres_offset); /* wait 500 ms to ensure parameter propagated through the system */ usleep(500 * 1000); - mavlink_and_console_log_critical(mavlink_log_pub, "[cal] Create airflow now"); + calibration_log_critical(mavlink_log_pub, "[cal] Create airflow now"); calibration_counter = 0; @@ -222,7 +222,7 @@ int do_airspeed_calibration(orb_advert_t *mavlink_log_pub) if (fabsf(diff_pres.differential_pressure_raw_pa) < 50.0f) { if (calibration_counter % 500 == 0) { - mavlink_and_console_log_info(mavlink_log_pub, "[cal] Create air pressure! (got %d, wanted: 50 Pa)", + calibration_log_info(mavlink_log_pub, "[cal] Create air pressure! (got %d, wanted: 50 Pa)", (int)diff_pres.differential_pressure_raw_pa); } continue; @@ -230,26 +230,26 @@ int do_airspeed_calibration(orb_advert_t *mavlink_log_pub) /* do not allow negative values */ if (diff_pres.differential_pressure_raw_pa < 0.0f) { - mavlink_and_console_log_info(mavlink_log_pub, "[cal] Negative pressure difference detected (%d Pa)", + calibration_log_info(mavlink_log_pub, "[cal] Negative pressure difference detected (%d Pa)", (int)diff_pres.differential_pressure_raw_pa); - mavlink_and_console_log_info(mavlink_log_pub, "[cal] Swap static and dynamic ports!"); + calibration_log_info(mavlink_log_pub, "[cal] Swap static and dynamic ports!"); /* the user setup is wrong, wipe the calibration to force a proper re-calibration */ diff_pres_offset = 0.0f; if (param_set(param_find("SENS_DPRES_OFF"), &(diff_pres_offset))) { - mavlink_and_console_log_critical(mavlink_log_pub, CAL_ERROR_SET_PARAMS_MSG, 1); + calibration_log_critical(mavlink_log_pub, CAL_ERROR_SET_PARAMS_MSG, 1); goto error_return; } /* save */ - mavlink_and_console_log_info(mavlink_log_pub, CAL_QGC_PROGRESS_MSG, 0); + calibration_log_info(mavlink_log_pub, CAL_QGC_PROGRESS_MSG, 0); (void)param_save_default(); feedback_calibration_failed(mavlink_log_pub); goto error_return; } else { - mavlink_and_console_log_info(mavlink_log_pub, "[cal] Positive pressure: OK (%d Pa)", + calibration_log_info(mavlink_log_pub, "[cal] Positive pressure: OK (%d Pa)", (int)diff_pres.differential_pressure_raw_pa); break; } @@ -266,9 +266,9 @@ int do_airspeed_calibration(orb_advert_t *mavlink_log_pub) goto error_return; } - mavlink_and_console_log_info(mavlink_log_pub, CAL_QGC_PROGRESS_MSG, 100); + calibration_log_info(mavlink_log_pub, CAL_QGC_PROGRESS_MSG, 100); - mavlink_and_console_log_info(mavlink_log_pub, CAL_QGC_DONE_MSG, sensor_name); + calibration_log_info(mavlink_log_pub, CAL_QGC_DONE_MSG, sensor_name); tune_neutral(true); normal_return: diff --git a/src/modules/commander/esc_calibration.cpp b/src/modules/commander/esc_calibration.cpp index 65a70401f9..2c7ef9bf55 100644 --- a/src/modules/commander/esc_calibration.cpp +++ b/src/modules/commander/esc_calibration.cpp @@ -41,6 +41,7 @@ #include "esc_calibration.h" #include "calibration_messages.h" +#include "calibration_routines.h" #include #include @@ -93,18 +94,18 @@ int do_esc_calibration(orb_advert_t *mavlink_log_pub, struct actuator_armed_s* a hrt_abstime pwm_high_timeout = 10000000; hrt_abstime timeout_start; - mavlink_and_console_log_info(mavlink_log_pub, CAL_QGC_STARTED_MSG, "esc"); + calibration_log_info(mavlink_log_pub, CAL_QGC_STARTED_MSG, "esc"); batt_sub = orb_subscribe(ORB_ID(battery_status)); if (batt_sub < 0) { - mavlink_and_console_log_critical(mavlink_log_pub, CAL_QGC_FAILED_MSG, "Subscribe to battery"); + calibration_log_critical(mavlink_log_pub, CAL_QGC_FAILED_MSG, "Subscribe to battery"); goto Error; } // Make sure battery is disconnected orb_copy(ORB_ID(battery_status), batt_sub, &battery); if (battery.voltage_filtered_v > 3.0f) { - mavlink_and_console_log_critical(mavlink_log_pub, CAL_QGC_FAILED_MSG, "Disconnect battery and try again"); + calibration_log_critical(mavlink_log_pub, CAL_QGC_FAILED_MSG, "Disconnect battery and try again"); goto Error; } @@ -113,29 +114,29 @@ int do_esc_calibration(orb_advert_t *mavlink_log_pub, struct actuator_armed_s* a fd = px4_open(PWM_OUTPUT0_DEVICE_PATH, 0); if (fd < 0) { - mavlink_and_console_log_critical(mavlink_log_pub, CAL_QGC_FAILED_MSG, "Can't open PWM device"); + calibration_log_critical(mavlink_log_pub, CAL_QGC_FAILED_MSG, "Can't open PWM device"); goto Error; } /* tell IO/FMU that its ok to disable its safety with the switch */ if (px4_ioctl(fd, PWM_SERVO_SET_ARM_OK, 0) != OK) { - mavlink_and_console_log_critical(mavlink_log_pub, CAL_QGC_FAILED_MSG, "Unable to disable safety switch"); + calibration_log_critical(mavlink_log_pub, CAL_QGC_FAILED_MSG, "Unable to disable safety switch"); goto Error; } /* tell IO/FMU that the system is armed (it will output values if safety is off) */ if (px4_ioctl(fd, PWM_SERVO_ARM, 0) != OK) { - mavlink_and_console_log_critical(mavlink_log_pub, CAL_QGC_FAILED_MSG, "Unable to arm system"); + calibration_log_critical(mavlink_log_pub, CAL_QGC_FAILED_MSG, "Unable to arm system"); goto Error; } /* tell IO to switch off safety without using the safety switch */ if (px4_ioctl(fd, PWM_SERVO_SET_FORCE_SAFETY_OFF, 0) != OK) { - mavlink_and_console_log_critical(mavlink_log_pub, CAL_QGC_FAILED_MSG, "Unable to force safety off"); + calibration_log_critical(mavlink_log_pub, CAL_QGC_FAILED_MSG, "Unable to force safety off"); goto Error; } - mavlink_and_console_log_info(mavlink_log_pub, "[cal] Connect battery now"); + calibration_log_info(mavlink_log_pub, "[cal] Connect battery now"); timeout_start = hrt_absolute_time(); @@ -146,7 +147,7 @@ int do_esc_calibration(orb_advert_t *mavlink_log_pub, struct actuator_armed_s* a if (hrt_absolute_time() - timeout_start > timeout_wait) { if (!batt_connected) { - mavlink_and_console_log_critical(mavlink_log_pub, CAL_QGC_FAILED_MSG, "Timeout waiting for battery"); + calibration_log_critical(mavlink_log_pub, CAL_QGC_FAILED_MSG, "Timeout waiting for battery"); goto Error; } @@ -162,7 +163,7 @@ int do_esc_calibration(orb_advert_t *mavlink_log_pub, struct actuator_armed_s* a // Battery is connected, signal to user and start waiting again batt_connected = true; timeout_start = hrt_absolute_time(); - mavlink_and_console_log_info(mavlink_log_pub, "[cal] Battery connected"); + calibration_log_info(mavlink_log_pub, "[cal] Battery connected"); } } } @@ -175,20 +176,20 @@ Out: } if (fd != -1) { if (px4_ioctl(fd, PWM_SERVO_SET_FORCE_SAFETY_ON, 0) != OK) { - mavlink_and_console_log_info(mavlink_log_pub, CAL_QGC_WARNING_MSG, "Safety switch still off"); + calibration_log_info(mavlink_log_pub, CAL_QGC_WARNING_MSG, "Safety switch still off"); } if (px4_ioctl(fd, PWM_SERVO_DISARM, 0) != OK) { - mavlink_and_console_log_info(mavlink_log_pub, CAL_QGC_WARNING_MSG, "Servos still armed"); + calibration_log_info(mavlink_log_pub, CAL_QGC_WARNING_MSG, "Servos still armed"); } if (px4_ioctl(fd, PWM_SERVO_CLEAR_ARM_OK, 0) != OK) { - mavlink_and_console_log_info(mavlink_log_pub, CAL_QGC_WARNING_MSG, "Safety switch still deactivated"); + calibration_log_info(mavlink_log_pub, CAL_QGC_WARNING_MSG, "Safety switch still deactivated"); } px4_close(fd); } armed->in_esc_calibration_mode = false; if (return_code == OK) { - mavlink_and_console_log_info(mavlink_log_pub, CAL_QGC_DONE_MSG, "esc"); + calibration_log_info(mavlink_log_pub, CAL_QGC_DONE_MSG, "esc"); } return return_code; diff --git a/src/modules/commander/gyro_calibration.cpp b/src/modules/commander/gyro_calibration.cpp index 6684bb88c5..2f93432bc9 100644 --- a/src/modules/commander/gyro_calibration.cpp +++ b/src/modules/commander/gyro_calibration.cpp @@ -122,7 +122,7 @@ static calibrate_return gyro_calibration_worker(int cancel_sub, void* data) } if (s == 0 && calibration_counter[0] % (calibration_count / 20) == 0) { - mavlink_and_console_log_info(worker_data->mavlink_log_pub, CAL_QGC_PROGRESS_MSG, (calibration_counter[0] * 100) / calibration_count); + calibration_log_info(worker_data->mavlink_log_pub, CAL_QGC_PROGRESS_MSG, (calibration_counter[0] * 100) / calibration_count); } } @@ -131,14 +131,14 @@ static calibrate_return gyro_calibration_worker(int cancel_sub, void* data) } if (poll_errcount > 1000) { - mavlink_and_console_log_critical(worker_data->mavlink_log_pub, CAL_ERROR_SENSOR_MSG); + calibration_log_critical(worker_data->mavlink_log_pub, CAL_ERROR_SENSOR_MSG); return calibrate_return_error; } } for (unsigned s = 0; s < max_gyros; s++) { if (worker_data->device_id[s] != 0 && calibration_counter[s] < calibration_count / 2) { - mavlink_and_console_log_critical(worker_data->mavlink_log_pub, "[cal] ERROR: missing data, sensor %d", s) + calibration_log_critical(worker_data->mavlink_log_pub, "[cal] ERROR: missing data, sensor %d", s) return calibrate_return_error; } @@ -155,7 +155,7 @@ int do_gyro_calibration(orb_advert_t *mavlink_log_pub) int res = OK; gyro_worker_data_t worker_data = {}; - mavlink_and_console_log_info(mavlink_log_pub, CAL_QGC_STARTED_MSG, sensor_name); + calibration_log_info(mavlink_log_pub, CAL_QGC_STARTED_MSG, sensor_name); worker_data.mavlink_log_pub = mavlink_log_pub; @@ -180,7 +180,7 @@ int do_gyro_calibration(orb_advert_t *mavlink_log_pub) (void)sprintf(str, "CAL_GYRO%u_ID", s); res = param_set_no_notification(param_find(str), &(worker_data.device_id[s])); if (res != OK) { - mavlink_and_console_log_critical(mavlink_log_pub, "[cal] Unable to reset CAL_GYRO%u_ID", s); + calibration_log_critical(mavlink_log_pub, "[cal] Unable to reset CAL_GYRO%u_ID", s); return ERROR; } @@ -195,7 +195,7 @@ int do_gyro_calibration(orb_advert_t *mavlink_log_pub) px4_close(fd); if (res != OK) { - mavlink_and_console_log_critical(mavlink_log_pub, CAL_ERROR_RESET_CAL_MSG, s); + calibration_log_critical(mavlink_log_pub, CAL_ERROR_RESET_CAL_MSG, s); return ERROR; } } @@ -256,7 +256,7 @@ int do_gyro_calibration(orb_advert_t *mavlink_log_pub) device_id_primary = worker_data.device_id[s]; } } else { - mavlink_and_console_log_critical(mavlink_log_pub, "[cal] Gyro #%u no device id, abort", s); + calibration_log_critical(mavlink_log_pub, "[cal] Gyro #%u no device id, abort", s); } } @@ -294,7 +294,7 @@ int do_gyro_calibration(orb_advert_t *mavlink_log_pub) fabsf(ydiff) > maxoff || fabsf(zdiff) > maxoff) { - mavlink_and_console_log_critical(mavlink_log_pub, "[cal] motion, retrying.."); + calibration_log_critical(mavlink_log_pub, "[cal] motion, retrying.."); res = ERROR; } else { @@ -306,7 +306,7 @@ int do_gyro_calibration(orb_advert_t *mavlink_log_pub) } while (res == ERROR && try_count <= max_tries); if (try_count >= max_tries) { - mavlink_and_console_log_critical(mavlink_log_pub, "[cal] ERROR: Motion during calibration"); + calibration_log_critical(mavlink_log_pub, "[cal] ERROR: Motion during calibration"); res = ERROR; } @@ -351,14 +351,14 @@ int do_gyro_calibration(orb_advert_t *mavlink_log_pub) px4_close(fd); if (res != OK) { - mavlink_and_console_log_critical(mavlink_log_pub, CAL_ERROR_APPLY_CAL_MSG, 1); + calibration_log_critical(mavlink_log_pub, CAL_ERROR_APPLY_CAL_MSG, 1); } #endif } } if (failed) { - mavlink_and_console_log_critical(mavlink_log_pub, "[cal] ERROR: failed to set offset params"); + calibration_log_critical(mavlink_log_pub, "[cal] ERROR: failed to set offset params"); res = ERROR; } } @@ -375,7 +375,7 @@ int do_gyro_calibration(orb_advert_t *mavlink_log_pub) res = param_save_default(); if (res != OK) { - mavlink_and_console_log_critical(mavlink_log_pub, CAL_ERROR_SAVE_PARAMS_MSG); + calibration_log_critical(mavlink_log_pub, CAL_ERROR_SAVE_PARAMS_MSG); } } @@ -383,9 +383,9 @@ int do_gyro_calibration(orb_advert_t *mavlink_log_pub) usleep(200000); if (res == OK) { - mavlink_and_console_log_info(mavlink_log_pub, CAL_QGC_DONE_MSG, sensor_name); + calibration_log_info(mavlink_log_pub, CAL_QGC_DONE_MSG, sensor_name); } else { - mavlink_and_console_log_info(mavlink_log_pub, CAL_QGC_FAILED_MSG, sensor_name); + calibration_log_info(mavlink_log_pub, CAL_QGC_FAILED_MSG, sensor_name); } /* give this message enough time to propagate */ diff --git a/src/modules/commander/mag_calibration.cpp b/src/modules/commander/mag_calibration.cpp index 8b72f85b3c..755a8c8aa0 100644 --- a/src/modules/commander/mag_calibration.cpp +++ b/src/modules/commander/mag_calibration.cpp @@ -100,7 +100,7 @@ typedef struct { int do_mag_calibration(orb_advert_t *mavlink_log_pub) { - mavlink_and_console_log_info(mavlink_log_pub, CAL_QGC_STARTED_MSG, sensor_name); + calibration_log_info(mavlink_log_pub, CAL_QGC_STARTED_MSG, sensor_name); struct mag_calibration_s mscale_null; mscale_null.x_offset = 0.0f; @@ -126,7 +126,7 @@ int do_mag_calibration(orb_advert_t *mavlink_log_pub) (void)sprintf(str, "CAL_MAG%u_ID", cur_mag); result = param_set_no_notification(param_find(str), &(device_ids[cur_mag])); if (result != OK) { - mavlink_and_console_log_info(mavlink_log_pub, "[cal] Unable to reset CAL_MAG%u_ID", cur_mag); + calibration_log_info(mavlink_log_pub, "[cal] Unable to reset CAL_MAG%u_ID", cur_mag); break; } #else @@ -179,7 +179,7 @@ int do_mag_calibration(orb_advert_t *mavlink_log_pub) result = px4_ioctl(fd, MAGIOCSSCALE, (long unsigned int)&mscale_null); if (result != OK) { - mavlink_and_console_log_critical(mavlink_log_pub, CAL_ERROR_RESET_CAL_MSG, cur_mag); + calibration_log_critical(mavlink_log_pub, CAL_ERROR_RESET_CAL_MSG, cur_mag); } /* calibrate range */ @@ -187,7 +187,7 @@ int do_mag_calibration(orb_advert_t *mavlink_log_pub) result = px4_ioctl(fd, MAGIOCCALIBRATE, fd); if (result != OK) { - mavlink_and_console_log_info(mavlink_log_pub, "[cal] Skipped scale calibration, sensor %u", cur_mag); + calibration_log_info(mavlink_log_pub, "[cal] Skipped scale calibration, sensor %u", cur_mag); /* this is non-fatal - mark it accordingly */ result = OK; } @@ -213,16 +213,16 @@ int do_mag_calibration(orb_advert_t *mavlink_log_pub) usleep(200000); if (result == OK) { - mavlink_and_console_log_info(mavlink_log_pub, CAL_QGC_PROGRESS_MSG, 100); - mavlink_and_console_log_info(mavlink_log_pub, CAL_QGC_DONE_MSG, sensor_name); + calibration_log_info(mavlink_log_pub, CAL_QGC_PROGRESS_MSG, 100); + calibration_log_info(mavlink_log_pub, CAL_QGC_DONE_MSG, sensor_name); break; } else { - mavlink_and_console_log_critical(mavlink_log_pub, CAL_ERROR_SAVE_PARAMS_MSG); + calibration_log_critical(mavlink_log_pub, CAL_ERROR_SAVE_PARAMS_MSG); } // Fall through default: - mavlink_and_console_log_critical(mavlink_log_pub, CAL_QGC_FAILED_MSG, sensor_name); + calibration_log_critical(mavlink_log_pub, CAL_QGC_FAILED_MSG, sensor_name); break; } } @@ -263,8 +263,8 @@ static calibrate_return mag_calibration_worker(detect_orientation_return orienta mag_worker_data_t* worker_data = (mag_worker_data_t*)(data); - mavlink_and_console_log_info(worker_data->mavlink_log_pub, "[cal] Rotate vehicle around the detected orientation"); - mavlink_and_console_log_info(worker_data->mavlink_log_pub, "[cal] Continue rotation for %u seconds", worker_data->calibration_interval_perside_seconds); + calibration_log_info(worker_data->mavlink_log_pub, "[cal] Rotate vehicle around the detected orientation"); + calibration_log_info(worker_data->mavlink_log_pub, "[cal] Continue rotation for %u seconds", worker_data->calibration_interval_perside_seconds); /* * Detect if the system is rotating. @@ -299,7 +299,7 @@ static calibrate_return mag_calibration_worker(detect_orientation_return orienta if (hrt_absolute_time() > detection_deadline) { result = calibrate_return_error; warnx("int: %8.4f, %8.4f, %8.4f", (double)gyro_x_integral, (double)gyro_y_integral, (double)gyro_z_integral); - mavlink_and_console_log_critical(worker_data->mavlink_log_pub, "Failed: This calibration requires rotation."); + calibration_log_critical(worker_data->mavlink_log_pub, "Failed: This calibration requires rotation."); break; } @@ -394,7 +394,7 @@ static calibrate_return mag_calibration_worker(detect_orientation_return orienta calibration_counter_side++; // Progress indicator for side - mavlink_and_console_log_info(worker_data->mavlink_log_pub, + calibration_log_info(worker_data->mavlink_log_pub, "[cal] %s side calibration: progress <%u>", detect_orientation_str(orientation), progress_percentage(worker_data) + (unsigned)((100 / calibration_sides) * ((float)calibration_counter_side / (float)worker_data->calibration_points_perside))); @@ -405,16 +405,16 @@ static calibrate_return mag_calibration_worker(detect_orientation_return orienta if (poll_errcount > worker_data->calibration_points_perside * 3) { result = calibrate_return_error; - mavlink_and_console_log_info(worker_data->mavlink_log_pub, CAL_ERROR_SENSOR_MSG); + calibration_log_info(worker_data->mavlink_log_pub, CAL_ERROR_SENSOR_MSG); break; } } if (result == calibrate_return_ok) { - mavlink_and_console_log_info(worker_data->mavlink_log_pub, "[cal] %s side done, rotate to a different side", detect_orientation_str(orientation)); + calibration_log_info(worker_data->mavlink_log_pub, "[cal] %s side done, rotate to a different side", detect_orientation_str(orientation)); worker_data->done_count++; - mavlink_and_console_log_info(worker_data->mavlink_log_pub, CAL_QGC_PROGRESS_MSG, progress_percentage(worker_data)); + calibration_log_info(worker_data->mavlink_log_pub, CAL_QGC_PROGRESS_MSG, progress_percentage(worker_data)); } return result; @@ -460,7 +460,7 @@ calibrate_return mag_calibrate_all(orb_advert_t *mavlink_log_pub, int32_t (&devi worker_data.y[cur_mag] = reinterpret_cast(malloc(sizeof(float) * calibration_points_maxcount)); worker_data.z[cur_mag] = reinterpret_cast(malloc(sizeof(float) * calibration_points_maxcount)); if (worker_data.x[cur_mag] == NULL || worker_data.y[cur_mag] == NULL || worker_data.z[cur_mag] == NULL) { - mavlink_and_console_log_critical(mavlink_log_pub, "[cal] ERROR: out of memory"); + calibration_log_critical(mavlink_log_pub, "[cal] ERROR: out of memory"); result = calibrate_return_error; } } @@ -483,7 +483,7 @@ calibrate_return mag_calibrate_all(orb_advert_t *mavlink_log_pub, int32_t (&devi device_ids[cur_mag] = mag_report.device_id; #endif if (worker_data.sub_mag[cur_mag] < 0) { - mavlink_and_console_log_critical(mavlink_log_pub, "[cal] Mag #%u not found, abort", cur_mag); + calibration_log_critical(mavlink_log_pub, "[cal] Mag #%u not found, abort", cur_mag); result = calibrate_return_error; break; } @@ -498,7 +498,7 @@ calibrate_return mag_calibrate_all(orb_advert_t *mavlink_log_pub, int32_t (&devi device_id_primary = device_ids[cur_mag]; } } else { - mavlink_and_console_log_critical(mavlink_log_pub, "[cal] Mag #%u no device id, abort", cur_mag); + calibration_log_critical(mavlink_log_pub, "[cal] Mag #%u no device id, abort", cur_mag); result = calibrate_return_error; break; } @@ -512,7 +512,7 @@ calibrate_return mag_calibrate_all(orb_advert_t *mavlink_log_pub, int32_t (&devi // Mag in this slot is available unsigned int orb_interval_msecs = (worker_data.calibration_interval_perside_useconds / 1000) / worker_data.calibration_points_perside; - //mavlink_and_console_log_info(mavlink_log_pub, "Orb interval %u msecs", orb_interval_msecs); + //calibration_log_info(mavlink_log_pub, "Orb interval %u msecs", orb_interval_msecs); orb_set_interval(worker_data.sub_mag[cur_mag], orb_interval_msecs); } } @@ -559,15 +559,15 @@ calibrate_return mag_calibrate_all(orb_advert_t *mavlink_log_pub, int32_t (&devi &sphere_radius[cur_mag]); if (!PX4_ISFINITE(sphere_x[cur_mag]) || !PX4_ISFINITE(sphere_y[cur_mag]) || !PX4_ISFINITE(sphere_z[cur_mag])) { - mavlink_and_console_log_emergency(mavlink_log_pub, "ERROR: Retry calibration (sphere NaN, #%u)", cur_mag); + calibration_log_emergency(mavlink_log_pub, "ERROR: Retry calibration (sphere NaN, #%u)", cur_mag); result = calibrate_return_error; } if (fabsf(sphere_x[cur_mag]) > MAG_MAX_OFFSET_LEN || fabsf(sphere_y[cur_mag]) > MAG_MAX_OFFSET_LEN || fabsf(sphere_z[cur_mag]) > MAG_MAX_OFFSET_LEN) { - mavlink_and_console_log_emergency(mavlink_log_pub, "ERROR: Replace %s mag fault", (internal[cur_mag]) ? "autopilot, internal" : "GPS unit, external"); - mavlink_and_console_log_info(mavlink_log_pub, "Excessive offsets: %8.4f, %8.4f, %8.4f, #%u", (double)sphere_x[cur_mag], + calibration_log_emergency(mavlink_log_pub, "ERROR: Replace %s mag fault", (internal[cur_mag]) ? "autopilot, internal" : "GPS unit, external"); + calibration_log_info(mavlink_log_pub, "Excessive offsets: %8.4f, %8.4f, %8.4f, #%u", (double)sphere_x[cur_mag], (double)sphere_y[cur_mag], (double)sphere_z[cur_mag], cur_mag); result = calibrate_return_ok; } @@ -639,13 +639,13 @@ calibrate_return mag_calibrate_all(orb_advert_t *mavlink_log_pub, int32_t (&devi (void)sprintf(str, "%s%u", MAG_BASE_DEVICE_PATH, cur_mag); fd_mag = px4_open(str, 0); if (fd_mag < 0) { - mavlink_and_console_log_critical(mavlink_log_pub, "[cal] ERROR: unable to open mag device #%u", cur_mag); + calibration_log_critical(mavlink_log_pub, "[cal] ERROR: unable to open mag device #%u", cur_mag); result = calibrate_return_error; } if (result == calibrate_return_ok) { if (px4_ioctl(fd_mag, MAGIOCGSCALE, (long unsigned int)&mscale) != OK) { - mavlink_and_console_log_critical(mavlink_log_pub, "[cal] ERROR: failed to get current calibration #%u", cur_mag); + calibration_log_critical(mavlink_log_pub, "[cal] ERROR: failed to get current calibration #%u", cur_mag); result = calibrate_return_error; } } @@ -658,7 +658,7 @@ calibrate_return mag_calibrate_all(orb_advert_t *mavlink_log_pub, int32_t (&devi #ifndef __PX4_QURT if (px4_ioctl(fd_mag, MAGIOCSSCALE, (long unsigned int)&mscale) != OK) { - mavlink_and_console_log_critical(mavlink_log_pub, CAL_ERROR_APPLY_CAL_MSG, cur_mag); + calibration_log_critical(mavlink_log_pub, CAL_ERROR_APPLY_CAL_MSG, cur_mag); result = calibrate_return_error; } #endif @@ -696,14 +696,14 @@ calibrate_return mag_calibrate_all(orb_advert_t *mavlink_log_pub, int32_t (&devi #endif if (failed) { - mavlink_and_console_log_critical(mavlink_log_pub, CAL_ERROR_SET_PARAMS_MSG, cur_mag); + calibration_log_critical(mavlink_log_pub, CAL_ERROR_SET_PARAMS_MSG, cur_mag); result = calibrate_return_error; } else { - mavlink_and_console_log_info(mavlink_log_pub, "[cal] mag #%u off: x:%.2f y:%.2f z:%.2f Ga", + calibration_log_info(mavlink_log_pub, "[cal] mag #%u off: x:%.2f y:%.2f z:%.2f Ga", cur_mag, (double)mscale.x_offset, (double)mscale.y_offset, (double)mscale.z_offset); #ifndef __PX4_QURT - mavlink_and_console_log_info(mavlink_log_pub, "[cal] mag #%u scale: x:%.2f y:%.2f z:%.2f", + calibration_log_info(mavlink_log_pub, "[cal] mag #%u scale: x:%.2f y:%.2f z:%.2f", cur_mag, (double)mscale.x_scale, (double)mscale.y_scale, (double)mscale.z_scale); #endif