From e109d2d6b566df4ce1cc73e4d0749c1a793ff47d Mon Sep 17 00:00:00 2001 From: Samuel Sadok Date: Thu, 22 Jul 2021 10:59:51 +0200 Subject: [PATCH] Fix missing new line when ASCII protocol is used with checksums. See https://github.com/odriverobotics/ODrive/issues/596 --- Firmware/communication/ascii_protocol.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Firmware/communication/ascii_protocol.cpp b/Firmware/communication/ascii_protocol.cpp index 532d72e1..5d7bdab7 100644 --- a/Firmware/communication/ascii_protocol.cpp +++ b/Firmware/communication/ascii_protocol.cpp @@ -53,7 +53,7 @@ void AsciiProtocol::respond(bool include_checksum, const char * fmt, TArgs&& ... uint8_t checksum = 0; for (size_t i = 0; i < len; ++i) checksum ^= tx_buf[i]; - len += snprintf(tx_buf + len, sizeof(tx_buf) - len, "*%u", checksum); + len += snprintf(tx_buf + len, sizeof(tx_buf) - len, "*%u\r\n", checksum); } else { len += snprintf(tx_buf + len, sizeof(tx_buf) - len, "\r\n"); }